[Bug 12465] New: XSLT: Missing punctuation between 710$a and $b
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 Bug ID: 12465 Summary: XSLT: Missing punctuation between 710$a and $b Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org If you have a record with 710$a and $b, there is no space or punctuation between the fields in result list and detail page in OPAC and staff. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9820 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |MARC Bibliographic data | |support Assignee|oleonard@myacpl.org |gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Example: 710 2 _aDeutschland _bBundestag _0(DE-588b)2116123-9 _0(DE-576)193731266 _9167 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29145&action=edit Bug 12465: Improve display of MARC21 710 in intranet and OPAC Currently, 710$a and $b and $b will not display correctly. This patch tries to improve the display adding the missing space between both subfields. Please test. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure if the attached patch fixes all cases and is ok as it is. Feedback very welcome! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29145|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29146&action=edit Bug 12465: Improve display of MARC21 710 in intranet and OPAC Currently, 710$a and $b and $b will not display correctly. This patch tries to improve the display adding the missing space between both subfields. Please test. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29146|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 29193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29193&action=edit [SIGNED-OFF] Bug 12465: Improve display of MARC21 710 in intranet and OPAC Currently, 710$a and $b and $b will not display correctly. This patch tries to improve the display adding the missing space between both subfields. Please test. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested, work as described on staff & opac for 710 detailed view. Add space and punctuation. No errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Taking a look :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30391&action=edit Bug 12465: Improve display of MARC21 710 in intranet and OPAC Currently, 710$a and $b and $b will not display correctly. This patch tries to improve the display adding the missing space between both subfields. Please test. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested, work as described on staff & opac for 710 detailed view. Add space and punctuation. No errors. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: This patch improves the situation. Before $a and $b were glued together. Now we have a space in between everywhere for subfields a-b-c-d-n. I am not saying that we already reached the ideal solution. Just listing multiple $b's after $a with a space (and even more subfields possible) may probably not always be so clear. But I do not have "the better solution" at hand for this moment :) Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Marcel! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29193|0 |1 is obsolete| | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- *** Bug 10957 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'm not sure about the result. I prefered my approach on the other bug. But this is a good start. Maybe later someone will make it even better. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry to have missed your bug - it wasn't intentional. :( I kept it rather simple, because I was not totally sure either. Feedback from a cataloguing expert might be good :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- We agreed the patch needs to be revisited as it chomps any punctuation added by the cataloguer. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Tomas, for testing purposes I have cataloged the examples for 710 (from the German MARC21 translation, but they should be the same as on the LOC website, which is currently down for maintenance, these are the results: Examples: $aMinnesota. $bConstitutional Convention $d(1857 : $gRepublican) $aHerbert E. Budek Films and Slides (Firm) $aUnited States. $bArmy Map Service. $tEastern United States 1:250,000. $aNew Orleans Blue Serenaders. $4prf $aWGBH (Television station : Boston, Mass.) $aHallmark Collection (Library of Congress) $5DLC $aBridgewater Library, $eformer owner. $5NjP $a Algeria. $t Treaties, etc. $g England and Wales, $d 1682 Apr. 20. $a Catholic Church. $t Mass, 33rd Sunday of ordinary time (Chant). $f 1979. $a Catholic Church. $b Pope (1958-1963 : John XXIII). $t Mater et magistra. $l French. $k Selections. $f 1963. $a United States. $t Constitution. $p 13th Amendment. $a Ecuador. $t Plan Nacional de Desarrollo, 1980-1984. $n Parte 1, $p Grandes objetivos nacionales. $l English. With the existing patch: Minnesota. Constitutional Convention (1857; United States. Army Map Service; New Orleans Blue Serenaders [prf]; WGBH (Television station : Boston, Mass.); Hallmark Collection (Library of Congress); Bridgewater Library [former owner.]; Algeria. 1682 Apr. 20; Catholic Church; Catholic Church Pope ( 1958-1963 : John XXIII); United States; Ecuador. Parte 1. Displaying 'as catalogued': by Herbert E. Budek Films and Slides (Firm); Minnesota. Constitutional Convention (1857:; United States. Army Map Service.; New Orleans Blue Serenaders [prf]; WGBH (Television station : Boston, Mass.); Hallmark Collection (Library of Congress); Bridgewater Library, [former owner.]; Algeria. 1682 Apr. 20.; Catholic Church.; Catholic Church Pope ( 1958-1963 : John XXIII).; United States.; Ecuador. Parte 1,. What we can see: - we are not displaying all subfields currently that could be used - the patch is just chopping off punctuation off the last subfield, which seems ok, since we are using semicolons between every 710. Could you take another look? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_4_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |gmcharlt@gmail.com --- Comment #16 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.4. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org