[Bug 9036] New: 00-load.t checks Koha::Cache::Memcached when it should not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9036 Priority: P5 - low Change sponsored?: --- Bug ID: 9036 Assignee: gmcharlt@gmail.com Summary: 00-load.t checks Koha::Cache::Memcached when it should not Severity: normal Classification: Unclassified OS: All Reporter: cnighswonger@foundations.edu Hardware: All Status: NEW Version: master Component: Test Suite Product: Koha Memcached related modules are optional, not mandatory, so we should not be testing related code in the basic test suite. ------------------ $ prove t t/00-checkdatabase-version.t ........ ok t/00-deprecated.t ................... ok t/00-load.t ......................... 2/? Too late to run INIT block at /home/cnighswonger/Repositories/koha.3.2.labels//C4/Barcodes/hbyymmincr.pm line 41. Too late to run INIT block at /home/cnighswonger/Repositories/koha.3.2.labels//C4/External/BakerTaylor.pm line 42. t/00-load.t ......................... 133/? # Failed test 'use Koha::Cache::Memcached;' Bailout called. Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::Cache::Memcached' # at t/00-load.t line 48. # Tried to use 'Koha::Cache::Memcached'. # Error: Can't locate Cache/Memcached/Fast.pm in @INC (@INC contains: /home/cnighswonger/Repositories/koha.3.2.labels/ /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at /home/cnighswonger/Repositories/koha.3.2.labels//Koha/Cache/Memcached.pm line 23. # BEGIN failed--compilation aborted at /home/cnighswonger/Repositories/koha.3.2.labels//Koha/Cache/Memcached.pm line 23. # Compilation failed in require at (eval 1325) line 2. # BEGIN failed--compilation aborted at (eval 1325) line 2. # Tests were run but no plan was declared and done_testing() was not seen. FAILED--Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::Cache::Memcached' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9036 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |cnighswonger@foundations.ed | |u -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9036 --- Comment #1 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 13325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13325&action=edit Bug 9036 - 00-load.t checks Koha::Cache::Memcached when it should not this patch adds code to skip this module during this test -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9036 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9036 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7119 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9036 --- Comment #2 from Chris Nighswonger <cnighswonger@foundations.edu> --- NOTE: The associated patch attached to bug 7119 *must* be applied *first* in order for this patch to apply cleanly. You've been warned.... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9036 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9036 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9036 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13325|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 13334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13334&action=edit Bug 9036 - 00-load.t checks Koha::Cache::Memcached when it should not this patch adds code to skip this module during this test Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9036 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9054 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9036 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Upping severity. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9036 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com Version|master |3.10 --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * tiny patch * passes koha-qa.pl * 17:37 ~/koha.dev/koha-community (new/bug_9036 $%)$ prove t/00-load.t t/00-load.t .. ok All tests successful. Files=1, Tests=141, 4 wallclock secs ( 0.09 usr 0.02 sys + 2.16 cusr 0.17 csys = 2.44 CPU) Result: PASS => passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9036 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13334|0 |1 is obsolete| | --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 13398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13398&action=edit Bug 9036 - 00-load.t checks Koha::Cache::Memcached when it should not this patch adds code to skip this module during this test Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9036 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9036 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9036 Bug 9036 depends on bug 7119, which changed state. Bug 7119 Summary: general code-cleaning, tidy/whitespace omnibus http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7119 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9036 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org