[Bug 6836] New: jQuery plugin Datatables integration
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Bug #: 6836 Summary: jQuery plugin Datatables integration Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Architecture, internals, and plumbing AssignedTo: gmcharlt@gmail.com ReportedBy: julian.maurice@biblibre.com QAContact: koha-bugs@lists.koha-community.org The coming patch add the javascript library, a CSS (and image files from datatables.net) and another javascript file which provides some extra features. It also add a Perl module C4::Utils::Datatables which provides helpful functions for server-side processing. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> 2011-09-02 10:36:51 UTC --- Created attachment 5284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5284 Patch for DataTables -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> 2011-09-02 12:58:05 UTC --- Created attachment 5291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5291 Forgotten patch for translation This patch adds a default option object, which, when passed to dataTable(), set the language strings. Without it, datatables strings can not been translated. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5284|0 |1 is obsolete| | Attachment #5291|0 |1 is obsolete| | --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> 2011-09-02 14:45:41 UTC --- Created attachment 5294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5294 New patch This patch includes the preceding two patches, and fix minor issues (a missing parenthesis in a string, and rename a javascript function). This is the final patch (I hope). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6838 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED CC| |nengard@gmail.com Patch Status|--- |Needs Signoff AssignedTo|gmcharlt@gmail.com |julian.maurice@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2011-09-19 20:05:15 UTC --- How can this patch be tested? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> 2011-09-20 07:16:14 UTC --- It can be tested with bug 6838. Apply this patch first and then the patch for 6838 which is an example of datatables usage. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |Rel_3_8 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-24 11:38:19 UTC --- Updating Version : This ENH will be for Koha 3.8 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Rel_3_8 |master --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-25 15:05:55 UTC --- Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7119 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> 2011-11-17 16:13:51 UTC --- (In reply to comment #2)
This patch adds a default option object, which, when passed to dataTable(), set the language strings. Without it, datatables strings can not been translated.
If you're referring to /intranet-tmpl/prog/en/js/datatables.js, those strings will not be translated because js files are not processed by the translator. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> 2011-11-18 09:21:59 UTC --- (In reply to comment #8)
(In reply to comment #2)
This patch adds a default option object, which, when passed to dataTable(), set the language strings. Without it, datatables strings can not been translated.
If you're referring to /intranet-tmpl/prog/en/js/datatables.js, those strings will not be translated because js files are not processed by the translator.
So I have to put translatable strings into a .inc file? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> 2011-11-18 13:24:05 UTC --- (In reply to comment #9)
So I have to put translatable strings into a .inc file?
Until we have a fix for Bug 4503, any strings output by JavaScript must be handled in a template somehow. See the Cart for a good example of how that can be done. In includes/doc-head-close.inc: 91 var MSG_NO_RECORD_SELECTED = _("No item was selected"); In js/basket.js 414 if (bibs.length == 0) { showListsUpdate(MSG_NO_RECORD_SELECTED); } 415 return bibs.join("&"); -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> 2011-11-18 17:30:06 UTC --- Created attachment 6340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6340 Follow-up changes - Changing default styles for Datatables pager, filter, etc. to make it more like the style we have now on table pagers - Adding another paging style via a plugin function in js/datatables.js to give us a "four_button" option (more like the old tablesorter.js pager). - Tweaking configuration on serials-home.tt and adding the same to readingrec.tt I don't have much serials data so I added it to readingrec.tt as well. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> 2011-11-18 17:43:20 UTC --- When working on the patch described in Comment 11 I was trying to make the transition from tablesorters.js to Datatables smoother from the user's point of view, providing a compact version of the Datatables UI similar to the tablesorter pager we have now. Now that I've gotten a handle on the basic configuration options I can see that for instances where we use tablesorter.js the transition should be really smooth. I'm a little concerned about the significant increase in the plugin size: About 13K for tablesorter.js (17K if you count the pager plugin too) versus 70K for the datatables base plugin plus 15K for the custom configuration file. But I guess it's a trade-off for the increased functionality... What do you think of the default style changes I'm proposing? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> 2011-11-18 17:44:40 UTC --- By the way, my patch was created on top of the patch for this bug and the one Bug 6838. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> 2011-11-23 16:06:43 UTC --- It's much more beautiful like this! But I have some remarks: - Some image files in CSS are not in my local repository and don't come with the patch (img/arrow-*.png). This causes "full_numbers" pagination to have large empty space before or after labels ("First", "Back", etc.) - The first patch provides datatables for opac and intranet, so it would be great to have your work for opac too - The initial goal of this bug is to provide only the javascript library and other stuff (css, images, ...) but no tables using it, so patches contain only new files and could be easy to apply. Maybe you can separate your patch in two parts (and remove the modif on serials-home.tt so we can apply both patches from bug 6836 without applying patch from bug 6838) - If I don't use the 'sDom' property, the display is completely broken, so it has to be fixed - Using the default pagination type, at the bottom we have the two buttons (previous and next) and a right border, immediately followed by the div border (very minor bug) - I prefer images from datatables.net rather than the ones used with tablesorter, but it's just a matter of taste (In reply to comment #12)
I'm a little concerned about the significant increase in the plugin size: About 13K for tablesorter.js (17K if you count the pager plugin too) versus 70K for the datatables base plugin plus 15K for the custom configuration file. But I guess it's a trade-off for the increased functionality...
Good point, I haven't noticed that. But it seems that DataTables is still faster than tablesorter. For example, on authorised values admin page, with large list of values (~1000), tablesorter sometimes caused firefox freezes and DataTables don't (but maybe it's just a firefox issue, I don't know) It certainly have to be tested. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins@cpbibliography.com --- Comment #15 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2011-11-23 16:15:36 UTC --- Julian, I can confirm that's a Firefox issue. The workaround is to disable the tablesorter entirely. If datatables eliminates the freezing, that seems like a worthwhile exchange. Just set a far-future expiration on the js. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> 2011-11-23 16:24:49 UTC ---
- Some image files in CSS are not in my local repository and don't come with the patch (img/arrow-*.png). This causes "full_numbers" pagination to have large empty space before or after labels ("First", "Back", etc.)
Confirmed, sorry about that.
- The initial goal of this bug is to provide only the javascript library and other stuff (css, images, ...) but no tables using it, so patches contain only new files and could be easy to apply. Maybe you can separate your patch in two parts (and remove the modif on serials-home.tt so we can apply both patches from bug 6836 without applying patch from bug 6838)
Sure, I just wanted an easily-testable patch so I could get others' input on the changes I was playing around with.
- If I don't use the 'sDom' property, the display is completely broken, so it has to be fixed
I don't understand.
- I prefer images from datatables.net rather than the ones used with tablesorter, but it's just a matter of taste
Let's get some more opinions.
(In reply to comment #12)
I'm a little concerned about the significant increase in the plugin size:
Good point, I haven't noticed that. But it seems that DataTables is still faster than tablesorter. For example, on authorised values admin page, with large list of values (~1000), tablesorter sometimes caused firefox freezes and DataTables don't (but maybe it's just a firefox issue, I don't know)
I'm glad you've tested with larger data sets. Performance has certainly been an issue with tablesorter, so it would be nice for that factor to be another plus for DataTables. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #17 from Julian Maurice <julian.maurice@biblibre.com> 2011-11-24 08:37:46 UTC --- Created attachment 6387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6387 Broken display without custom 'sDom' property (In reply to comment #16)
- If I don't use the 'sDom' property, the display is completely broken, so it has to be fixed
I don't understand.
I'm refering to these lines: $("#table_readingrec").dataTable({ "sPaginationType": "four_button", "sDom": '<"top pager"ilpf>t<"bottom pager"ip>' }); If you remove the "sDom" property (so it will take the default value), the display is broken (see screenshot attached). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5294|0 |1 is obsolete| | --- Comment #18 from Frédéric Demians <frederic@tamil.fr> 2011-11-30 13:46:11 UTC --- Created attachment 6467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6467 Signed-off patch adding DataTable jQuert plugin -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6340|0 |1 is obsolete| | --- Comment #19 from Frédéric Demians <frederic@tamil.fr> 2011-11-30 13:48:41 UTC --- Created attachment 6468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6468 Signed-off Owen patch styling and using DataTable in reading history I confirm Owen styling is effective both in readingrec.tt (efficent on large reading history) and in serials-home.pl page. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7167 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6467|0 |1 is obsolete| | --- Comment #20 from Julian Maurice <julian.maurice@biblibre.com> 2011-12-02 09:55:56 UTC --- Created attachment 6522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6522 Add jQuery dataTables plugin New patch with translatable strings DataTables strings are now in a separate .inc file -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6387|0 |1 is obsolete| | Attachment #6468|0 |1 is obsolete| | --- Comment #21 from Julian Maurice <julian.maurice@biblibre.com> 2011-12-02 09:58:51 UTC --- Created attachment 6523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6523 Follow-up CSS work This is the Owen's patch, with "sDom" property added in default datatables options, and modifications for opac too. The readingrec.tt patch is not included in it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #22 from Julian Maurice <julian.maurice@biblibre.com> 2011-12-02 09:59:25 UTC --- Created attachment 6524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6524 Test case on readingrec.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Does not apply --- Comment #23 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> 2011-12-02 13:39:10 UTC --- 14:38 ~/dev/community_repo/koha (ft/6836|AM u+2)$ git-bz apply 6836 ... Test case on readingrec.pl Apply? [yn] y Applying: Bug 6836: test case readingrec.pl error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt:1 error: koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt: patch does not apply Patch failed at 0001 Bug 6836: test case readingrec.pl When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Test-case-on-readingrecpl-2_BnTq.patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins@cpbibliography.com | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #24 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> 2011-12-02 14:37:15 UTC --- Forget it, this patch applies well and better with 3 way merge in git bz. (In reply to comment #23) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger@foundations.ed | |u --- Comment #25 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-12-02 16:41:15 UTC --- The current implementation in readingrec.pl produces the following JS error: k is undefined http://kohadev-staff.campus.foundations.edu/intranet-tmpl/prog/en/lib/jquery... Line 152 I can't see the cause right off as I'm still reading through the code. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #26 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-12-02 18:10:08 UTC --- Since there are multiple ways to implement Datatables, it would be nice to see a complete writing describing the method of implementation used in this work including the rational for the chosen method. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Blocks| |6842 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #27 from Julian Maurice <julian.maurice@biblibre.com> 2011-12-28 15:20:55 UTC --- I just tested it right now: $ git checkout master $ git pull --rebase $ git checkout -b test6836 $ git bz apply 6836 Bug 6836 - jQuery plugin Datatables integration Add jQuery dataTables plugin Apply? [yn] y Applying: Bug 6836: Add jQuery dataTables plugin Follow-up CSS work Apply? [yn] y Applying: Bug 6836: followup CSS work Test case on readingrec.pl Apply? [yn] y Applying: Bug 6836: test case readingrec.pl Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt And I get no errors on readingrec.pl. Sorry, but I can't help you :-/ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #28 from Julian Maurice <julian.maurice@biblibre.com> 2011-12-28 15:25:56 UTC --- (In reply to comment #26)
Since there are multiple ways to implement Datatables, it would be nice to see a complete writing describing the method of implementation used in this work including the rational for the chosen method.
You're right, and something like that was already started in BibLibre wiki. So I will do it soon. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #29 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-30 10:08:06 UTC --- (In reply to comment #28)
You're right, and something like that was already started in BibLibre wiki. So I will do it soon. written, and available here: http://wiki.koha-community.org/wiki/DataTables_HowTo
The 1st part (switching actual Tables to datatable) is ready. What is still a WIP is the part related to moving to dynamic loading of the page for large tables. But such a move will have to be made only for a few tables, and it does not prevent this patch to be signed off I also tested this patch, it worked fine, and I couldn't see any javascript error. QA comment: There are 2 minor perlcritic errors: perlcritic C4/Utils/DataTables.pm Code before strictures are enabled at line 25, column 1. See page 429 of PBP. (Severity: 5) Variable declared in conditional statement at line 111, column 5. Declare variables outside of the condition. (Severity: 5) other tests are OK: prove xt/author/valid-templates.t xt/author/valid-templates.t .. ok prove xt/author/translatable-templates.txt/author/translatable-templates.t .. ok -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #30 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-30 10:17:58 UTC ---
QA comment: There are 2 minor perlcritic errors: perlcritic C4/Utils/DataTables.pm Code before strictures are enabled at line 25, column 1. See page 429 of PBP. (Severity: 5) Variable declared in conditional statement at line 111, column 5. Declare variables outside of the condition. (Severity: 5)
Just FYI severity 5 is the most severe. Those are pretty severe style violations. Chris -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
There are 2 minor perlcritic errors: perlcritic C4/Utils/DataTables.pm Code before strictures are enabled at line 25, column 1. See page 429 of PBP. (Severity: 5) Variable declared in conditional statement at line 111, column 5. Declare variables outside of the condition. (Severity: 5)
Just FYI severity 5 is the most severe. Those are pretty severe style violations. Agreed. By "minor" I wanted to say "easy to fix". The 1st is fixed by a use strict at the beginning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #31 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-30 10:49:10 UTC --- (In reply to comment #30) the 2nd one is also easy to fix by removing the declaration from the condition! but they must be fixed to have the patch pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #32 from Julian Maurice <julian.maurice@biblibre.com> 2011-12-30 11:05:02 UTC --- (In reply to comment #31)
The 1st is fixed by a use strict at the beginning
Modern::Perl already includes a "use strict". Is it really the way to fix it? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5345 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6522|0 |1 is obsolete| | --- Comment #33 from Julian Maurice <julian.maurice@biblibre.com> 2012-01-12 10:34:41 UTC --- Created attachment 7112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7112 Add jQuery dataTables plugin Corrected patch for perlcritic message:
Variable declared in conditional statement at line 111, column 5. Declare variables outside of the condition. (Severity: 5)
'use strict' not added since it's redundant with Modern::Perl I've seen that adding these lines to perlcritic.rc prevent this error to be printed: [TestingAndDebugging::RequireUseStrict] equivalent_modules = Modern::Perl [TestingAndDebugging::RequireUseWarnings] equivalent_modules = Modern::Perl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #34 from Chris Cormack <chris@bigballofwax.co.nz> 2012-01-13 04:01:54 UTC --- Testing this now, this adds a new dependency on Modern::Perl Which is no big issue, I will do a follow up to add that to the dependencies, and a follow up to change the perlcriticrc I will sign off on these, but I think they still need another sign off, so will leave the status as needs sign off, but they should be in a state to test well now -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7112|0 |1 is obsolete| | --- Comment #35 from Chris Cormack <chris@bigballofwax.co.nz> 2012-01-13 04:02:52 UTC --- Created attachment 7120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7120 Bug 6836: Add jQuery dataTables plugin This patch add the javascript library, a CSS (and image files from datatables.net) and another javascript file which provides some extra features. It also add a Perl module C4::Utils::Datatables which provides helpful functions for server-side processing Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6523|0 |1 is obsolete| | --- Comment #36 from Chris Cormack <chris@bigballofwax.co.nz> 2012-01-13 04:04:18 UTC --- Created attachment 7121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7121 Bug 6836: followup CSS work Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6524|0 |1 is obsolete| | --- Comment #37 from Chris Cormack <chris@bigballofwax.co.nz> 2012-01-13 04:05:32 UTC --- Created attachment 7122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7122 Bug 6836: test case readingrec.pl Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #38 from Chris Cormack <chris@bigballofwax.co.nz> 2012-01-13 04:10:25 UTC --- Created attachment 7123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7123 Updating perlcriticrc to allow Modern::Perl to suffice instead of use warnings; and use strict; -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #39 from Chris Cormack <chris@bigballofwax.co.nz> 2012-01-13 04:17:22 UTC --- Created attachment 7124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7124 Bug 6836: Adding dependency on Modern::Perl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7169 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7123|0 |1 is obsolete| | --- Comment #40 from Julian Maurice <julian.maurice@biblibre.com> 2012-01-19 08:45:57 UTC --- Created attachment 7243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7243 [SIGNED-OFF] Updating perlcriticrc to allow Modern::Perl to suffice instead of use warnings; and use strict; Signed off, as perlcritic -p t/perlcriticrc C4/Utils/DataTables.pm returns no error about strictures. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7124|0 |1 is obsolete| | --- Comment #41 from Julian Maurice <julian.maurice@biblibre.com> 2012-01-19 08:46:43 UTC --- Created attachment 7244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7244 Bug 6836: Adding dependency on Modern::Perl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7244|Bug 6836: Adding dependency |[SIGNED-OFF] Bug 6836: description|on Modern::Perl |Adding dependency on | |Modern::Perl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7120|0 |1 is obsolete| | Attachment #7121|0 |1 is obsolete| | Attachment #7122|0 |1 is obsolete| | Attachment #7243|0 |1 is obsolete| | Attachment #7244|0 |1 is obsolete| | --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-23 21:33:13 UTC --- Created attachment 7298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7298 [SIGNED-OFF] Bug 6836: Add jQuery dataTables plugin This patch add the javascript library, a CSS (and image files from datatables.net) and another javascript file which provides some extra features. It also add a Perl module C4::Utils::Datatables which provides helpful functions for server-side processing Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-23 21:33:25 UTC --- Created attachment 7299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7299 [SIGNED-OFF] Bug 6836: followup CSS work Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-23 21:33:33 UTC --- Created attachment 7300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7300 [SIGNED-OFF] Bug 6836: test case readingrec.pl Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I tested the functionality and tested translation. All important strings are in the template and can be translated. Good work! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-23 21:33:40 UTC --- Created attachment 7301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7301 [SIGNED-OFF] Updating perlcriticrc to allow Modern::Perl to suffice instead of use warnings; and use strict; http://bugs.koha-community.org/show_bug.cgi?id=6836 Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-23 21:33:47 UTC --- Created attachment 7302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7302 [SIGNED-OFF] Bug 6836: Adding dependency on Modern::Perl Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P2 CC| |katrin.fischer@bsz-bw.de -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Summary|jQuery plugin Datatables |jQuery plugin Datatables |integration |integration | |http://wiki.koha-community. | |org/wiki/DataTables_HowTo --- Comment #47 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-27 10:49:14 UTC --- QA comments: * no comments to do about the plugin itself, it's external code * strongly tested by many ppl * only a few code outside from the patch itself * documentation added on the wiki good stuff, passed QA ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution| |FIXED --- Comment #48 from Julian Maurice <julian.maurice@biblibre.com> 2012-02-22 16:24:58 UTC --- Ok in master, marked as resolved -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Bug 6836 depends on bug 7119, which changed state. Bug 7119 Summary: general code-cleaning, tidy/whitespace omnibus http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7119 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org