[Bug 41685] New: MARC21: Sort 4xx/5xx in BuildSummary alphabetic within hierarchy ($w: g or h)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 Bug ID: 41685 Summary: MARC21: Sort 4xx/5xx in BuildSummary alphabetic within hierarchy ($w: g or h) Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org Currently, the list of seefrom/seealso is sorted in the order of the MARC fields. We would like to sort the Broader terms first and the Narrower terms last, with other terms in the middle. All groups should be sorted alphabetically on $a. This summary is mainly used in the authority search results on OPAC and intranet. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 192118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192118&action=edit Bug 46185: Sort see from / see also in BuildSummary Test plan: Comes very soon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 Jeroen De Meester <j.de.meester@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.de.meester@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192118|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Comment on attachment 192118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192118 Bug 46185: Sort see from / see also in BuildSummary Wrong bug number -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 192318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192318&action=edit Bug 41685: Sort seefrom/seealso in BuildSummary Test plan (MARC21): [1] Create an authority record, say a term. Include two 450s, the first one starting with Z and second with A. Include five 550s, where two are narrower ($w==h), two broader ($w==g) and one without $w. Make sure that the terms will sort differently than the field order (go back in alphabet when filling subsequent $a's or so). [2] Perform an authority search that includes the new authority. [3] Verify that the terms in the Summary column for this authority are sorted first on hierarchy, second alphabetically. The one without hierarchy should be in the middle. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 192319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192319&action=edit Bug 41685: Unit tests Test plan: Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192318|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192319|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 192539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192539&action=edit Bug 41685: Sort seefrom/seealso in BuildSummary Test plan (MARC21): [1] Create an authority record, say a term. Include two 450s, the first one starting with Z and second with A. Include five 550s, where two are narrower ($w==h), two broader ($w==g) and one without $w. Make sure that the terms will sort differently than the field order (go back in alphabet when filling subsequent $a's or so). [2] Perform an authority search that includes the new authority. [3] Verify that the terms in the Summary column for this authority are sorted first on hierarchy, second alphabetically. The one without hierarchy should be in the middle. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 192540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192540&action=edit Bug 41685: Unit tests Test plan: Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement changes release notes| |the order of "see also" | |terms (450 and 550) in the | |staff interface and OPAC | |authority search results: | |- broader terms first ($w = | |g) | |- other terms in the middle | |(w = no value) | |- narrower terms last ($w = | |h) | |- each grouping sorted | |alphabetically (on $a). | | | |They are currently shown in | |the order they are entered | |in the authority record. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Nind from comment #6)
Created attachment 192540 [details] [review] Bug 41685: Unit tests
Test plan: Run t/db_dependent/AuthoritiesMarc.t
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com>
Thx David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 192587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192587&action=edit Bug 41685: (QA follow-up) Resolve qa warnings Resolve critic warn: "return" statement followed by "sort" at line 1238, column 5. Behavior is undefined if called in scalar context. (Severity: 5) Tidied with lastest perltidy version. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 193004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193004&action=edit Bug 41685: (QA follow-up) Prevent uninit warn on missing subfield a Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure if the alphabetic ordering could get some cataloguers upset. Maybe bring this up in the cataloguing channel? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #10)
I am not sure if the alphabetic ordering could get some cataloguers upset. Maybe bring this up in the cataloguing channel?
Asked for feedback on Mattermost before without any response.. Our cataloguers love this change btw. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192539|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192540|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192587|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193004|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #12 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 198135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198135&action=edit Bug 41685: Sort seefrom/seealso in BuildSummary Test plan (MARC21): [1] Create an authority record, say a term. Include two 450s, the first one starting with Z and second with A. Include five 550s, where two are narrower ($w==h), two broader ($w==g) and one without $w. Make sure that the terms will sort differently than the field order (go back in alphabet when filling subsequent $a's or so). [2] Perform an authority search that includes the new authority. [3] Verify that the terms in the Summary column for this authority are sorted first on hierarchy, second alphabetically. The one without hierarchy should be in the middle. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #13 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 198136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198136&action=edit Bug 41685: Unit tests Test plan: Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #14 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 198137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198137&action=edit Bug 41685: (QA follow-up) Resolve qa warnings Resolve critic warn: "return" statement followed by "sort" at line 1238, column 5. Behavior is undefined if called in scalar context. (Severity: 5) Tidied with lastest perltidy version. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #15 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 198138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198138&action=edit Bug 41685: (QA follow-up) Prevent uninit warn on missing subfield a Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #16 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 198139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198139&action=edit Bug 41685: (QA follow-up) Add POD for _marc21_sort_hierarchy_alpha - koha-qa pod_coverage check flagged the new private helper - sub as uncovered. Document it briefly to satisfy the check. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #17 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 198140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198140&action=edit Bug 41685: (QA follow-up) Classify MARC21 $w by position 0 MARC21 4xx/5xx $w is a control subfield with up to four positions; only position 0 encodes the hierarchical relationship. The previous regex required the whole subfield to equal g or h, so values such as "g " or "gnna" would fall into the middle bucket and lose the broader/narrower distinction. This case is hypothetical and likely rare in practice (most catalogs store a single character in $w), but the correctness improvement still makes sense and aligns with how BuildSummary reads the same subfield elsewhere via substr($w, 0, 1). To test: - prove -v t/db_dependent/AuthoritiesMarc.t - Verify BuildSummary/_marc21_sort_hierarchy_alpha subtest passes, including the new multi-position $w case. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Paul Derscheid from comment #17)
Created attachment 198140 [details] [review] Bug 41685: (QA follow-up) Classify MARC21 $w by position 0
MARC21 4xx/5xx $w is a control subfield with up to four positions; only position 0 encodes the hierarchical relationship. The previous regex required the whole subfield to equal g or h, so values such as "g " or "gnna" would fall into the middle bucket and lose the broader/narrower distinction.
This case is hypothetical and likely rare in practice (most catalogs store a single character in $w), but the correctness improvement still makes sense and aligns with how BuildSummary reads the same subfield elsewhere via substr($w, 0, 1).
To test: - prove -v t/db_dependent/AuthoritiesMarc.t - Verify BuildSummary/_marc21_sort_hierarchy_alpha subtest passes, including the new multi-position $w case.
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Thanks. Looks good to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #11)
(In reply to Katrin Fischer from comment #10)
I am not sure if the alphabetic ordering could get some cataloguers upset. Maybe bring this up in the cataloguing channel?
Asked for feedback on Mattermost before without any response.. Our cataloguers love this change btw.
Fair :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198135|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198136|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198137|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198138|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198139|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198140|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 198706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198706&action=edit Bug 41685: Sort seefrom/seealso in BuildSummary Test plan (MARC21): [1] Create an authority record, say a term. Include two 450s, the first one starting with Z and second with A. Include five 550s, where two are narrower ($w==h), two broader ($w==g) and one without $w. Make sure that the terms will sort differently than the field order (go back in alphabet when filling subsequent $a's or so). [2] Perform an authority search that includes the new authority. [3] Verify that the terms in the Summary column for this authority are sorted first on hierarchy, second alphabetically. The one without hierarchy should be in the middle. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 198707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198707&action=edit Bug 41685: Unit tests Test plan: Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 198708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198708&action=edit Bug 41685: (QA follow-up) Resolve qa warnings Resolve critic warn: "return" statement followed by "sort" at line 1238, column 5. Behavior is undefined if called in scalar context. (Severity: 5) Tidied with lastest perltidy version. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 198709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198709&action=edit Bug 41685: (QA follow-up) Prevent uninit warn on missing subfield a Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 198710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198710&action=edit Bug 41685: (QA follow-up) Add POD for _marc21_sort_hierarchy_alpha - koha-qa pod_coverage check flagged the new private helper - sub as uncovered. Document it briefly to satisfy the check. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 198711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198711&action=edit Bug 41685: (QA follow-up) Classify MARC21 $w by position 0 MARC21 4xx/5xx $w is a control subfield with up to four positions; only position 0 encodes the hierarchical relationship. The previous regex required the whole subfield to equal g or h, so values such as "g " or "gnna" would fall into the middle bucket and lose the broader/narrower distinction. This case is hypothetical and likely rare in practice (most catalogs store a single character in $w), but the correctness improvement still makes sense and aligns with how BuildSummary reads the same subfield elsewhere via substr($w, 0, 1). To test: - prove -v t/db_dependent/AuthoritiesMarc.t - Verify BuildSummary/_marc21_sort_hierarchy_alpha subtest passes, including the new multi-position $w case. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |paul.derscheid@lmscloud.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #27 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Created attachment 200775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200775&action=edit Bug 41685: (RM follow-up): Remove dead comment code Patch from commit 5437ad6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #28 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |lucas@bywatersolutions.com --- Comment #29 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement will not be backported to 26.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org