https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41685 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Paul Derscheid from comment #17)
Created attachment 198140 [details] [review] Bug 41685: (QA follow-up) Classify MARC21 $w by position 0
MARC21 4xx/5xx $w is a control subfield with up to four positions; only position 0 encodes the hierarchical relationship. The previous regex required the whole subfield to equal g or h, so values such as "g " or "gnna" would fall into the middle bucket and lose the broader/narrower distinction.
This case is hypothetical and likely rare in practice (most catalogs store a single character in $w), but the correctness improvement still makes sense and aligns with how BuildSummary reads the same subfield elsewhere via substr($w, 0, 1).
To test: - prove -v t/db_dependent/AuthoritiesMarc.t - Verify BuildSummary/_marc21_sort_hierarchy_alpha subtest passes, including the new multi-position $w case.
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Thanks. Looks good to me. -- You are receiving this mail because: You are watching all bug changes.