[Bug 11533] New: "use" QueryParser breaks authority search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 Bug ID: 11533 Summary: "use" QueryParser breaks authority search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org To reproduce: - Set a dev install (i did it using DOM) and launch zebrasrv. - Verify that ~/koha-dev/koha-conf.xml points to an existent file in the 'queryparser_config' section. - Initialize the DB with the default data add a few authority records and reindex. - Search for the authority records (More > Authorities) => The results are there - Enable QP (sysprefs > "use" QueryParser - Do the same search => No results -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 24236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24236&action=edit Bug 11533: (regression test) QP breaks authority search This patch duplicates the SearchAuthority tests, with QP enabled. Searching shouldn't be affected by QP. Instructions for manually reproducing this can be read in the first comment for the bug entry. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24236|0 |1 is obsolete| | --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 24471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24471&action=edit Bug 11533: (regression test) QP breaks authority search This patch duplicates the SearchAuthority tests, with QP enabled. Searching shouldn't be affected by QP. Instructions for manually reproducing this can be read in the first comment for the bug entry. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 24472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24472&action=edit Bug 11533: fix authority searching with no sorting when QueryParser is enabled This patch fixes an issue where chosing 'None' as the sort order for an authority search would result in zero hits if QueryParser is eanbled. This patch also adds some additional test cases. To test: [1] Enable QueryParser. [2] Perform an authority search in the staff interface that uses 'Heading A-Z' as the sort order and returns hits. [3] Run the same search, but with the sort order set to 'None'. No hits are returned. [4] Apply the patch. [5] Do step 3 again. This time, hits should be returned. [6] Verify that prove -v t/db_dependent/Search.t passes. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #0)
To reproduce: - Set a dev install (i did it using DOM) and launch zebrasrv. - Verify that ~/koha-dev/koha-conf.xml points to an existent file in the 'queryparser_config' section. - Initialize the DB with the default data add a few authority records and reindex. - Search for the authority records (More > Authorities) => The results are there - Enable QP (sysprefs > "use" QueryParser - Do the same search => No results
For folks attempting to reproduce the bug -- without the patches, it breaks for me only with the sort order is set to 'None'. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24472|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 24610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24610&action=edit Bug 11533: fix authority searching with no sorting when QueryParser is enabled This patch fixes an issue where chosing 'None' as the sort order for an authority search would result in zero hits if QueryParser is eanbled. This patch also adds some additional test cases. To test: [1] Enable QueryParser. [2] Perform an authority search in the staff interface that uses 'Heading A-Z' as the sort order and returns hits. [3] Run the same search, but with the sort order set to 'None'. No hits are returned. [4] Apply the patch. [5] Do step 3 again. This time, hits should be returned. [6] Verify that prove -v t/db_dependent/Search.t passes. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24471|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24682&action=edit Bug 11533: (regression test) QP breaks authority search This patch duplicates the SearchAuthority tests, with QP enabled. Searching shouldn't be affected by QP. Instructions for manually reproducing this can be read in the first comment for the bug entry. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24610|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24683&action=edit Bug 11533: fix authority searching with no sorting when QueryParser is enabled This patch fixes an issue where chosing 'None' as the sort order for an authority search would result in zero hits if QueryParser is eanbled. This patch also adds some additional test cases. To test: [1] Enable QueryParser. [2] Perform an authority search in the staff interface that uses 'Heading A-Z' as the sort order and returns hits. [3] Run the same search, but with the sort order set to 'None'. No hits are returned. [4] Apply the patch. [5] Do step 3 again. This time, hits should be returned. [6] Verify that prove -v t/db_dependent/Search.t passes. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks for the regression test, Tomas! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11533 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch pushed to 3.14.x, will be in 3.14.06 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org