[Bug 11534] New: impossible to remove instructions on course reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 Bug ID: 11534 Summary: impossible to remove instructions on course reserve Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Course reserves Assignee: koha-bugs@lists.koha-community.org Reporter: marjorie.barry-vila@ccsr.qc.ca QA Contact: testopia@bugs.koha-community.org Hi, On editing a course reserve, i can not remove an instructor. When i click on remove, nothing happens. Someone has already tested it? Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 marjorie barry-vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|impossible to remove |impossible to remove |instructions on course |instructors on course |reserve |reserve -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 marjorie barry-vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |wizzyrea@gmail.com --- Comment #1 from Liz Rea <wizzyrea@gmail.com> --- Hi Marjorie, I was able to do this in Master and the instructor was removed correctly. What browser and OS are you using? Cheers, Liz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 --- Comment #2 from marjorie barry-vila <marjorie.barry-vila@ccsr.qc.ca> --- Hi Liz, I'm using firefox 26.0 and windows 7. I also tested on google chrome 31 et IE11 but it does not work. I tested also on http://intranet.bywatersolutions.com but it does the same, i can not remove instructors. An idea? Thanks, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I can reproduce this bug in FF26 on Win7, also in FF26 and Chromium on Ubuntu. Nothing happens when I click the "remove" link but no JavaScript errors are reported. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- A card number is passed to RemoveInstructor() in order to remove a the <div> containing the relevant field: $( '#borrower_' + cardnumber ).remove(); ...but the <div> looks like this: <div id="borrower_0011960"> ...and the number passed to the function is this: 11960 Could the JavaScript engine in Liz's browser have different type handling? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 --- Comment #5 from Liz Rea <wizzyrea@gmail.com> --- Hmm, mine was Chromium and Firefox (latest on both) in Ubuntu, and it still worked in both. I tried with long and short cardnumbers, I'm just not seeing it. But since you guys did, I'll believe you that it exists. :) Liz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Marjorie do your patron card numbers have leading zeroes? I suspect that's why Liz can't reproduce the error but I can. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 --- Comment #7 from Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> --- Created attachment 24869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24869&action=edit link remove instructor course reserve -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 --- Comment #8 from Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> --- Hi Owen, No there is no zeroes in patron card number. See the capture for the link when i do a hover on "remove". Liz, do you see the same? Thanks, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 24871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24871&action=edit Bug 11534 - impossible to remove instructors on course reserve In some cases clicking the "remove" link to remove a course instructor when editing a course reserves course doesn't work. I suspect this is caused by leading zeroes in the card number. This patch refactors the relevant function to fix the problem and to remove inline JavaScript from generated markup. Other changes: - Make the "Remove" text translatable - Re-order the first name and last name when added by JavaScript to match the template's "surname, firstname" order. To test: 1. If necessary, create or modify a patron to have a card number with leading zeroes. 2. Go to Course reserves and add or edit a course. 3. If you are editing a course and there are existing instructors, click the "remove" link. Nothing will happen. 4. Perform a patron search and choose one of the results. The name should be added to the list of instructors in the format "surname, firstname." 5. Click the "remove" link next to the patron name which was just added. Nothing will happen. 6. Apply the patch and repeat step 4. The "remove" link should work. 7. Add an instructor and save the course reserve. Repeat steps 2 and 3. The "remove" link should now work. To test the translation fix, after applying the patch run "translate update [language code]" and confirm that the "Remove" string is listed in the updated po file for course_reserves/course.tt. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 --- Comment #10 from Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> --- Owen, I understood why i did not be able to remove my instructors. There is no number in the cardnumber I used, there is only letters... I tested it with a cardnumber with numbers (without leading zero) and it works! So, a cardnumber can contain letters? Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Marjorie Barry-Vila from comment #10)
There is no number in the cardnumber I used, there is only letters...
That's good to know. My patch should fix the problem for both of us. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24871|0 |1 is obsolete| | --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 24878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24878&action=edit Bug 11534 - impossible to remove instructors on course reserve In some cases clicking the "remove" link to remove a course instructor when editing a course reserves course doesn't work. I suspect this is caused by leading zeroes in the card number. This patch refactors the relevant function to fix the problem and to remove inline JavaScript from generated markup. Other changes: - Make the "Remove" text translatable - Re-order the first name and last name when added by JavaScript to match the template's "surname, firstname" order. To test: 1. If necessary, create or modify a patron to have a card number with leading zeroes. 2. Go to Course reserves and add or edit a course. 3. If you are editing a course and there are existing instructors, click the "remove" link. Nothing will happen. 4. Perform a patron search and choose one of the results. The name should be added to the list of instructors in the format "surname, firstname." 5. Click the "remove" link next to the patron name which was just added. Nothing will happen. 6. Apply the patch and repeat step 4. The "remove" link should work. 7. Add an instructor and save the course reserve. Repeat steps 2 and 3. The "remove" link should now work. To test the translation fix, after applying the patch run "translate update [language code]" and confirm that the "Remove" string is listed in the updated po file for course_reserves/course.tt. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24878|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24904&action=edit Bug 11534 - impossible to remove instructors on course reserve In some cases clicking the "remove" link to remove a course instructor when editing a course reserves course doesn't work. I suspect this is caused by leading zeroes in the card number. This patch refactors the relevant function to fix the problem and to remove inline JavaScript from generated markup. Other changes: - Make the "Remove" text translatable - Re-order the first name and last name when added by JavaScript to match the template's "surname, firstname" order. To test: 1. If necessary, create or modify a patron to have a card number with leading zeroes. 2. Go to Course reserves and add or edit a course. 3. If you are editing a course and there are existing instructors, click the "remove" link. Nothing will happen. 4. Perform a patron search and choose one of the results. The name should be added to the list of instructors in the format "surname, firstname." 5. Click the "remove" link next to the patron name which was just added. Nothing will happen. 6. Apply the patch and repeat step 4. The "remove" link should work. 7. Add an instructor and save the course reserve. Repeat steps 2 and 3. The "remove" link should now work. To test the translation fix, after applying the patch run "translate update [language code]" and confirm that the "Remove" string is listed in the updated po file for course_reserves/course.tt. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #14 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #15 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch pushed to 3.14.x, will be in 3.14.06 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org