http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 --- Comment #1 from Winona Salesky <wsalesky@gmail.com> --- Created attachment 39050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39050&action=edit Bug 14181 : MARC21 773 -- Display when ind1 = 0 or blank Display 773 in opac and staff details when ind1 !=1 Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 773 with ind1 set to 0 or blanks 4) Check display 6) Repeat steps 3 and 4 for the staff interface -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39050|0 |1 is obsolete| | --- Comment #3 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39054&action=edit Bug 14181 : MARC21 773 -- Display when ind1 = 0 or blank Display 773 in opac and staff details when ind1 !=1 Test plan ========= 1/ Add a new record which uses the 773 field to an instance running master code. (the selected MARC framework should have the 773's relevant sub-fields enabled and visible on staff client, opac and the editor). 2/ Set ind1 as '0' (zero). The note should be displayed both on OPAC as well as the staff client. 3/ Reset ind1 with a non-zero value or leave it blank. The display note should no longer be visible from either client or opac. 4/ Apply the patch. 5/ Repeat step #1 and #2. The note is displayed on staff and opac. 6/ Repeat step #3. The display note should be visible on both staff and opac. 7/ run koha-qa.pl -c 1 -v 2 Note : For #1 above, the following LoC record was used: http://www.loc.gov/marc/bibliographic/examples.html#monographic The patch applied cleanly and performed as expected. The koha-qa.pl gave OK as results. Signed-off-by: Indranil Das Gupta <indradg@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 --- Comment #4 from Winona Salesky <wsalesky@gmail.com> --- I believe that coding ind1=0 is to suppress the display, 1 to display, and blank is just a default value. According to my understanding of the LOC rules indicate the element should be displayed as the default, or unless expressly coded as 0. Any other catalogers want to chime in? Thanks! -Winona (In reply to Indranil Das Gupta from comment #2)

(In reply to Winona Salesky from comment #0)

...

Currently 773 is set to display if ind1=0 and is suppressed if ind1 = ''. Patch will change code to display if ind1 != 1. So it will catch both scenarios.

Apologies in advance for my ignorance. but isn't the point of leaving ind1 as other than 1, is to suppress the display of the note?

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 --- Comment #6 from Winona Salesky <wsalesky@gmail.com> --- Great! Thanks, -Winona (In reply to Indranil Das Gupta from comment #5)

(In reply to Winona Salesky from comment #4)

...

I believe that coding ind1=0 is to suppress the display, 1 to display, and blank is just a default value. According to my understanding of the LOC rules indicate the element should be displayed as the default, or unless expressly coded as 0.

I discussed this with Galen Charlton, after I asked the question here. He agrees with the idea of you patch and said that should be default behavior if not set to 0.

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Attachment #39054|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 --- Comment #9 from Winona Salesky <wsalesky@gmail.com> --- Great! Thanks. -Winona (In reply to Tomás Cohen Arazi from comment #8)

Patch pushed to master.

Thanks Winona!

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Component|Cataloging |Templates -- You are receiving this mail because: You are watching all bug changes.