[Bug 11882] New: Add a new button to the checkout confirmation dialog when checking out a reserved item.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Bug ID: 11882 Summary: Add a new button to the checkout confirmation dialog when checking out a reserved item. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: fcapovilla@live.ca QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 25748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25748&action=edit Add a "Don't Check Out and Print Slip" button to the dialog that appears when trying to checkout a reserved item. This patch adds a "Don't Check Out and Print Slip" button to the dialog that appears when trying to checkout a reserved item. Test case : * Put a hold on an item for User A. * Try to check out it item with User B. * The "Please confirm checkout" box should appear. The "Don't Check Out and Print Slip" button should appear in this box. * Click on the "Don't Check Out and Print Slip" button. * You should be redirected to the "Check in" page, where a dialog will give you more informations on the hold, and let you print a reservation slip. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #1 from Frédérick Capovilla <fcapovilla@live.ca> --- Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 25819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25819&action=edit [Signed-off] Add a "Don't Check Out and Print Slip" button to the dialog that appears when trying to checkout a reserved item. http://bugs.koha-community.org/show_bug.cgi?id=11882 This patch adds a "Don't Check Out and Print Slip" button to the dialog that appears when trying to checkout a reserved item. Test case : * Put a hold on an item for User A. * Try to check out it item with User B. * The "Please confirm checkout" box should appear. The "Don't Check Out and Print Slip" button should appear in this box. * Click on the "Don't Check Out and Print Slip" button. * You should be redirected to the "Check in" page, where a dialog will give you more informations on the hold, and let you print a reservation slip. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25748|0 |1 is obsolete| | CC| |veron@veron.ch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |fcapovilla@live.ca |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- The 'cancel hold' checkbox is not taken into account (but it is already the case for the "No, don't check out" button). The redirect to returns.pl is a little bit unexpected, in my opinion. I need other qa points of view for this one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #3)
The 'cancel hold' checkbox is not taken into account (but it is already the case for the "No, don't check out" button). The redirect to returns.pl is a little bit unexpected, in my opinion.
I need other qa points of view for this one.
I agree, the behavior of this patch is very odd. I don't think the redirect is a very good idea. It feels very much like a hack especially since the user is not told this is what will happen. I would expect it to remain on the circulation screen and open a hold slip popup the same way the "print and confirm" button does on returns.pl. I see no reason why it could not be implemented that way. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Kyle M Hall from comment #4)
I would expect it to remain on the circulation screen and open a hold slip popup the same way the "print and confirm" button does on returns.pl. I see no reason why it could not be implemented that way.
Part of the problem is that the button text isn't clear about what is going to happen, but I agree with Kyle that it could be handled better with regard to the checkout process. It would be great not to interrupt the checkout session. "Confirm hold and print slip" maybe, triggering the popup? And then circulation.pl returns to a state where it is ready to check out another item to that patron. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com, | |philippe.blouin@inlibro.com | |, | |simith.doliveira@inlibro.co | |m Assignee|fcapovilla@live.ca |simith.doliveira@inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #6 from simith.doliveira@inlibro.com --- Created attachment 31342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31342&action=edit Bug 11882 - Add a new button to the checkout confirmation dialog when checking out a reserved item This patch adds a "Don't Check Out and Print Slip" button to the dialog that appears when trying to checkout a reserved item. Test case : * Put a hold on an item for User A. * Try to check out it item with User B. * The "Please confirm checkout" box should appear. The "Don't Check Out and Print Slip" button should appear in this box. * Click on the "Don't Check Out and Print Slip" button. * A print popup will appear -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25819|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11882 - Add a new button to the checkout confirmation dialog when checking out a reserved item fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31342|0 |1 is obsolete| | --- Comment #8 from simith.doliveira@inlibro.com --- Created attachment 31400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31400&action=edit Bug 11882 - Add a new button to the checkout confirmation dialog when checking out a reserved item This patch adds a "Don't Check Out and Print Slip" button to the dialog that appears when trying to checkout a reserved item. Test case : * Put a hold on an item for User A. * Try to check out it item with User B. * The "Please confirm checkout" box should appear. The "Don't Check Out and Print Slip" button should appear in this box. * Click on the "Don't Check Out and Print Slip" button. * A print popup will appear -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi@cineca.it --- Comment #9 from Paola Rossi <paola.rossi@cineca.it> --- I've applied against master 3.17.00.029 The test plan was OK as required. But, when I tried to select "Yes, check out (Y)", the page remained "Loading...". And no checkout was created for the patron. So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #10 from simith.doliveira@inlibro.com --- Created attachment 33156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33156&action=edit Add a new button to the checkout confirmation dialog when checking out a reserved item Bug 11882 - Add a new button to the checkout confirmation dialog when checking out a reserved item -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Paola Rossi <paola.rossi@cineca.it> --- I've tried to apply the two patches against master 3.17.00.055 Applying: Bug 11882 - Add a new button to the checkout confirmation dialog when checking out a reserved item Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging circ/circulation.pl Failed to merge in the changes. So I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #12 from simith.doliveira@inlibro.com --- Created attachment 34420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34420&action=edit camelot 778 lbo_RM5001_Bordereau / BZ11882 fix -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34420|0 |1 is obsolete| | --- Comment #13 from simith.doliveira@inlibro.com --- Comment on attachment 34420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34420 camelot 778 lbo_RM5001_Bordereau / BZ11882 fix
From d95afe65f1b4939d22ea27af9c531faff3e7ccd3 Mon Sep 17 00:00:00 2001 From: simith <simith@inlibro.com> Date: Mon, 3 Nov 2014 09:06:40 -0500 Subject: [PATCH] camelot 778 lbo_RM5001_Bordereau / BZ11882 fix
--- circ/circulation.pl | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/circ/circulation.pl b/circ/circulation.pl index dc41405..88a0ccc 100755 --- a/circ/circulation.pl +++ b/circ/circulation.pl @@ -380,6 +380,13 @@ if ($barcode) {
my ( $od, $issue, $fines ) = GetMemberIssuesAndFines($borrowernumber); $template->param( issuecount => $issue ); + + if ($question->{RESERVE_WAITING} or $question->{RESERVED}){ + $template->param( + reserveborrowernumber => $question->{'resborrowernumber'}, + itembiblionumber => $getmessageiteminfo->{'biblionumber'} + ); + } }
# reload the borrower info for the sake of reseting the flags..... @@ -554,17 +561,6 @@ my $relatives_issues_count = Koha::Database->new()->schema()->resultset('Issue') ->count( { borrowernumber => \@relatives } );
-(my $returned, my $messages) = AddReturn( $barcode, $branch); -if ( $messages->{'ResFound'}) { - my $reserve = $messages->{'ResFound'}; - # get biblio description - my $biblio = GetBiblioFromItemNumber($reserve->{'itemnumber'}); - $template->param( - reserveborrowernumber => $reserve->{'borrowernumber'}, - itembiblionumber => $biblio->{'biblionumber'} - ); -} - $template->param( lib_messages_loop => $lib_messages_loop, bor_messages_loop => $bor_messages_loop, -- 1.9.1
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31400|0 |1 is obsolete| | --- Comment #14 from simith.doliveira@inlibro.com --- Created attachment 34421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34421&action=edit Bug 11882 - Add a new button to the checkout confirmation dialog when checking out a reserved item This patch adds a "Don't Check Out and Print Slip" button to the dialog that appears when trying to checkout a reserved item. Test case : * Put a hold on an item for User A. * Try to check out it item with User B. * The "Please confirm checkout" box should appear. The "Don't Check Out and Print Slip" button should appear in this box. * Click on the "Don't Check Out and Print Slip" button. * A print popup will appear -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #15 from Paola Rossi <paola.rossi@cineca.it> --- I've tried to apply the 2 attached patches against master 3.19.00.000 At the first patch : Applying: camelot 778 lbo_RM5001_Bordereau / BZ11882 fix fatal: sha1 information is lacking or useless (circ/circulation.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 camelot 778 lbo_RM5001_Bordereau / BZ11882 fix So I pass the patch to "Patch doesn't apply" status. [I'm in doubt: perhaps should I have applied only the second attached patch to master?] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #16 from simith.doliveira@inlibro.com --- Don't use this patch : camelot 778 lbo_RM5001_Bordereau / BZ11882 fix this is a obsolete patch. Have just applyed (last koha version) and worked. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33156|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #17 from Paola Rossi <paola.rossi@cineca.it> --- (In reply to simith.doliveira from comment #16)
Don't use this patch : camelot 778 lbo_RM5001_Bordereau / BZ11882 fix this is a obsolete patch. Have just applyed (last koha version) and worked.
(In reply to simith.doliveira from comment #16)
Don't use this patch : camelot 778 lbo_RM5001_Bordereau / BZ11882 fix this is a obsolete patch.
So I've made that patch obsolete: logged to bugzilla, I selected the "Details" of that patch, and then I "Edit details" at top-right. Then I checked the left-bottom "obsolete" checkbox, and "submit". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #18 from Marc Véron <veron@veron.ch> --- Created attachment 34605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34605&action=edit [Signed-off] Bug 11882 - Add a new button to the checkout confirmation dialog when checking out a reserved item This patch adds a "Don't Check Out and Print Slip" button to the dialog that appears when trying to checkout a reserved item. Test case : * Put a hold on an item for User A. * Try to check out it item with User B. * The "Please confirm checkout" box should appear. The "Don't Check Out and Print Slip" button should appear in this box. * Click on the "Don't Check Out and Print Slip" button. * A print popup will appear Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34421|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Paola Rossi <paola.rossi@cineca.it> --- When I tried to select "Yes, check out (Y)", the page remained "Loading..." and no checkout was created for the patron. No item could be checked out, even if not reserved. On the contrary items can be checked out on master (3.19.00.002). I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #20 from Marc Véron <veron@veron.ch> --- Sorry, I missed check-out failing while testing for Sing-off. Reason for failing: The patch calls AddReturn( $barcode, $branch) in circ/circulation.pl (line 557) AddReturn() immediately returns the item (and adds an entry about returning it to the Circulation history) Maybe CheckReserves would be a better way, something like $tmpitem = GetBiblioItemFromItemNumber(undef, $barcode) then test return value, call CheckReserves with $tmpitem->{'itemnumber'} and fill the template params as necessary. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #21 from simith.doliveira@inlibro.com --- Created attachment 35315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35315&action=edit Fix comment 9 and 19 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #22 from simith.doliveira@inlibro.com --- The fix for the comment 19 I have already done in 2014-11-03 (to fix the comment 9) but was sent to obsolete by mistake, so I recreated it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- I don't understand the status, to me the second patch needs a signoff. Simith, could you please provide a decent commit message for it? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- Answer needed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #25 from simith.doliveira@inlibro.com --- Created attachment 36195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36195&action=edit Bug 11882 - Add a new button to the checkout confirmation dialog when checking out a reserved item This patch adds a "Don't Check Out and Print Slip" button to the dialog that appears when trying to checkout a reserved item. Test case : * Put a hold on an item for User A. * Try to check out it item with User B. * The "Please confirm checkout" box should appear. The "Don't Check Out and Print Slip" button should appear in this box. * Click on the "Don't Check Out and Print Slip" button. * A print popup will appear -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34605|1 |0 is patch| | Attachment #34605|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35315|1 |0 is patch| | Attachment #35315|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #26 from simith.doliveira@inlibro.com --- Patchs cherry picked to create a new one to be tested -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36195|0 |1 is obsolete| | --- Comment #27 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 36196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36196&action=edit Bug 11882 - Add a new button to the checkout confirmation dialog when checking out a reserved item This patch adds a "Don't Check Out and Print Slip" button to the dialog that appears when trying to checkout a reserved item. Test case : * Put a hold on an item for User A. * Try to check out it item with User B. * The "Please confirm checkout" box should appear. The "Don't Check Out and Print Slip" button should appear in this box. * Click on the "Don't Check Out and Print Slip" button. * A print popup will appear Signed-off-by: Nick <Nick@quechelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org --- Comment #28 from Nick Clemens <nick@quecheelibrary.org> --- This seems to work as expected, tested it with next available, item specific, and holds that don't respect holds rules, all seemed fine. Other buttons seemed to work too. Cancel hold checkbox would ideally be moved into/next to the 'Yes Checkout' button as it is otherwise invalid, but that is probab;y beyond scope. I like this idea, but the text seems odd to me ('Don't check and print slip'), it makes sense if you think about it, but I don't see it making intuitive sense to all of our circ staff. That being said, I can't think of a better phrasing so signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #29 from Marc Véron <veron@veron.ch> --- Created attachment 36197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36197&action=edit [Signed-off] Bug 11882 - Add a new button to the checkout confirmation dialog when checking out a reserved item This patch adds a "Don't Check Out and Print Slip" button to the dialog that appears when trying to checkout a reserved item. Test case : * Put a hold on an item for User A. * Try to check out it item with User B. * The "Please confirm checkout" box should appear. The "Don't Check Out and Print Slip" button should appear in this box. * Click on the "Don't Check Out and Print Slip" button. * A print popup will appear Signed-off-by: Nick <Nick@quechelibrary.org> Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36196|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36197|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36545&action=edit Bug 11882 - Add a new button to the checkout confirmation dialog when checking out a reserved item This patch adds a "Don't Check Out and Print Slip" button to the dialog that appears when trying to checkout a reserved item. Test case : * Put a hold on an item for User A. * Try to check out it item with User B. * The "Please confirm checkout" box should appear. The "Don't Check Out and Print Slip" button should appear in this box. * Click on the "Don't Check Out and Print Slip" button. * A print popup will appear Signed-off-by: Nick <Nick@quechelibrary.org> Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #31 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 40692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40692&action=edit Bug 11882: (QA followup) fix capitalization errors Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Simith! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #33 from Jonathan Druart <jonathan.druart@biblibre.com> --- Oops, it seems that my pass qa was an error. Not a big deal, but looking at the diff, it seems that the code could be improved: in the template, we have: IF RESERVED display_button ELSIF RESERVE_WAITING display_button Could be changed with a IF RESERVED or RESERVE_WAITING. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a new button to the |Add a new button to the |checkout confirmation |checkout confirmation |dialog when checking out a |dialog when checking out an |reserved item. |on hold item -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org