[Bug 22887] New: authorised_values is missing a unique constraint on category + authorised_value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Bug ID: 22887 Summary: authorised_values is missing a unique constraint on category + authorised_value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Code using the authorised_values table expects the combination of 'category' with 'authorised_value' to always be unique. We should constrain it as such and also reap the rewards of dbic accessors that would give us. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89550&action=edit Bug 22887: Add unique constraint to authorised_values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Blocks| |5334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] Omnibus: Add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- +1 But does the updatedb work if there are already duplicate values ? installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql insert duplicate values for instance (COUNTRY, CC) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|martin.renvoize@ptfs-europe |jonathan.druart@bugs.koha-c |.com |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101790&action=edit Bug 22887: Warn if duplicates exist -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101791&action=edit Bug 22887: Rely on unique constraint in av admin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101792&action=edit Bug 22887: Remove dup in fr-FR av.sql https://en.wikipedia.org/wiki/Cocos_(Keeling)_Islands -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101791|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101793&action=edit Bug 22887: Rely on unique constraint in av admin Test plan: Try to create 2 AV with the same code for the same category. You should see a warning -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #5)
Created attachment 101792 [details] [review] Bug 22887: Remove dup in fr-FR av.sql
Other .sql files seem ok -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Oooh.. great to see this one moving.. thanks for following through on it Jonathan.. I clearly dropped the ball :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89550|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 101889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101889&action=edit Bug 22887: Add unique constraint to authorised_values Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101790|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 101890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101890&action=edit Bug 22887: Warn if duplicates exist Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101792|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 101891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101891&action=edit Bug 22887: Remove dup in fr-FR av.sql https://en.wikipedia.org/wiki/Cocos_(Keeling)_Islands Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101793|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 101892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101892&action=edit Bug 22887: Rely on unique constraint in av admin Test plan: Try to create 2 AV with the same code for the same category. You should see a warning Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks great to me, signing off :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula@hypernova.fi --- Comment #14 from Lari Taskula <lari.taskula@hypernova.fi> --- +1, just noticed this too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #15 from Lari Taskula <lari.taskula@hypernova.fi> --- Comment on attachment 101890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101890 Bug 22887: Warn if duplicates exist Review of attachment 101890: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22887&attachment=101890) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/bug_22887.perl @@ +7,5 @@
+ GROUP BY category, authorised_value + HAVING c > 1 + |, { Slice => {} }); + if ( @$duplicates ) { + warn "WARNING - Cannot create unique constraint on authorised_value(category, authorised_value)\n";
Nice to give a warning. We should still make sure the constraint actually gets created for everyone. Perhaps delete the duplicates and print & log what was deleted? Or die instead of warn. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101889|0 |1 is obsolete| | --- Comment #16 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102409&action=edit Bug 22887: Add unique constraint to authorised_values Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101890|0 |1 is obsolete| | --- Comment #17 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102410&action=edit Bug 22887: Warn if duplicates exist Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101891|0 |1 is obsolete| | --- Comment #18 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102411&action=edit Bug 22887: Remove dup in fr-FR av.sql https://en.wikipedia.org/wiki/Cocos_(Keeling)_Islands Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101892|0 |1 is obsolete| | --- Comment #19 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102412&action=edit Bug 22887: Rely on unique constraint in av admin Test plan: Try to create 2 AV with the same code for the same category. You should see a warning Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Lari Taskula from comment #15)
Comment on attachment 101890 [details] [review] Bug 22887: Warn if duplicates exist
Review of attachment 101890 [details] [review]: -----------------------------------------------------------------
::: installer/data/mysql/atomicupdate/bug_22887.perl @@ +7,5 @@
+ GROUP BY category, authorised_value + HAVING c > 1 + |, { Slice => {} }); + if ( @$duplicates ) { + warn "WARNING - Cannot create unique constraint on authorised_value(category, authorised_value)\n";
Nice to give a warning. We should still make sure the constraint actually gets created for everyone.
Perhaps delete the duplicates and print & log what was deleted?
Or die instead of warn.
The idea is to not remove data that could be use by a fork in a different way. I usually prefer to not remove the data, and warn, instead of remove them and... sometimes people forgets to backup their DB... ;) But I am not strongly attached to the approach here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #21 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102511&action=edit Bug 22887: Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #22 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Jonathan Druart from comment #20)
(In reply to Lari Taskula from comment #15)
Comment on attachment 101890 [details] [review] [review] Bug 22887: Warn if duplicates exist
Review of attachment 101890 [details] [review] [review]: -----------------------------------------------------------------
::: installer/data/mysql/atomicupdate/bug_22887.perl @@ +7,5 @@
+ GROUP BY category, authorised_value + HAVING c > 1 + |, { Slice => {} }); + if ( @$duplicates ) { + warn "WARNING - Cannot create unique constraint on authorised_value(category, authorised_value)\n";
Nice to give a warning. We should still make sure the constraint actually gets created for everyone.
Perhaps delete the duplicates and print & log what was deleted?
Or die instead of warn.
The idea is to not remove data that could be use by a fork in a different way. I usually prefer to not remove the data, and warn, instead of remove them and... sometimes people forgets to backup their DB... ;) But I am not strongly attached to the approach here.
Indeed deleting can be a bit nasty and unfair. Then what about stopping updatedatabase.pl with die() until the sysadmin fixes the problem? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #23 from Julian Maurice <julian.maurice@biblibre.com> ---
Indeed deleting can be a bit nasty and unfair. Then what about stopping updatedatabase.pl with die() until the sysadmin fixes the problem?
I agree, the updatedatabase process should stop until the problem is fixed. Otherwise one can continue using Koha without the DB constraint and end up having more problems. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Because we never died before? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #25 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Jonathan Druart from comment #24)
Because we never died before?
Maybe that's a problem ? Because of that, two separate instances of Koha running the exact same version can have different database schema. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Feel free to open a new bug report, start a discussion and bring this to the next dev meeting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #27 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Jonathan Druart from comment #26)
Feel free to open a new bug report, start a discussion and bring this to the next dev meeting.
I think it is directly in the scope of this Bug. We must make sure a database change applies in a way that keeps database structure consistent across any vanilla Koha installation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It is what we are doing for years. Dying in the updatedatabase.pl will require more work than just adding a die statement. We need to handle the error, propagate it to the UI. The way it's done so far will make the change not trivial. Please discuss this on a separate bug report, when agreed I will add a follow-up for this update DB entry. I am willing to work on it if needed. There is much more to do in this area but this bug report is not the place for such discussion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #29 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Jonathan Druart from comment #28)
Please discuss this on a separate bug report, when agreed I will add a follow-up for this update DB entry. I am willing to work on it if needed.
There is much more to do in this area but this bug report is not the place for such discussion.
Bug 25078 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25078 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102409|0 |1 is obsolete| | --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102876&action=edit Bug 22887: Add unique constraint to authorised_values Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102410|0 |1 is obsolete| | --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102877&action=edit Bug 22887: Warn if duplicates exist Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102411|0 |1 is obsolete| | --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102878&action=edit Bug 22887: Remove dup in fr-FR av.sql https://en.wikipedia.org/wiki/Cocos_(Keeling)_Islands Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102412|0 |1 is obsolete| | --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102879&action=edit Bug 22887: Rely on unique constraint in av admin Test plan: Try to create 2 AV with the same code for the same category. You should see a warning Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102511|0 |1 is obsolete| | --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102880&action=edit Bug 22887: Schema changes Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Only wondering about this one: Bug 22887: Remove dup in fr-FR av.sql As there is a duplicate in the sample data, could we include a fix for this in the database update avoiding manual intervention for the fr-FR installations? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102898&action=edit Bug 22887: Remove dup fr-FR for existing installs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Joubu! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 102939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102939&action=edit Bug 22887: (RM follow-up) Fix Charges Test The charges test added a duplicate authorised value needlessly (it's already present in the sample data). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Keywords| |additional_work_needed --- Comment #41 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Got this: kohadev-koha@156b126f55d3:/kohadevbox/koha$ perl installer/data/mysql/updatedatabase.pl Upgrade to 19.12.00.068 done [19:57:44]: Bug 21190 - Add prefs AuthFailureLog and AuthSuccessLog Upgrade to 19.12.00.069 done [19:57:44]: Bug 22784 - Add a new suggestions.archived column Upgrade to 19.12.00.070 done [19:57:44]: Bug 22774 - Limit purchase suggestion in a specified time period DBD::mysql::db selectall_arrayref failed: Non-grouping field 'c' is used in HAVING clause [for Statement " SELECT category, authorised_value, COUNT(concat(category, ':', authorised_value)) AS c FROM authorised_values GROUP BY category, authorised_value HAVING c > 1 "] at installer/data/mysql/updatedatabase.pl line 21576. Can't use an undefined value as an ARRAY reference at installer/data/mysql/updatedatabase.pl line 21582. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, strange. I just applied the patch set on my 'outdated' master and the updatedatabase gave no error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #42)
Hm, strange. I just applied the patch set on my 'outdated' master and the updatedatabase gave no error.
Also tested on my master branch - works fine. MySQL version or something like that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #43)
(In reply to Katrin Fischer from comment #42)
Hm, strange. I just applied the patch set on my 'outdated' master and the updatedatabase gave no error.
Also tested on my master branch - works fine. MySQL version or something like that?
ok, the tests are invalid - I already have the constraint. Too late here - will have to leave that to more awake minds. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #41)
Got this:
kohadev-koha@156b126f55d3:/kohadevbox/koha$ perl installer/data/mysql/updatedatabase.pl Upgrade to 19.12.00.068 done [19:57:44]: Bug 21190 - Add prefs AuthFailureLog and AuthSuccessLog Upgrade to 19.12.00.069 done [19:57:44]: Bug 22784 - Add a new suggestions.archived column Upgrade to 19.12.00.070 done [19:57:44]: Bug 22774 - Limit purchase suggestion in a specified time period DBD::mysql::db selectall_arrayref failed: Non-grouping field 'c' is used in HAVING clause [for Statement " SELECT category, authorised_value, COUNT(concat(category, ':', authorised_value)) AS c FROM authorised_values GROUP BY category, authorised_value HAVING c > 1 "] at installer/data/mysql/updatedatabase.pl line 21576. Can't use an undefined value as an ARRAY reference at installer/data/mysql/updatedatabase.pl line 21582.
I tried with both docker-compose.mysql8.0.yml and docker-compose.mariadb_latest.yml, but cannot make it fails. Which version do you have? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #46 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102999&action=edit Bug 22887: Fix SQL syntax for MySQL 5.5 This does not happen on MySQL 8 or latest MariaDB, but does on MySQL 5.5 "Non-grouping field 'c' is used in HAVING clause" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103000&action=edit Bug 22887: Remove superfluous warn statements We print them in the description later -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #50 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17809 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 [Bug 17809] Correct some authorised values in fr-FR -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 --- Comment #51 from Joy Nelson <joy@bywatersolutions.com> --- See following bug for identified issue in AV Report Subgroups: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26622 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org