[Bug 26460] New: wrong line ending (semicolon vs comma) in request.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460 Bug ID: 26460 Summary: wrong line ending (semicolon vs comma) in request.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Bug 23777 switched request.tt to use Branches plugin, but inadvertently replace the comma in the JSON with a semicolon -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23777 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 [Bug 23777] Text converted to html entity codes in cataloguing edit form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 110072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110072&action=edit Bug 26460: Fix line ending in JSON Wrong line ending in JSON causes error: Uncaught SyntaxError: missing } after property list note: { opened at line 29579, column 15 To test: 1 - Have a title with some items not for hold in staff interface 2 - Set AllowHoldPolicyOverride to 'Allow' 3 - Attempt to place hold on the title 4 - Note JS error in the console and datatable does not load for items 5 - Apply patch 6 - Reload 7 - Error is cleared, table loads correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110072|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 110183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110183&action=edit Bug 26460: Fix line ending in JSON Wrong line ending in JSON causes error: Uncaught SyntaxError: missing } after property list note: { opened at line 29579, column 15 To test: 1 - Have a title with some items not for hold in staff interface 2 - Set AllowHoldPolicyOverride to 'Allow' 3 - Attempt to place hold on the title 4 - Note JS error in the console and datatable does not load for items 5 - Apply patch 6 - Reload 7 - Error is cleared, table loads correctly Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|wrong line ending |Wrong line ending |(semicolon vs comma) in |(semicolon vs comma) in |request.tt |request.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110183|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110231&action=edit Bug 26460: Fix line ending in JSON Wrong line ending in JSON causes error: Uncaught SyntaxError: missing } after property list note: { opened at line 29579, column 15 To test: 1 - Have a title with some items not for hold in staff interface 2 - Set AllowHoldPolicyOverride to 'Allow' 3 - Attempt to place hold on the title 4 - Note JS error in the console and datatable does not load for items 5 - Apply patch 6 - Reload 7 - Error is cleared, table loads correctly Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.05 released in| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rickard.lindfors@sh.se --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 26733 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460 Bug 26460 depends on bug 23777, which changed state. Bug 23777 Summary: Text converted to html entity codes in cataloguing edit form https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org