[Bug 33553] New: Unecessary GetCategories calls in template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553 Bug ID: 33553 Summary: Unecessary GetCategories calls in template Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs-add-modify.tt:[% SET AuthorisedValuesCategories = AuthorisedValues.GetCategories %] koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-enroll.tt:[% SET AuthorisedValuesCategories = AuthorisedValues.GetCategories %] koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt:[% SET AuthorisedValuesCategories = AuthorisedValues.GetCategories %] AuthorisedValuesCategories is not used later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12461 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 [Bug 12461] Add patron clubs feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 151200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151200&action=edit Bug 33553: Remove unecessary GetCategories calls in templates This patch removes unnecessary references to AuthorisedValues.GetCategories: SET AuthorisedValuesCategories = AuthorisedValues.GetCategories The AuthorisedValuesCategories variable is not used. To test, apply the patch and go to Tools -> Patron clubs. - If necessary, create a club template with "Allow public enrollment" enabled. - Create a new club. The club creation process should work correctly. - Open a patron account for checkout and confirm that you can enroll the patron in the new club via the "Clubs" tab. - Log in to the OPAC and confirm that you can successfully enroll yourself in the new club via the "Clubs" tab on your patron summary page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151200|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151245&action=edit Bug 33553: Remove unecessary GetCategories calls in templates This patch removes unnecessary references to AuthorisedValues.GetCategories: SET AuthorisedValuesCategories = AuthorisedValues.GetCategories The AuthorisedValuesCategories variable is not used. To test, apply the patch and go to Tools -> Patron clubs. - If necessary, create a club template with "Allow public enrollment" enabled. - Create a new club. The club creation process should work correctly. - Open a patron account for checkout and confirm that you can enroll the patron in the new club via the "Clubs" tab. - Log in to the OPAC and confirm that you can successfully enroll yourself in the new club via the "Clubs" tab on your patron summary page. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- trivial, skipping QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.07 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org