https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I have Failed QA because of a change for suggestions: 1. After the patch is applied, when you view a suggestion the breadcrumb is Home > Acqusitions > Show suggestion #X. Before the patch was applied, it was Home > Acqusitions > Suggestions > Show suggestion #X. In addition, I noted these things - the patch reflects the behaviour before it was applied: 1. ILL requests: - For most of the options for a request the breadcrumb is Home > ILL request (Edit request, Confirm request, Place request with partner, Delete request, Edit item metadata) - Should this be Home > ILL requests > Request XXXX > Action? 2. Tools > Comments: - For the tab 'Comments awaiting moderation', the 'Comments' sidebar menu option is highlighted. - For the tab 'Approved comments' it isn't. 3. Suggestions: - Sidebar menu option 'Suggestions' not highlighted sometimes when you change between the suggestion status tabs (I think this is when you select a suggestion(s) and then mark select as and choose an option where there is not a tab). Testing notes (using KTD): 1. Setting up the ILL FreeForm backend: - mkdir Koha/Illbackends - change to Illbackends directory - git clone https://github.com/PTFS-Europe/koha-ill-freeform.git - rename directory: mv koha-ill-freeform to FreeForm - edit /etc/koha/sites/kohadev/koha-conf.xml - in the <interlibrary_loans> section change: . backend_directory to: <backend_directory>/kohadevbox/koha/Koha/Illbackends</backend_directory> . partner_code to: <partner_code>IL</partner_code> - flush_memcached and restart_all - enable ILLModule system preference - check that there are no ILL warnings under About > System information - check that you can create a request: ILL requests > New ILL request -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150170|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 150186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150186&action=edit Bug 33599: Use template wrapper for breadcrumbs: Various This patch updates various templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - ILL requests - New ill request - Manage ill request - Bibliographic record -> - Place hold - Place multiple holds - Tools -> - Comments awaiting moderation - Approved comments - Suggestions - New suggestion - View suggestion - Edit suggestion - Lists - Public Lists - Private lists - New list - Edit list - Transfer list - View list contents -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150186|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 150192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150192&action=edit Bug 33599: Use template wrapper for breadcrumbs: Various This patch updates various templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - ILL requests - New ill request - Manage ill request - Bibliographic record -> - Place hold - Place multiple holds - Tools -> - Comments awaiting moderation - Approved comments - Suggestions - New suggestion - View suggestion - Edit suggestion - Lists - Public Lists - Private lists - New list - Edit list - Transfer list - View list contents Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Lucas Gass from comment #6)

-Edit request -Confirm request -Place request with partner libraries -Edit item metadata

These are all handled in the same template, but the existing breadcrumbs (in master) don't cover those cases. This could be addressed in another patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.07 released in| | -- You are receiving this mail because: You are watching all bug changes.