[Bug 13120] New: Invalid HTML generated by MARC21slim2OPACResults.xsl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13120 Bug ID: 13120 Summary: Invalid HTML generated by MARC21slim2OPACResults.xsl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org MARC21slim2OPACResults.xsl, which controls XSLT output of search results in the OPAC, applies a non-unique "id" attribute to each row of results. This is invalid HTML. A class should be used instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13120 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13120 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32560&action=edit Bug 13120 - Invalid HTML generated by MARC21slim2OPACResults.xsl This patch converts an id to a class in order to avoid duplicate id attributes on one page. To test you must have XSLT enabled with the default setting. Perform a search in the OPAC and confirm that the display of location looks correct. Run the resulting page through a validator using an in-browser tool like Firefox's Html Validator addon or using the W3C's validator.w3.org. The results should not complain of duplicate id attributes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13120 --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 32710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32710&action=edit Bug 13120 - Invalid HTML generated by MARC21slim2OPACResults.xsl This patch converts an id to a class in order to avoid duplicate id attributes on one page. To test you must have XSLT enabled with the default setting. Perform a search in the OPAC and confirm that the display of location looks correct. Run the resulting page through a validator using an in-browser tool like Firefox's Html Validator addon or using the W3C's validator.w3.org. The results should not complain of duplicate id attributes. Signed-off-by: Frederic Demians <f.demians@tamil.fr> OK for me. Obvious mistake: I can confirm FF HTML validator reports it, and stop reporting it after applying this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13120 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13120 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32560|0 |1 is obsolete| | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13120 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13120 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32710|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32714&action=edit [PASSED QA] Bug 13120 - Invalid HTML generated by MARC21slim2OPACResults.xsl This patch converts an id to a class in order to avoid duplicate id attributes on one page. To test you must have XSLT enabled with the default setting. Perform a search in the OPAC and confirm that the display of location looks correct. Run the resulting page through a validator using an in-browser tool like Firefox's Html Validator addon or using the W3C's validator.w3.org. The results should not complain of duplicate id attributes. Signed-off-by: Frederic Demians <f.demians@tamil.fr> OK for me. Obvious mistake: I can confirm FF HTML validator reports it, and stop reporting it after applying this patch. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I can confirm this fix is correct. Also, I found that jQuery doesn't like repeated ids in some cases so this will make customizing easier. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13120 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org