http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13128 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13128 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32576&action=edit Bug 13128 - Add span with id for logged in branch name, add hidden span for branchcode It would be nice if there were a simple way to access the name and branchcode of the currently logged in library, as well as the logged in user via JavaScript ( via intranetuserjs ). I propose the following: 1) Remove the whitespace surrounding the loggedinusername span 2) Wrap the logged in branch name with a span that has an id 3) Add the branchcode in a hidden span that has an id Test Plan: 1) Apply this patch 2) Log into Koha 3) Inspect the html source code 4) Note the lack of whitespace within the tag <span class="loggedinusername">[% loggedinusername %]</span> 5) Note the logged in branch name is now surrounded by a span with an id 6) Note below that is a span containing the branchcode, also with an id. 7) Verify the branchcode span is hidden by default. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13128 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32576|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32577&action=edit [SIGNED-OFF] Bug 13128 - Add span with id for logged in branch name, add hidden span for branchcode It would be nice if there were a simple way to access the name and branchcode of the currently logged in library, as well as the logged in user via JavaScript ( via intranetuserjs ). I propose the following: 1) Remove the whitespace surrounding the loggedinusername span 2) Wrap the logged in branch name with a span that has an id 3) Add the branchcode in a hidden span that has an id Test Plan: 1) Apply this patch 2) Log into Koha 3) Inspect the html source code 4) Note the lack of whitespace within the tag <span class="loggedinusername">[% loggedinusername %]</span> 5) Note the logged in branch name is now surrounded by a span with an id 6) Note below that is a span containing the branchcode, also with an id. 7) Verify the branchcode span is hidden by default. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13128 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13128 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.