https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39727 --- Comment #1 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 181413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181413&action=edit Bug 39727: Remove DelSuggestionsOlderThan from C4/Suggestions.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39727 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39728 [Bug 39728] Remove GetUnprocessedSuggestions from C4/Suggestions.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39727 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39727 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181422|0 |1 is obsolete| | --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 193489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193489&action=edit Bug 39727: Remove DelSuggestionsOlderThan from C4/Suggestions.pm To test: Test the cronjob purge_suggestions.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39727 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39729 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39729 [Bug 39729] Add option -exact_days to filter_by_last_update -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39727 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39727 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39727 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39727 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #6 from David Nind <david@davidnind.com> --- The patch no longer applies - getting a sha1/fake ancestor error. Also, test plan required. git bz apply 39727 📋 Bug 39727 depends on bug 39726 (Needs Signoff) Follow? [(y)es, (n)o] y 📋 Bug 39726 - Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm • 193488 - Bug 39726: Remove op connectDuplicate from acqui/newordersuggestions.pl Apply? [(y)es, (n)o, (i)nteractive] y Preparing 1 patch(es): ✓ Prepared 1 patch(es) Applying 1 patch(es): ✓ [1/1] Applied Bug 39726: Remove op connectDuplicate from acqui/newordersuggestions.pl ✓ Successfully applied 1 patch(es) from bug 39726 📋 Bug 39727 - Remove DelSuggestionsOlderThan from C4/Suggestions.pm • 193518 - Bug 39727: Remove DelSuggestionsOlderThan from C4/Suggestions.pm Apply? [(y)es, (n)o, (i)nteractive] y Preparing 1 patch(es): ✓ Prepared 1 patch(es) Applying 1 patch(es): Patch application failed for attachment 193518 - Bug 39727: Remove DelSuggestionsOlderThan from C4/Suggestions.pm Patches left in /tmp/5aun2cddor for manual application if needed To resolve: 1. Fix conflicts (use 'git mergetool' or edit files manually) 2. Stage resolved files with 'git add' 3. Continue with 'git bz apply --continue' or 'git am --continue' 4. Or skip this patch with 'git bz apply --skip' 5. Or abort with 'git bz apply --abort' Error: Apply failed: Git command (git am -3 /tmp/5aun2cddor/0001-193518.patch) failed: error: sha1 information is lacking or useless (C4/Suggestions.pm). error: could not build fake ancestor hint: Use 'git am --show-current-patch=diff' to see the failed patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39727 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193518|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39727 --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Just rebased on main :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39727 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198242|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39727 --- Comment #10 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Add a new suggestion: Acquisitions > Suggestions > New purchase suggestion 2. Change the status to 'Accepted' - Have the list of suggestions - Select the tick box for the suggestion - Change "Mark selected as" to "Accepted" 3. Update the dates in the database (not sure which dates are required): - Access the database: koha-mysql kohadev - Update the suggested date: update suggestions set suggesteddate = "2026-03-01"; - Update the managed date: update suggestions set manageddate = "2026-03-01"; - Update the accepted date: update suggestions set accepteddate = "2026-03-01"; 4. Run the purge suggestions cron job: - misc/cronjobs/purge_suggestions.pl -verbose -confirm -days 30 5. There should be no suggestions: - Staff interface: for suggestions for "Any" - Database: . Access the database: koha-mysql kohadev . SQL: select * from suggestions; 6. Apply the patch. 7. Repeat steps 1 to 5 - should all work the same. 8. I didn't test with PurgeSuggestionsOlderThan system preference. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39727 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198331|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39727 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39727 Bug 39727 depends on bug 39726, which changed state. Bug 39726 Summary: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.