[Bug 39726] New: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 Bug ID: 39726 Summary: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 --- Comment #1 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 181407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181407&action=edit Bug 39726: Remove op connectDuplicate from acqui/newordersuggestions.pl 15:27:09> git grep connectDuplicate acqui/newordersuggestion.pl: * connectDuplicate : acqui/newordersuggestion.pl:if ( $op eq 'connectDuplicate' ) { connectDuplicate is never called from any template code is hence removed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 --- Comment #2 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 181408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181408&action=edit Bug 39726: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39725 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39725 [Bug 39725] Remove GetSuggestionByStatus from C4/Suggestions.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39727 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39727 [Bug 39727] Remove DelSuggestionsOlderThan from C4/Suggestions.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181408|0 |1 is obsolete| | --- Comment #3 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 181421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181421&action=edit Bug 39726: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm To test: Create a suggestion whose isbn fits an existing one (note: you must have a working search engine) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |roman.dolny@jezuici.pl --- Comment #4 from Roman Dolny <roman.dolny@jezuici.pl> --- kohadev-koha@kohadevbox:koha(bug_39726)$ git bz apply 39726 Bug 39726 - Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm 181407 - Bug 39726: Remove op connectDuplicate from acqui/newordersuggestions.pl 181421 - Bug 39726: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 39726: Remove op connectDuplicate from acqui/newordersuggestions.pl Applying: Bug 39726: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm error: sha1 information is lacking or useless (C4/Suggestions.pm). error: could not build fake ancestor Patch failed at 0001 Bug 39726: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181407|0 |1 is obsolete| | --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 193488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193488&action=edit Bug 39726: Remove op connectDuplicate from acqui/newordersuggestions.pl ConnectDuplicate does not appear to be used anywhere. No test plan to provide here. git grep connectDuplicate should return nothing Since there is no cud-, it would at least have been broken for a year -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181421|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |roadmap_26_05 CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193488|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 --- Comment #6 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 198241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198241&action=edit Bug 39726: Remove op connectDuplicate from acqui/newordersuggestions.pl ConnectDuplicate does not appear to be used anywhere. No test plan to provide here. git grep connectDuplicate should return nothing Since there is no cud-, it would at least have been broken for a year -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198241|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 198330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198330&action=edit Bug 39726: Remove op connectDuplicate from acqui/newordersuggestions.pl ConnectDuplicate does not appear to be used anywhere. No test plan to provide here. git grep connectDuplicate should return nothing Since there is no cud-, it would at least have been broken for a year Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Before the patch: git grep connectDuplicate acqui/newordersuggestion.pl: * connectDuplicate : acqui/newordersuggestion.pl:if ( $op eq 'connectDuplicate' ) { 2. After the patch - no occurrences. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198330|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198747&action=edit Bug 39726: Remove op connectDuplicate from acqui/newordersuggestions.pl ConnectDuplicate does not appear to be used anywhere. No test plan to provide here. git grep connectDuplicate should return nothing Since there is no cud-, it would at least have been broken for a year Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 --- Comment #10 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Keywords|roadmap_26_05 | CC| |lucas@bywatersolutions.com Status|Pushed to main |RESOLVED --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Declining a 26.05.x backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39726 Bug 39726 depends on bug 39725, which changed state. Bug 39725 Summary: Remove GetSuggestionByStatus from C4/Suggestions.pm https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39725 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org