https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29131 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29131 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125735&action=edit Bug 29131: Row striping breaks color coding on item circulation alerts The CSS we use for table row "striping," which uses 'tbody tr:nth-child(odd),' is often difficult to work with because it takes a lot of increased specificity to override the default. Bootstrap compounds this by adding its own similar CSS. In order to overcome this I've added '!important' to the CSS embedded in the item circulation alerts page. I normally would avoid '!important' but since this CSS is only relevant to this page I think it's appropriate. This patch also adds [% FILTER collapse %] around the <style> block and does some reindenting, so ignore whitespace when using diff to see the changes clearly. To test, apply the patch and go to Administration -> Item circulation alerts. - Check the "Legend" table. The first cells should be distinct colors: red, pink, and green. - In the "Checkout" table, table cells should be green by default. Clicking in one of the cells should turn it red with the text "Disabled for all." - Use the "Select a library" dropdown to pick a library. - Clicking in any green cell should turn the cell pink and add the text "Disabled for XXX" where XXX is the branchcode. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29131 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125735|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 125757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125757&action=edit Bug 29131: Row striping breaks color coding on item circulation alerts The CSS we use for table row "striping," which uses 'tbody tr:nth-child(odd),' is often difficult to work with because it takes a lot of increased specificity to override the default. Bootstrap compounds this by adding its own similar CSS. In order to overcome this I've added '!important' to the CSS embedded in the item circulation alerts page. I normally would avoid '!important' but since this CSS is only relevant to this page I think it's appropriate. This patch also adds [% FILTER collapse %] around the <style> block and does some reindenting, so ignore whitespace when using diff to see the changes clearly. To test, apply the patch and go to Administration -> Item circulation alerts. - Check the "Legend" table. The first cells should be distinct colors: red, pink, and green. - In the "Checkout" table, table cells should be green by default. Clicking in one of the cells should turn it red with the text "Disabled for all." - Use the "Select a library" dropdown to pick a library. - Clicking in any green cell should turn the cell pink and add the text "Disabled for XXX" where XXX is the branchcode. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29131 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125757|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 125766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125766&action=edit Bug 29131: Row striping breaks color coding on item circulation alerts The CSS we use for table row "striping," which uses 'tbody tr:nth-child(odd),' is often difficult to work with because it takes a lot of increased specificity to override the default. Bootstrap compounds this by adding its own similar CSS. In order to overcome this I've added '!important' to the CSS embedded in the item circulation alerts page. I normally would avoid '!important' but since this CSS is only relevant to this page I think it's appropriate. This patch also adds [% FILTER collapse %] around the <style> block and does some reindenting, so ignore whitespace when using diff to see the changes clearly. To test, apply the patch and go to Administration -> Item circulation alerts. - Check the "Legend" table. The first cells should be distinct colors: red, pink, and green. - In the "Checkout" table, table cells should be green by default. Clicking in one of the cells should turn it red with the text "Disabled for all." - Use the "Select a library" dropdown to pick a library. - Clicking in any green cell should turn the cell pink and add the text "Disabled for XXX" where XXX is the branchcode. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29131 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29131 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29131 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.