[Bug 13991] New: Uninitialized value $src in /tools/viewlog.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991 Bug ID: 13991 Summary: Uninitialized value $src in /tools/viewlog.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To reproduce: Go to Home > Tools > Logs Check intranet-error.log. You will find a line similar to: viewlog.pl: Use of uninitialized value $src in string eq at (...)/tools/viewlog.pl line 70., referer: http://(...)/cgi-bin/koha/tools/tools-home.pl Reason: Line 57 my $src = $input->param("src"); Param is not always defined. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 37791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37791&action=edit Bug 13991 - Uninitialized value $src in /tools/viewlog.pl To reproduce: Go to Home > Tools > Logs Check intranet-error.log. You will find a line similar to: viewlog.pl: Use of uninitialized value $src in string eq at (...)/tools/viewlog.pl line 70., referer: http://(...)/cgi-bin/koha/tools/tools-home.pl To test: Apply patch. Verify that no more warnings appear in intranet-error.log Verify that the log viewer behaves as before. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991 Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991 Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37791|0 |1 is obsolete| | --- Comment #2 from Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> --- Created attachment 37802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37802&action=edit Bug 13991 - Uninitialized value $src in /tools/viewlog.pl To reproduce: Go to Home > Tools > Logs Check intranet-error.log. You will find a line similar to: viewlog.pl: Use of uninitialized value $src in string eq at (...)/tools/viewlog.pl line 70., referer: http://(...)/cgi-bin/koha/tools/tools-home.pl To test: Apply patch. Verify that no more warnings appear in intranet-error.log Verify that the log viewer behaves as before. Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37802|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 37922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37922&action=edit [PASSED QA] Bug 13991 - Uninitialized value $src in /tools/viewlog.pl To reproduce: Go to Home > Tools > Logs Check intranet-error.log. You will find a line similar to: viewlog.pl: Use of uninitialized value $src in string eq at (...)/tools/viewlog.pl line 70., referer: http://(...)/cgi-bin/koha/tools/tools-home.pl To test: Apply patch. Verify that no more warnings appear in intranet-error.log Verify that the log viewer behaves as before. Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 37980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37980&action=edit Bug 13991: (QA followup) uninitialized value and [0] in /tools/viewlog.pl Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org