[Bug 13947] New: serials/subscription-history.pl calls GetBiblio incorrectly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 Bug ID: 13947 Summary: serials/subscription-history.pl calls GetBiblio incorrectly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com While looking at bug 10906, I noticed that this bug existed as well, but it was not reported. Look at C4/Biblio.pm and find the GetBiblio function. It is obvious that it only returns undef or a HASH reference. However, serials/subscription-history.pl calls it expecting ($count, $biblio), which is wrong. 1) confirm the problem: $ git grep "=\s*GetBiblio\s*(" | grep subscription-history 2) apply the patch 3) confirm the fix: $ git grep "=\s*GetBiblio\s*(" | grep subscription-history -- The return value should be just a single parameter as expected. 4) run koha-qa test tools. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37443&action=edit Bug 13947: Correct call to GetBiblio to receive correct return value When you attempt to edit the manual history for a subscription, the title is blank. This is a result of an incorrect use of the GetBiblio function. TEST PLAN --------- 1) Log in to staff client 2) Serials 3) Search for an existing serial with manual history checked. -- creating one as needed is left as an exercise to the reader. 4) Click on the title of the serial for the details page. 5) Go to the Planning tab and click 'Edit History' -- Heading will be 'Subscription history for' without a title. 6) Apply patch 7) Refresh page. -- Heading will include the title correctly. 8) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10906 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 Jacek Ablewicz <ablewicz@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 Jacek Ablewicz <ablewicz@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37443|0 |1 is obsolete| | --- Comment #2 from Jacek Ablewicz <ablewicz@gmail.com> --- Created attachment 37447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37447&action=edit Bug 13947: Correct call to GetBiblio to receive correct return value When you attempt to edit the manual history for a subscription, the title is blank. This is a result of an incorrect use of the GetBiblio function. TEST PLAN --------- 1) Log in to staff client 2) Serials 3) Search for an existing serial with manual history checked. -- creating one as needed is left as an exercise to the reader. 4) Click on the title of the serial for the details page. 5) Go to the Planning tab and click 'Edit History' -- Heading will be 'Subscription history for' without a title. 6) Apply patch 7) Refresh page. -- Heading will include the title correctly. 8) run koha qa test tools Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mtompset@hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37447|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37461&action=edit [PASSED QA] Bug 13947: Correct call to GetBiblio to receive correct return value When you attempt to edit the manual history for a subscription, the title is blank. This is a result of an incorrect use of the GetBiblio function. TEST PLAN --------- 1) Log in to staff client 2) Serials 3) Search for an existing serial with manual history checked. -- creating one as needed is left as an exercise to the reader. 4) Click on the title of the serial for the details page. 5) Go to the Planning tab and click 'Edit History' -- Heading will be 'Subscription history for' without a title. 6) Apply patch 7) Refresh page. -- Heading will include the title correctly. 8) run koha qa test tools Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org