[Bug 39299] New: cn_browser on 952$o fails to open from item editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39299 Bug ID: 39299 Summary: cn_browser on 952$o fails to open from item editor Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Since bug 30975 if you set the cn_browser plugin for 952$o it fails to open in the item editor. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39299 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30975 Severity|enhancement |major Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39299 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 179146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179146&action=edit Bug 39299: Fix cataloguing plugins in item editor Some CSS classes were missing, causing the corresponding event listener to not be called Test plan: 1. Set 'cn_browser.pl' as a plugin for one of the item subfields (e.g. 952$o) 2. Go to the cataloguing module and edit an existing item 3. Click on the tag editor button, the cn_browser.pl popup should appear -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39299 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 179147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179147&action=edit Bug 39299: Fix cataloguing plugins in serial item editor Some CSS classes were missing, causing the corresponding event listener to not be called. Adding the missing CSS classes caused the tag editor button to be moved to the left of the input, because of 'float: left' for .tag_editor It seems that float:left is useless now, at least in cataloguing where we use 'display: flex' for those elements, so this patch removes it. Test plan: 1. Set 'cn_browser.pl' as a plugin for one of the item subfields (e.g. 952$o) 2. Go to the serial edition page and click on "Add item". This should show an item form 3. Click on the tag editor button, the cn_browser.pl popup should appear -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39299 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |julian.maurice@biblibre.com |ity.org | CC| |julian.maurice@biblibre.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39299 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39299 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179146|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179152&action=edit Bug 39299: Fix cataloguing plugins in item editor Some CSS classes were missing, causing the corresponding event listener to not be called Test plan: 1. Set 'cn_browser.pl' as a plugin for one of the item subfields (e.g. 952$o) 2. Go to the cataloguing module and edit an existing item 3. Click on the tag editor button, the cn_browser.pl popup should appear Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39299 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179147|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179153&action=edit Bug 39299: Fix cataloguing plugins in serial item editor Some CSS classes were missing, causing the corresponding event listener to not be called. Adding the missing CSS classes caused the tag editor button to be moved to the left of the input, because of 'float: left' for .tag_editor It seems that float:left is useless now, at least in cataloguing where we use 'display: flex' for those elements, so this patch removes it. Test plan: 1. Set 'cn_browser.pl' as a plugin for one of the item subfields (e.g. 952$o) 2. Go to the serial edition page and click on "Add item". This should show an item form 3. Click on the tag editor button, the cn_browser.pl popup should appear Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39299 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179154&action=edit Bug 39299: (follow-up) Consistent styling for authorities finder Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39299 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39299 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Clear correction, no regressions found and QA script happy.. going for a straight QA here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39299 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39299 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39299 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Removed the additional space between words here: title="No popup" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39299 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39299 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39299 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39299 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39299 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 30975 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39299 Bug 39299 depends on bug 30975, which changed state. Bug 30975 Summary: Use event delegation for framework plugins to avoid using private jQuery method _data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org