[Bug 41835] New: Add item forms Tag editor buttons on serial edition page are misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41835 Bug ID: 41835 Summary: Add item forms Tag editor buttons on serial edition page are misaligned Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: emmi.takkinen@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org Created attachment 193003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193003&action=edit Wonky tag editor buttons To reproduce: 1. Make sure MARC framework for serials uses plugins in some 952 fields (e.g. dateaccessioned.pl plugin in field 952$d). 2. Find an active serial subscription and receive items for it. 3. Open Add item form. -> Note that Tag editor buttons aren't displayed inline with input fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41835 --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- It seems that css rule "display: block" for tag_editor behaves badly for serial Add item form. Removing it however breaks the buttons layout. And interestingly in biblios Add item form layout is displayed correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41835 --- Comment #2 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- I found the solution for this. In item modification, which has same structure, div element where Tag editor buttons are nested has class "subfield_line". And parent of this div element has class "item_edit_form". In addbiblio.css there is a rule: .item_edit_form .subfield_line { align-items: flex-start; display: flex; flex-basis: 100%; align-items: center; } We need to add same rule to serials-edit.pl to get Tag editor buttons to be inline with other elements of the div. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41835 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |emmi.takkinen@koha-suomi.fi Status|NEW |Needs Signoff --- Comment #3 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 193717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193717&action=edit Bug 41835: Add CSS file for serial edits page Add item forms Tag editor buttons on serial edits page were misaligned with their respective input fields. This happens because there is no rule for their parent div to display its children elements correctly. This patch adds this rule for serial edits page in new serial-edits.css file. To test: 1. Make sure MARC framework for serials uses plugins in some 952 fields (e.g. dateaccessioned.pl plugin in field 952$d). 2. Find an active serial subscription and receive items for it. 3. Open Add item form. -> Note that Tag editor buttons aren't displayed inline with input fields. 4. Apply this patch, restart services if needed. 5. Refresh page. -> Note that Tag editor buttons are now displayed inline with input fields. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41835 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41835 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193717|0 |1 is obsolete| | --- Comment #4 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 193718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193718&action=edit Bug 41835: Add CSS file for serial edits page Add item forms Tag editor buttons on serial edits page were misaligned with their respective input fields. This happens because there is no rule for their parent div to display its children elements correctly. This patch adds this rule for serial edits page in new serial-edits.css file. To test: 1. Make sure MARC framework for serials uses plugins in some 952 fields (e.g. dateaccessioned.pl plugin in field 952$d). 2. Find an active serial subscription and receive items for it. 3. Open Add item form. -> Note that Tag editor buttons aren't displayed inline with input fields. 4. Apply this patch, restart services if needed. 5. Refresh page. -> Note that Tag editor buttons are now displayed inline with input fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41835 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41835 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193718|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 193856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193856&action=edit Bug 41835: Add CSS file for serial edits page Add item forms Tag editor buttons on serial edits page were misaligned with their respective input fields. This happens because there is no rule for their parent div to display its children elements correctly. This patch adds this rule for serial edits page in new serial-edits.css file. To test: 1. Make sure MARC framework for serials uses plugins in some 952 fields (e.g. dateaccessioned.pl plugin in field 952$d). 2. Find an active serial subscription and receive items for it. 3. Open Add item form. -> Note that Tag editor buttons aren't displayed inline with input fields. 4. Apply this patch, restart services if needed. 5. Refresh page. -> Note that Tag editor buttons are now displayed inline with input fields. Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41835 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 193857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193857&action=edit Bug 41835: (follow-up) Clean up CSS There are some aspects of .subfield_line in addbiblio.css which are incorrect or redundant. This follow-up removes those lines from addbiblio.css and from the copied CSS in serials-edit.css -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41835 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41835 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193856|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41835 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193857|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41835 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 197060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197060&action=edit Bug 41835: Add CSS file for serial edits page Add item forms Tag editor buttons on serial edits page were misaligned with their respective input fields. This happens because there is no rule for their parent div to display its children elements correctly. This patch adds this rule for serial edits page in new serial-edits.css file. To test: 1. Make sure MARC framework for serials uses plugins in some 952 fields (e.g. dateaccessioned.pl plugin in field 952$d). 2. Find an active serial subscription and receive items for it. 3. Open Add item form. -> Note that Tag editor buttons aren't displayed inline with input fields. 4. Apply this patch, restart services if needed. 5. Refresh page. -> Note that Tag editor buttons are now displayed inline with input fields. Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41835 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 197061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197061&action=edit Bug 41835: (follow-up) Clean up CSS There are some aspects of .subfield_line in addbiblio.css which are incorrect or redundant. This follow-up removes those lines from addbiblio.css and from the copied CSS in serials-edit.css Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41835 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41835 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41835 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41835 --- Comment #10 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41835 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 25.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41835 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39299 CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Looks like this is since Bug 39299 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39299 [Bug 39299] cn_browser on 952$o fails to open from item editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41835 --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Shouldn't we move in-page style to the CSS file ? https://git.koha-community.org/Koha-community/Koha/src/branch/main/koha-tmpl... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org