[Bug 11007] New: Useless column cancelledby in aqorders table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11007 Bug ID: 11007 Summary: Useless column cancelledby in aqorders table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: gmcharlt@gmail.com Reporter: mathieu.saby@univ-rennes2.fr QA Contact: testopia@bugs.koha-community.org In Schemaspy, column cancelledby is reported as "not used? always NULL". "grep -r cancelledby *" give this result, so I suppose it is true : blib/INTRANET_CGI_DIR/installer/data/mysql/kohastructure.sql: `cancelledby` varchar(10) default NULL, -- not used? always NULL blib/INTRANET_CGI_DIR/installer/data/Pg/kohastructure.sql:cancelledby varchar(10) default NULL, installer/data/mysql/kohastructure.sql: `cancelledby` varchar(10) default NULL, -- not used? always NULL installer/data/Pg/kohastructure.sql:cancelledby varchar(10) default NULL, t/db_dependent/Acquisition.t: cancelledby I propose the deletion of this column. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11007 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11007 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29821&action=edit Bug 11007: Drop column aqorders.cancelledby It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep cancelledby should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11007 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11008 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11007 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11007 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29821|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29823&action=edit Bug 11007: Drop column aqorders.cancelledby It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep cancelledby should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11007 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #2)
3/ prove t/db_dependent/Acquisition.t should return green.
Does that test return green for you in master? It doesn't for me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11007 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Owen Leonard from comment #3)
(In reply to Jonathan Druart from comment #2)
3/ prove t/db_dependent/Acquisition.t should return green.
Does that test return green for you in master? It doesn't for me.
Yes, what is the error you get? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11007 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11007 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29823|0 |1 is obsolete| | --- Comment #5 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 30958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30958&action=edit [SIGNED-OFF] Bug 11007: Drop column aqorders.cancelledby It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep cancelledby should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11007 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11007 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30958|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 31038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31038&action=edit [PASSED QA] Bug 11007: Drop column aqorders.cancelledby It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep cancelledby should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I couldn't find any trace of this column being used. Passes tests and QA script, updates all necessary files. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11007 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org