https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38347 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38347 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 173928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173928&action=edit Bug 38347: Fix style of sidebar form submit button on bookings to collect page This patch fixes the markup of the sidebar form on the bookings to collect page, and adds the correct "btn btn-primary" class to the submit button. To test, apply the patch and go to Circulation -> Bookings to collect. In the sidebar form, confirm that the submit button has the same yellow "primary" style as other submit buttons, and that it fills the width of the sidebar. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38347 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- The patch no longer applies 8-(... git bz apply 38347 Bug 38347 - Fix style of sidebar form submit button on bookings to collect page 173928 - Bug 38347: Fix style of sidebar form submit button on bookings to collect page Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 38347: Fix style of sidebar form submit button on bookings to collect page Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 38347: Fix style of sidebar form submit button on bookings to collect page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38347 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173928|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175053&action=edit Bug 38347: Fix style of sidebar form submit button on bookings to collect page This patch fixes the markup of the sidebar form on the bookings to collect page, and adds the correct "btn btn-primary" class to the submit button. NOTE: This patch contains indentation changes, so please ignore whitespace when viewing the diff. To test, apply the patch and go to Circulation -> Bookings to collect. In the sidebar form, confirm that the submit button has the same yellow "primary" style as other submit buttons, and that it fills the width of the sidebar. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38347 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175053|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 175063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175063&action=edit Bug 38347: Fix style of sidebar form submit button on bookings to collect page This patch fixes the markup of the sidebar form on the bookings to collect page, and adds the correct "btn btn-primary" class to the submit button. NOTE: This patch contains indentation changes, so please ignore whitespace when viewing the diff. To test, apply the patch and go to Circulation -> Bookings to collect. In the sidebar form, confirm that the submit button has the same yellow "primary" style as other submit buttons, and that it fills the width of the sidebar. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38347 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38347 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the style for release notes| |the submit button on the | |bookings to collect page | |(Circulation > Bookings to | |collect). It now has the | |same yellow "primary" style | |as other submit buttons, | |and it fills the width of | |the sidebar. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38347 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38347 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- This was pushed for 24.11.02 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38347 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38347 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.