[Bug 35434] New: Non-superlibrarians should not place holds in other libraries when IndependentBranches is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Bug ID: 35434 Summary: Non-superlibrarians should not place holds in other libraries when IndependentBranches is enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: emily-rose.francoeur@inLibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In the intranet, when the system preference IndependentBranches is enabled, non-superlibrarians can make reservations in other libraries, which they shouldn't be able to do. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Emily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emily-rose.francoeur@inLibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 --- Comment #1 from Emily-Rose Francoeur <emily-rose.francoeur@inLibro.com> --- Created attachment 159346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159346&action=edit Bug 35434: IndependentBranches prevents non-superlibrarians from placing holds in other libraries I updated the hold page on the staff interface so that non-superlibrarians can't place holds in other libraries when the system preference 'IndependentBranches' is enabled. TEST PLAN 1) Appy the patch. 2) In 'Koha administration > System preferences', set 'IndependentBranches' to 'yes'. 3) In 'Koha administration > Circulation and fines rules', add a rule by only clicking the 'Save' button (this will create a circulation rule for all patron categories and all item types, allowing unlimited holds). 4) Create a staff patron (with username and password). ---> In 'Patrons > + New patron > Staff', fill the required fields, add a username and password. ---> Remember the home library. ---> Click the 'Save' button. 5) Add permissions to the created patron. ---> In the patron detail page, click on 'More > Set permissions' and check the following boxes: - Staff access, allows viewing of catalogue in staff interface - Add, modify and view patron information - Place and modify holds for patrons ---> Click the 'Save' button. 6) Create an other patron of any patron category with the same home library as the staff patron you created. 7) Create a record with one item. ---> In 'Cataloging > + New record', fill the required fields. ---> Click the 'Save' button. ---> You should now be in the item form. Fill the required field (home library and current library should be the same as the patron's home library). ---> Click the 'Add item' button. 8) On the record details page, click 'Place hold' and search for the patron you created in step 6. ---> In the 'Pickup at' field, you should see all the libraries. ---> In the 'Allowed pickup locations' column of the item, you should see the same. 9) Log out from the staff interface and login with the staff patron you created. 10) Click 'Search catalog' from the search bar and search for the record you created. 11) On the record details page, click 'Place hold', then search for the patron in step 6. ---> In the 'Pickup at' field, you should only see the home library of the item. ---> In the 'Allowed pickup locations' column of the item, you should see the same. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Emily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |emily-rose.francoeur@inLibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Emily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Emily, can we have a unit test for this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- IIRC canreservefromotherbranches was also used in this context, but it seems missing from the test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159346|0 |1 is obsolete| | --- Comment #4 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 161509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161509&action=edit Bug 35434: IndependentBranches prevents non-superlibrarians from placing holds in other libraries I updated the hold page on the staff interface so that non-superlibrarians can't place holds in other libraries when the system preference 'IndependentBranches' is enabled. TEST PLAN 1) Appy the patch. 2) In 'Koha administration > System preferences', set 'IndependentBranches' to 'yes'. 3) In 'Koha administration > Circulation and fines rules', add a rule by only clicking the 'Save' button (this will create a circulation rule for all patron categories and all item types, allowing unlimited holds). 4) Create a staff patron (with username and password). ---> In 'Patrons > + New patron > Staff', fill the required fields, add a username and password. ---> Remember the home library. ---> Click the 'Save' button. 5) Add permissions to the created patron. ---> In the patron detail page, click on 'More > Set permissions' and check the following boxes: - Staff access, allows viewing of catalogue in staff interface - Add, modify and view patron information - Place and modify holds for patrons ---> Click the 'Save' button. 6) Create an other patron of any patron category with the same home library as the staff patron you created. 7) Create a record with one item. ---> In 'Cataloging > + New record', fill the required fields. ---> Click the 'Save' button. ---> You should now be in the item form. Fill the required field (home library and current library should be the same as the patron's home library). ---> Click the 'Add item' button. 8) On the record details page, click 'Place hold' and search for the patron you created in step 6. ---> In the 'Pickup at' field, you should see all the libraries. ---> In the 'Allowed pickup locations' column of the item, you should see the same. 9) Log out from the staff interface and login with the staff patron you created. 10) Click 'Search catalog' from the search bar and search for the record you created. 11) On the record details page, click 'Place hold', then search for the patron in step 6. ---> In the 'Pickup at' field, you should only see the home library of the item. ---> In the 'Allowed pickup locations' column of the item, you should see the same. Signed-off-by: Anni Rajala <anni.rajala@turku.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Anni Rajala <anni.rajala@turku.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |anni.rajala@turku.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #3)
IIRC canreservefromotherbranches was also used in this context, but it seems missing from the test plan.
Can you please reply/comment? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 --- Comment #6 from Blou <philippe.blouin@inlibro.com> --- Emily Rose is back at school. I'll assign this issue to another dev, they should be able to answer you shortly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Phan Tung Bui <phan-tung.bui@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phan-tung.bui@inlibro.com --- Comment #8 from Phan Tung Bui <phan-tung.bui@inlibro.com> --- Here comes the updated version of plan test : TEST PLAN 1) Appy the patch. 2) In 'Koha administration > System preferences' : - set 'IndependentBranches' to 'yes' - set 'IndependentBranchesPatronModifications' to 'yes' - set 'IndependentBranchesTransfers' to 'yes' - set 'canreservefromotherbranches' to 'Don't allow' 3) In 'Koha administration > Circulation and fines rules', add a rule by only clicking the 'Save' button (this will create a circulation rule for all patron categories and all item types, allowing unlimited holds). 4) Create a staff patron (with username and password). ---> In 'Patrons > + New patron > Staff', fill the required fields, add a username and password. ---> Remember the home library. ---> Click the 'Save' button. 5) Add permissions to the created patron. ---> In the patron detail page, click on 'More > Set permissions' and check the following boxes: - Staff access, allows viewing of catalogue in staff interface - Add, modify and view patron information - Place and modify holds for patrons ---> Click the 'Save' button. 6) Create an other patron of any patron category with the same home library as the staff patron you created. 7) Create a record with one item. ---> In 'Cataloging > + New record', fill the required fields. ---> Click the 'Save' button. ---> You should now be in the item form. Fill the required field (home library and current library should be the same as the patron's home library). ---> Click the 'Add item' button. 8) On the record details page, click 'Place hold' and search for the patron you created in step 6. ---> In the 'Pickup at' field, you should see all the libraries. ---> In the 'Allowed pickup locations' column of the item, you should see the same. 9) Log out from the staff interface and login with the staff patron you created. 10) Click 'Search catalog' from the search bar and search for the record you created. 11) On the record details page, click 'Place hold', then search for the patron in step 6. ---> In the 'Pickup at' field, you should only see the home library of the item. ---> In the 'Allowed pickup locations' column of the item, you should see the same. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Phan Tung Bui <phan-tung.bui@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Baptiste <baptiste.bayche@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Baptiste <baptiste.bayche@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161509|0 |1 is obsolete| | --- Comment #9 from Baptiste <baptiste.bayche@inlibro.com> --- Created attachment 166648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166648&action=edit Bug 35434: IndependentBranches prevents non-superlibrarians from placing holds in other libraries I updated the hold page on the staff interface so that non-superlibrarians can't place holds in other libraries when the system preference 'IndependentBranches' is enabled. TEST PLAN 1) Appy the patch. 2) In 'Koha administration > System preferences', set 'IndependentBranches' to 'yes'. 3) In 'Koha administration > Circulation and fines rules', add a rule by only clicking the 'Save' button (this will create a circulation rule for all patron categories and all item types, allowing unlimited holds). 4) Create a staff patron (with username and password). ---> In 'Patrons > + New patron > Staff', fill the required fields, add a username and password. ---> Remember the home library. ---> Click the 'Save' button. 5) Add permissions to the created patron. ---> In the patron detail page, click on 'More > Set permissions' and check the following boxes: - Staff access, allows viewing of catalogue in staff interface - Add, modify and view patron information - Place and modify holds for patrons ---> Click the 'Save' button. 6) Create an other patron of any patron category with the same home library as the staff patron you created. 7) Create a record with one item. ---> In 'Cataloging > + New record', fill the required fields. ---> Click the 'Save' button. ---> You should now be in the item form. Fill the required field (home library and current library should be the same as the patron's home library). ---> Click the 'Add item' button. 8) On the record details page, click 'Place hold' and search for the patron you created in step 6. ---> In the 'Pickup at' field, you should see all the libraries. ---> In the 'Allowed pickup locations' column of the item, you should see the same. 9) Log out from the staff interface and login with the staff patron you created. 10) Click 'Search catalog' from the search bar and search for the record you created. 11) On the record details page, click 'Place hold', then search for the patron in step 6. ---> In the 'Pickup at' field, you should only see the home library of the item. ---> In the 'Allowed pickup locations' column of the item, you should see the same. Signed-off-by: Anni Rajala <anni.rajala@turku.fi> Signed-off-by: baptiste <baptiste.bayche@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #10 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Can we get a unit test for this change? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166648|0 |1 is obsolete| | --- Comment #11 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 169917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169917&action=edit Bug 35434: IndependentBranches prevents non-superlibrarians from placing holds in other libraries I updated the hold page on the staff interface so that non-superlibrarians can't place holds in other libraries when the system preference 'IndependentBranches' is enabled. TEST PLAN 1) Appy the patch. 2) In 'Koha administration > System preferences', set 'IndependentBranches' to 'yes'. 3) In 'Koha administration > Circulation and fines rules', add a rule by only clicking the 'Save' button (this will create a circulation rule for all patron categories and all item types, allowing unlimited holds). 4) Create a staff patron (with username and password). ---> In 'Patrons > + New patron > Staff', fill the required fields, add a username and password. ---> Remember the home library. ---> Click the 'Save' button. 5) Add permissions to the created patron. ---> In the patron detail page, click on 'More > Set permissions' and check the following boxes: - Staff access, allows viewing of catalogue in staff interface - Add, modify and view patron information - Place and modify holds for patrons ---> Click the 'Save' button. 6) Create an other patron of any patron category with the same home library as the staff patron you created. 7) Create a record with one item. ---> In 'Cataloging > + New record', fill the required fields. ---> Click the 'Save' button. ---> You should now be in the item form. Fill the required field (home library and current library should be the same as the patron's home library). ---> Click the 'Add item' button. 8) On the record details page, click 'Place hold' and search for the patron you created in step 6. ---> In the 'Pickup at' field, you should see all the libraries. ---> In the 'Allowed pickup locations' column of the item, you should see the same. 9) Log out from the staff interface and login with the staff patron you created. 10) Click 'Search catalog' from the search bar and search for the record you created. 11) On the record details page, click 'Place hold', then search for the patron in step 6. ---> In the 'Pickup at' field, you should only see the home library of the item. ---> In the 'Allowed pickup locations' column of the item, you should see the same. Signed-off-by: Anni Rajala <anni.rajala@turku.fi> Signed-off-by: baptiste <baptiste.bayche@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 --- Comment #12 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 169918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169918&action=edit Bug 35434: (follow-up) added canreservefromotherbranches in addition to canreservefromotherbranches to prevent non-superlibrarians from placing holds in other libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 --- Comment #13 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 169919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169919&action=edit Bug 35434: (follow-up) Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hammat.wele@inlibro.com Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Laurence Rault <laurence.rault@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laurence.rault@biblibre.com Status|Needs Signoff |Failed QA --- Comment #14 from Laurence Rault <laurence.rault@biblibre.com> --- Step 11 of the plan test fails : 11) On the record details page, click 'Place hold', then search for the patron in step 6. ---> In the 'Pickup at' field, you should only see the home library of the item. ---> In the 'Allowed pickup locations' column of the item, you should see the same. KO : For the librarians having limited permissions, all libraries are still in the pickup location dropdown menu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Olivier Vezina <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ovezina@inlibro.com --- Comment #15 from Olivier Vezina <ovezina@inlibro.com> --- After looking at the code, it seems the testing plans was missing some info. When you go and set IndependentBranches to true, you also need to set canreservefromotherbranches to don't allow. It worked for me when i added this setting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Olivier Vezina <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #16 from Olivier Vezina <ovezina@inlibro.com> --- TEST PLAN 1) Appy the patch. 2) In 'Koha administration > System preferences', set 'IndependentBranches' to 'yes' And 'canreservefromotherbranches' to 'Don't allow'. 3) In 'Koha administration > Circulation and fines rules', add a rule by only clicking the 'Save' button (this will create a circulation rule for all patron categories and all item types, allowing unlimited holds). 4) Create a staff patron (with username and password). ---> In 'Patrons > + New patron > Staff', fill the required fields, add a username and password. ---> Remember the home library. ---> Click the 'Save' button. 5) Add permissions to the created patron. ---> In the patron detail page, click on 'More > Set permissions' and check the following boxes: - Staff access, allows viewing of catalogue in staff interface - Add, modify and view patron information - Place and modify holds for patrons ---> Click the 'Save' button. 6) Create an other patron of any patron category with the same home library as the staff patron you created. 7) Create a record with one item. ---> In 'Cataloging > + New record', fill the required fields. ---> Click the 'Save' button. ---> You should now be in the item form. Fill the required field (home library and current library should be the same as the patron's home library). ---> Click the 'Add item' button. 8) On the record details page, click 'Place hold' and search for the patron you created in step 6. ---> In the 'Pickup at' field, you should see all the libraries. ---> In the 'Allowed pickup locations' column of the item, you should see the same. 9) Log out from the staff interface and login with the staff patron you created. 10) Click 'Search catalog' from the search bar and search for the record you created. 11) On the record details page, click 'Place hold', then search for the patron in step 6. ---> In the 'Pickup at' field, you should only see the home library of the item. ---> In the 'Allowed pickup locations' column of the item, you should see the same. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 --- Comment #17 from Olivier Vezina <ovezina@inlibro.com> --- Feel free to change it back to failed qa if there anything else missing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 --- Comment #18 from David Nind <david@davidnind.com> --- Created attachment 176045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176045&action=edit Bug 35434: Prevent non-superlibrarians from placing holds in other libraries when using IndependentBranches When IndependentBranches is enabled and canreservefromotherbranches is set to don't allow, then non-superlibrarians should not be able to place holds for other libraries. Test plan: 1. Appy the patch. 2. In Koha administration > System preferences, set: - IndependentBranches: Yes - canreservefromotherbranches: Don't allow 3. In Koha administration > Circulation and fines rules, check that you have a rule for all patron categories and all item types, with unlimited holds. 4. Find (or create) a staff patron for a library other than Centerville: - Change the username and password so you can log in as the staff patron. - Add permissions to the staff patron (More > Set permissions): . Staff access, allows viewing of catalogue in staff interface . Add, modify and view patron information . Place and modify holds for patrons 5. Find (or create) a patron with the same home library as the staff patron in step 4. 6. Find (or create) a record with an item where the home and current library are the same as the staff patron in step 3 and the patron in step 5. 7. As a superlibrarian place a hold for the record from step 6 using the patron from step 5: - If placing a hold for the next available item, the "Pickup at" dropdown list should list all libraies. - If placing a hold on a specific item, the dropdown list for the "Allowed pickup locations" column for each item should also list all libraries. - After placing the hold, in the "Existing holds" table, the dropdown list for each hold in the "Pickup library" column should also list all libraries. 8. Log out from the staff interface and login with the staff patron from step 4. 9. Find the record from step 6 and place a hold using the patron from step 5 - the library dropdown list should be limited to the item's home library: - If placing a hold for the next available item, the "Pickup at" dropdown list should only list the item's home library. - If placing a hold on a specific item, the dropdown list for the "Allowed pickup locations" column for each item should also only list the item's home library. - After placing the hold, in the "Existing holds" table, the "Pickup library" column should now only show the item's home librayr, with no dropdown list. Signed-off-by: Anni Rajala <anni.rajala@turku.fi> Signed-off-by: baptiste <baptiste.bayche@inlibro.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 --- Comment #19 from David Nind <david@davidnind.com> --- Created attachment 176046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176046&action=edit Bug 35434: (follow-up) Added canreservefromotherbranches When IndependentBranches is enabled, canreservefromotherbranches set to don't allow is also required to prevent non-superlibrarians from placing holds in other libraries. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169919|0 |1 is obsolete| | --- Comment #20 from David Nind <david@davidnind.com> --- Created attachment 176047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176047&action=edit Bug 35434: (follow-up) Unit test Test plan: 1. Tests should pass: prove t/db_dependent/Koha/Item.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #169918|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169917|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes placing holds in release notes| |the staff interface so that | |non-superlibrarians can't | |place holds for other | |libraries when: | |- | |IndependentBranches is | |enabled | |- | |canreservefromotherbranches | |is set to don't allow. | | | |Previously, all libraries | |were listed when placing a | |hold - it should only show | |the item's home library. Assignee|emily-rose.francoeur@inLibr |hammat.wele@inlibro.com |o.com | --- Comment #21 from David Nind <david@davidnind.com> --- I've changed the assignee - please correct if I have changed it to the wrong person! I also edited the commit messages - feel free to fix up any mistakes I may have made. Testing notes (using koha-testing-docker (KTD)): 1. Step 3 - in KTD, these are the default rules already, so no need to change. 2. Step 4 - I used Henry Acevedo, Midway. 3. Step 5 - I used Edna Acosta, Midway. 4. Step 6 - I used Programming the Perl DBI, record number 13. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38040 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176045|0 |1 is obsolete| | --- Comment #22 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 178296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178296&action=edit Bug 35434: Prevent non-superlibrarians from placing holds in other libraries when using IndependentBranches When IndependentBranches is enabled and canreservefromotherbranches is set to don't allow, then non-superlibrarians should not be able to place holds for other libraries. Test plan: 1. Appy the patch. 2. In Koha administration > System preferences, set: - IndependentBranches: Yes - canreservefromotherbranches: Don't allow 3. In Koha administration > Circulation and fines rules, check that you have a rule for all patron categories and all item types, with unlimited holds. 4. Find (or create) a staff patron for a library other than Centerville: - Change the username and password so you can log in as the staff patron. - Add permissions to the staff patron (More > Set permissions): . Staff access, allows viewing of catalogue in staff interface . Add, modify and view patron information . Place and modify holds for patrons 5. Find (or create) a patron with the same home library as the staff patron in step 4. 6. Find (or create) a record with an item where the home and current library are the same as the staff patron in step 3 and the patron in step 5. 7. As a superlibrarian place a hold for the record from step 6 using the patron from step 5: - If placing a hold for the next available item, the "Pickup at" dropdown list should list all libraies. - If placing a hold on a specific item, the dropdown list for the "Allowed pickup locations" column for each item should also list all libraries. - After placing the hold, in the "Existing holds" table, the dropdown list for each hold in the "Pickup library" column should also list all libraries. 8. Log out from the staff interface and login with the staff patron from step 4. 9. Find the record from step 6 and place a hold using the patron from step 5 - the library dropdown list should be limited to the item's home library: - If placing a hold for the next available item, the "Pickup at" dropdown list should only list the item's home library. - If placing a hold on a specific item, the dropdown list for the "Allowed pickup locations" column for each item should also only list the item's home library. - After placing the hold, in the "Existing holds" table, the "Pickup library" column should now only show the item's home librayr, with no dropdown list. Signed-off-by: Anni Rajala <anni.rajala@turku.fi> Signed-off-by: baptiste <baptiste.bayche@inlibro.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176046|0 |1 is obsolete| | --- Comment #23 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 178297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178297&action=edit Bug 35434: (follow-up) Added canreservefromotherbranches When IndependentBranches is enabled, canreservefromotherbranches set to don't allow is also required to prevent non-superlibrarians from placing holds in other libraries. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176047|0 |1 is obsolete| | --- Comment #24 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 178298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178298&action=edit Bug 35434: (follow-up) Unit test Test plan: 1. Tests should pass: prove t/db_dependent/Koha/Item.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- [1] Please check: FAIL t/db_dependent/Koha/Item.t FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl t/db_dependent/Koha/Item.t` FAIL valid Scalar value @pickup_locations[0] better written as $pickup_locations[0] [2] Minor point. Feeis like the following code parts should be reversed: if ( C4::Context->preference("IndependentBranches") and !C4::Context->preference("canreservefromotherbranches") ) { my $userenv = C4::Context->userenv; unless ( C4::Context->IsSuperLibrarian ) { return Koha::Libraries->new()->empty if ( $self->homebranch ne $userenv->{branch} ); return Koha::Libraries->search( { branchcode => $self->homebranch } ); } } Koha::Exceptions::MissingParameter->throw( parameter => 'patron' ) unless exists $params->{patron}; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 --- Comment #26 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 178999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178999&action=edit Bug 35434: (follow-up) tidy code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #27 from Hammat wele <hammat.wele@inlibro.com> --- (In reply to Marcel de Rooy from comment #25)
[2] Minor point. Feeis like the following code parts should be reversed:
I don't understand why this code parts should be reversed we added like asked (on comment #3) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Hammat wele from comment #27)
(In reply to Marcel de Rooy from comment #25)
[2] Minor point. Feeis like the following code parts should be reversed:
I don't understand why this code parts should be reversed we added like asked (on comment #3)
Hi Hammat, Reversed, not reverted. Misunderstanding? I think that you should first test for the missing param and throw an exception before testing the preference as mentioned in comment3 indeed. Note this is just a minor observation. Not important.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #29 from Magnus Enger <magnus@libriotech.no> --- Feels like this has been signed off and is in the QA stage. Does the last "tidy" patch require a new signoff, or could it be checked by QA? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178999|0 |1 is obsolete| | --- Comment #30 from Eric Bégin <eric.begin@inLibro.com> --- Created attachment 180275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180275&action=edit Bug 35434: (follow-up) tidy code Signed-off-by: Eric Bégin <eric.begin@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178296|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 182566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182566&action=edit Bug 35434: Prevent non-superlibrarians from placing holds in other libraries when using IndependentBranches When IndependentBranches is enabled and canreservefromotherbranches is set to don't allow, then non-superlibrarians should not be able to place holds for other libraries. Test plan: 1. Appy the patch. 2. In Koha administration > System preferences, set: - IndependentBranches: Yes - canreservefromotherbranches: Don't allow 3. In Koha administration > Circulation and fines rules, check that you have a rule for all patron categories and all item types, with unlimited holds. 4. Find (or create) a staff patron for a library other than Centerville: - Change the username and password so you can log in as the staff patron. - Add permissions to the staff patron (More > Set permissions): . Staff access, allows viewing of catalogue in staff interface . Add, modify and view patron information . Place and modify holds for patrons 5. Find (or create) a patron with the same home library as the staff patron in step 4. 6. Find (or create) a record with an item where the home and current library are the same as the staff patron in step 3 and the patron in step 5. 7. As a superlibrarian place a hold for the record from step 6 using the patron from step 5: - If placing a hold for the next available item, the "Pickup at" dropdown list should list all libraies. - If placing a hold on a specific item, the dropdown list for the "Allowed pickup locations" column for each item should also list all libraries. - After placing the hold, in the "Existing holds" table, the dropdown list for each hold in the "Pickup library" column should also list all libraries. 8. Log out from the staff interface and login with the staff patron from step 4. 9. Find the record from step 6 and place a hold using the patron from step 5 - the library dropdown list should be limited to the item's home library: - If placing a hold for the next available item, the "Pickup at" dropdown list should only list the item's home library. - If placing a hold on a specific item, the dropdown list for the "Allowed pickup locations" column for each item should also only list the item's home library. - After placing the hold, in the "Existing holds" table, the "Pickup library" column should now only show the item's home librayr, with no dropdown list. Signed-off-by: Anni Rajala <anni.rajala@turku.fi> Signed-off-by: baptiste <baptiste.bayche@inlibro.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178297|0 |1 is obsolete| | --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 182567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182567&action=edit Bug 35434: (follow-up) Added canreservefromotherbranches When IndependentBranches is enabled, canreservefromotherbranches set to don't allow is also required to prevent non-superlibrarians from placing holds in other libraries. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178298|0 |1 is obsolete| | --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 182568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182568&action=edit Bug 35434: (follow-up) Unit test Test plan: 1. Tests should pass: prove t/db_dependent/Koha/Item.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180275|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 182569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182569&action=edit Bug 35434: (follow-up) tidy code Signed-off-by: Eric Bégin <eric.begin@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've squashed the 'tidy code' into the previous patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We did it :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #38 from Fridolin Somers <fridolin.somers@biblibre.com> --- IndependentBranches is tricky I prefer not impact 24.11 LTS for behavior stability -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org