[Bug 30226] New: Add system preference to disable auto-renew checkbox at checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 Bug ID: 30226 Summary: Add system preference to disable auto-renew checkbox at checkout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In the Checkout Settings area of the checkout screen, there's a checkbox to make an individual checkout auto-renew. For libraries that don't wish to use auto-renewal at all and don't have the cron enabled, it would be good to have a system preference to remove this checkbox. It can be hidden with jQuery or CSS, but fully disabling it would be preferable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 131388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131388&action=edit Bug 30226: Add system preference AllowSetAutomaticRenewal To test: 1. Apply patch, restart the things, and run updatedatabase 2. Look for the system preference 'AllowSetAutomaticRenewal'. 3. To preserve current behavior the system preference should be set to allow by default. 4. Go to the circulation page and see that under 'Checkout settings' there is the option to set a particular item for auto renewal. 5. Set 'AllowSetAutomaticRenewal' to 'don't allow'. 6. Go back to the circulation page and under checkout settings you should no longer see the option to set an item for auto renewal. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131388|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 131389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131389&action=edit Bug 30226: Add system preference AllowSetAutomaticRenewal To test: 1. Apply patch, restart the things, and run updatedatabase 2. Look for the system preference 'AllowSetAutomaticRenewal'. 3. To preserve current behavior the system preference should be set to allow by default. 4. Go to the circulation page and see that under 'Checkout settings' there is the option to set a particular item for auto renewal. 5. Set 'AllowSetAutomaticRenewal' to 'don't allow'. 6. Go back to the circulation page and under checkout settings you should no longer see the option to set an item for auto renewal. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131389|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 131618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131618&action=edit Bug 30226: Add system preference AllowSetAutomaticRenewal To test: 1. Apply patch, restart the things, and run updatedatabase 2. Look for the system preference 'AllowSetAutomaticRenewal'. 3. To preserve current behavior the system preference should be set to allow by default. 4. Go to the circulation page and see that under 'Checkout settings' there is the option to set a particular item for auto renewal. 5. Set 'AllowSetAutomaticRenewal' to 'don't allow'. 6. Go back to the circulation page and under checkout settings you should no longer see the option to set an item for auto renewal. Signed-off-by: Kelly mcElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com --- Comment #4 from Jessie Zairo <jzairo@bywatersolutions.com> --- Bug 30226: Add system preference AllowSetAutomaticRenewal To test: 1. Apply patch, restart the things, and run updatedatabase 2. Look for the system preference 'AllowSetAutomaticRenewal'. 3. To preserve current behavior the system preference should be set to allow by default. 4. Go to the circulation page and see that under 'Checkout settings' there is the option to set a particular item for auto renewal. 5. Set 'AllowSetAutomaticRenewal' to 'don't allow'. 6. Go back to the circulation page and under checkout settings you should no longer see the option to set an item for auto renewal. Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + INSERT IGNORE INTO systempreferences (`variable`, `value`, `options`, `explanation`, `type` ) VALUES('AllowSetAutomaticRenewal', '1', '|yes|no', 'Allow or Prevent staff from flagging items for autorenewal on the checkout page', 'YesNo') | before yes seems unneeded Allow or Prevent should probably be Allow or prevent No blocker -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + # Finished adding system preference AllowSetAutomaticRenewal + say $out "Added system preference AllowSetAutomaticRenewal"; Not needed. You just repeat yourself here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- +('AllowSetAutomaticRenewal','1',NULL,'If ON, allows staff to set items for automatic renewal on the check out page','YesNo'), Other description. Not consistent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #5)
| before yes seems unneeded
Actually it is a YesNo, so there should be no choices. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131618|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 133353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133353&action=edit Bug 30226: Add system preference AllowSetAutomaticRenewal To test: 1. Apply patch, restart the things, and run updatedatabase 2. Look for the system preference 'AllowSetAutomaticRenewal'. 3. To preserve current behavior the system preference should be set to allow by default. 4. Go to the circulation page and see that under 'Checkout settings' there is the option to set a particular item for auto renewal. 5. Set 'AllowSetAutomaticRenewal' to 'don't allow'. 6. Go back to the circulation page and under checkout settings you should no longer see the option to set an item for auto renewal. Signed-off-by: Kelly mcElligott <kelly@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 133354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133354&action=edit Bug 30226: (QA follow-up) Sync atomicupdate with sysprefs.sql Description and remove choices. Set items => flag items (as in circulation.pref) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25029 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 133507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133507&action=edit Bug 30226: (follow-up) Remove text from database update The text displayed by database update is not really helpful. And it will be incorrect if update is run several times. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org