[Bug 30288] New: Provide links to OPACUserJS and OPACUserCSS in tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Bug ID: 30288 Summary: Provide links to OPACUserJS and OPACUserCSS in tools Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org We find ourselves using the OPACUserJS and OPACUserCSS system preferences quite often in conjunction with the News tool and HTML Customisation tool. It would be great if they were easy to access while making changes in these tools. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|oleonard@myacpl.org |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 131648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131648&action=edit Bug 30288: Provide links to OPACUserJS and OPACUserCSS in tools This patch provides easy access to the OPACUserJS and OPACUserCSS system preferences in the Additional Contents (News and HTML customisations) sections. To test: 1. In the staff client, go to Tools -> News. Notice there is a button to add a New entry. Confirm this button is also there when you go to Tools -> HTML customisations. 2. Apply the patch and refresh the page. 3. Confirm there are now two new buttons to take you to OPACUserJS and OPACUserCSS. Confirm these buttons take you to the correct system preference. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I think the links should be wrapped in a permissions check. My preference, I think, would be for the links to be smaller text links alongside the "See: News" links, but that's just a suggestion. My reasoning is that *usually* the buttons are reserved for "actions" not navigation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131648|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 131698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131698&action=edit Bug 30288: Provide links to OPACUserJS and OPACUserCSS in tools This patch provides easy access to the OPACUserJS and OPACUserCSS system preferences in the Additional Contents (News and HTML customisations) sections. These links can be enabled or disabled with the new system preference OPACEnhancementPreferencesLinks. To test: 1. Apply the patch and update the database to apply the new system preference. 2. In the staff client, go to Tools -> Additional Contents (either News or HTML customisations). Notice there is a link "See News" or "See HTML customisations". 3. Go to Koha Administration -> system preferences -> Tools tab, find the OPACEnhancementPreferencesLinks system preference. Confirm it is disabled by default. Enable it (set to 'provide'). 4. Go back to Tools -> Additional contents. Confirm there are now links to "See OPACUserCSS" and "See OPACUserJS". Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131698|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131704&action=edit Bug 30288: Provide links to OPACUserJS and OPACUserCSS in tools This patch provides easy access to the OPACUserJS and OPACUserCSS system preferences in the Additional Contents (News and HTML customisations) sections. To test: 1. In the staff client, go to Tools -> News. Notice there is a button to add a New entry. Confirm this button is also there when you go to Tools -> HTML customisations. 2. Apply the patch and refresh the page. 3. Confirm there are now two new buttons to take you to OPACUserJS and OPACUserCSS. Confirm these buttons take you to the correct system preference. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131705&action=edit Bug 30288: (follow-up) Add permissions check This follow-up wraps the system preference links in a check for "parameters_manage_sysprefs" permission so that the links don't display to those without permission to access system preferences. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Aleisha Amohia from comment #3)
These links can be enabled or disabled with the new system preference OPACEnhancementPreferencesLinks.
I'm sorry for creating confusion Aleisha, I wasn't asking for a system preference. I've restored your original patch and added a follow-up. Please take a look and see if you agree. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131705|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 131765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131765&action=edit Bug 30288: (follow-up) Add permissions check This follow-up wraps the system preference links in a check for "parameters_manage_sysprefs" permission so that the links don't display to those without permission to access system preferences. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131704|0 |1 is obsolete| | Attachment #131765|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 133355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133355&action=edit Bug 30288: Provide links to OPACUserJS and OPACUserCSS in tools This patch provides easy access to the OPACUserJS and OPACUserCSS system preferences in the Additional Contents (News and HTML customisations) sections. To test: 1. In the staff client, go to Tools -> News. Notice there is a button to add a New entry. Confirm this button is also there when you go to Tools -> HTML customisations. 2. Apply the patch and refresh the page. 3. Confirm there are now two new buttons to take you to OPACUserJS and OPACUserCSS. Confirm these buttons take you to the correct system preference. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Bug 30288: (follow-up) Add permissions check This follow-up wraps the system preference links in a check for "parameters_manage_sysprefs" permission so that the links don't display to those without permission to access system preferences. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ah this patch adds pipes as separator. Please use CSS for this, like in #moresearches : https://git.koha-community.org/Koha-community/Koha/src/commit/833c9efee0c0e0... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 133510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133510&action=edit Bug 30288: (follow-up) Use CSS for separator pipes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 133612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133612&action=edit Bug 28786: Don't set auth_method to NULL in ->anonymize DBI Exception: DBD::mysql::st execute failed: Column 'auth_method' cannot be null caught by t/db_dependent/Koha/Patrons.t Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133510|0 |1 is obsolete| | --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 133613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133613&action=edit Bug 30288: (follow-up) Use CSS for separator pipes Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133612|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Provide links to OPACUserJS |Provide links to OPACUserJS |and OPACUserCSS in tools |and OPACUserCSS from | |News/HTML customizations --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It appears like the first patch was already pushed, so only the follow-up is needed now: https://git.koha-community.org/Koha-community/Koha/commit/aa1def3180f8bc2b0d... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133613|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 133783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133783&action=edit Bug 30288: (follow-up) Use CSS for separator pipes Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #13)
It appears like the first patch was already pushed, so only the follow-up is needed now:
https://git.koha-community.org/Koha-community/Koha/commit/ aa1def3180f8bc2b0d08b0ac2e57bed29e47d27a
Oups sorry for that. I've pushed follow-up and will update status. Very nice btw ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org