[Bug 43150] New: Deleting holidays on range may sometimes delete too many holidays
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43150 Bug ID: 43150 Summary: Deleting holidays on range may sometimes delete too many holidays Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: emmi.takkinen@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Noticed while working on bug 24782. When modifying holidays on range sometimes those modifications would seep into other holidays that aren't on given timeperiod. Tested some more and this can also happen with deleting holidays on range too. This really tricky to reproduce and it doesn't occur all the time, but here's one way to make this happen. 1. Make sure you have plack running. 2. Create three single holidays on a range. 3. Now delete last two of the just added holidays, use " Delete the single holidays on a range." tool. => Note that all holidays were deleted. => Add holidays for different timeperiods and delete them, note how deleting may affect holidays out of given timeperiod. We had a same problem with adding new holidays and it was fixed on bug 38357. This seems to be a same problem, @holiday_list is not reseted to an empty array so previously created/deleted/modif holidays are never cleared from plack workers memory. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43150 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43150 --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 202321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202321&action=edit Bug 43150: Prevent deleting too many holidays When one deletes holidays on range sometimes too many holidays are deleted. This happens because array @holiday_list is not reseted to an empty array so previously created/deleted/modif holidays are never cleared from plack workers memory. Same happened with adding new holidays and it was fixed on bug 38357. To test 1. Make sure you have plack running. 2. Create three single holidays on a range. 3. Now delete last two of the just added holidays, use " Delete the single holidays on a range." tool. => Note that all holidays were deleted. 4. Apply this patch, restart services. 5. Repeat steps 2. and 3. => Note that now only holidays on given range were deleted. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43150 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43150 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24782 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24782 [Bug 24782] Calendar edit only applies to first day -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43150 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202321|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43150 --- Comment #2 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 206492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206492&action=edit Bug 43150: Prevent deleting too many holidays When one deletes holidays on range sometimes too many holidays are deleted. This happens because array @holiday_list is not reseted to an empty array so previously created/deleted/modif holidays are never cleared from plack workers memory. Same happened with adding new holidays and it was fixed on bug 38357. To test 1. Make sure you have plack running. 2. Create three single holidays on a range. 3. Now delete last two of the just added holidays, use " Delete the single holidays on a range." tool. => Note that all holidays were deleted. 4. Apply this patch, restart services. 5. Repeat steps 2. and 3. => Note that now only holidays on given range were deleted. Sponsored-by: Koha-Suomi Oy Signed-off-by: Gretchen Maxeiner <maxeinergl@gcc.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43150 Gretchen Maxeiner <maxeinergl@gcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maxeinergl@gcc.edu --- Comment #3 from Gretchen Maxeiner <maxeinergl@gcc.edu> --- It took me a while to get the problematic behavior to appear. It was only after adding holiday ranges and deleting some ranges, adding/deleting, and adding/deleting a third time (=steps 2 and 3 repeated 3 times) that it happened, after which it consistently over-deleted my ranges. After applying the patch to my sandbox I recreated my steps exactly and there were no issues with deleting more ranges than specified. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43150 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43150 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- The patch looks good, but could we add a regression test for this issue? I checked the existing calendar tests and didn't find coverage for `tools/exceptionHolidays.pl`. Since the issue involves `@holiday_list` retaining values between requests under Plack, testing the calendar deletion methods alone wouldn't necessarily catch it. Ideally, the regression test would verify that consecutive range deletion operations in the same persistent process don't affect holidays outside the selected range. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43150 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org