[Bug 42555] New: (Bug 25314 follow-up) Destroyed labels for customized facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42555 Bug ID: 42555 Summary: (Bug 25314 follow-up) Destroyed labels for customized facets Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: januszop@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 25314 After applying Bug 25314, customized facets generated from mappings.yaml are displayed with the technical type_id instead of the proper label. This could be fixed with a simple correction in koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc: @@ -81,7 +81,7 @@ [% CASE 'Languages' %] <a [% attrs | $raw %] id="facet-languages">Languages</a> [% CASE %] - <a [% attrs | $raw %] id="facet-[% facets_loo.type_link_value | html %]">[% facets_loo.type_id | html %]</a> + <a [% attrs | $raw %] id="facet-[% facets_loo.type_link_value | html %]">[% facets_loo.label | html %]</a> [% END %] <div class="facet-collapse collapse show" id="[% facets_loo.type_id | html %]_collapse"> <ul> Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 [Bug 25314] Make OPAC facets collapse -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42555 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |januszop@gmail.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42555 --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 198784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198784&action=edit Bug 42555: (Bug 25314 follow-up) Destroyed labels for customized facets After applying Bug 25314, customized facets generated from mappings.yaml are displayed with the technical type_id instead of the proper label. Test plan: ========== 1. In KTD with Elasticsearch enabled, add the following to admin/searchengine/elasticsearch/mappings.yaml su-gen: facet_order: 33 label: Genre/Form mappings: - facet: 1 marc_field: 655a marc_type: marc21 sort: 1 suggestible: '' opac: 1 staff_client: 1 type: '' Reindex with: koha-elasticsearch --rebuild -r -d -b kohadev 2. In the OPAC, at the bottom of the facets area, you should see a facet labeled su-gen_id instead of Genre/Form. 3. Apply the patch ; restart_all. 4. The facet should now display the correct label: Genre/Form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42555 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|(Bug 25314 follow-up) |(Bug 25314 follow-up) |Destroyed labels for |Destroyed labels for |customized facets |customized facets in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42555 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42555 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198784|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42555 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 199054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199054&action=edit Bug 42555: (Bug 25314 follow-up) Destroyed labels for customized facets After applying Bug 25314, customized facets generated from mappings.yaml are displayed with the technical type_id instead of the proper label. Test plan: ========== 1. In KTD with Elasticsearch enabled, add the following to admin/searchengine/elasticsearch/mappings.yaml su-gen: facet_order: 33 label: Genre/Form mappings: - facet: 1 marc_field: 655a marc_type: marc21 sort: 1 suggestible: '' opac: 1 staff_client: 1 type: '' Reindex with: koha-elasticsearch --rebuild -r -d -b kohadev 2. In the OPAC, at the bottom of the facets area, you should see a facet labeled su-gen_id instead of Genre/Form. 3. Apply the patch ; restart_all. 4. The facet should now display the correct label: Genre/Form. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42555 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the labels for release notes| |facets in the OPAC. | |Customized facets generated | |from mappings.yaml were | |displayed with the | |technical type_id instead | |of the proper label. | | | |For example, for a facet | |defined as "su-gen" with a | |label of "Genre/Form", | |"su-gen" was used as the | |label instead of | |"Genre/Form". | | | |(This is related to Bug | |25314 - Make OPAC facets | |collapse, added to Koha | |26.05.00,25.11.04.) Summary|(Bug 25314 follow-up) |(Bug 25314 follow-up) ID |Destroyed labels for |incorrectly used for facet |customized facets in OPAC |label for customized facets | |in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42555 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42555 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Sponsorship status|--- |Unsponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42555 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199054|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42555 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 199925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199925&action=edit Bug 42555: (Bug 25314 follow-up) Destroyed labels for customized facets After applying Bug 25314, customized facets generated from mappings.yaml are displayed with the technical type_id instead of the proper label. Test plan: ========== 1. In KTD with Elasticsearch enabled, add the following to admin/searchengine/elasticsearch/mappings.yaml su-gen: facet_order: 33 label: Genre/Form mappings: - facet: 1 marc_field: 655a marc_type: marc21 sort: 1 suggestible: '' opac: 1 staff_client: 1 type: '' Reindex with: koha-elasticsearch --rebuild -r -d -b kohadev 2. In the OPAC, at the bottom of the facets area, you should see a facet labeled su-gen_id instead of Genre/Form. 3. Apply the patch ; restart_all. 4. The facet should now display the correct label: Genre/Form. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42555 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42555 --- Comment #4 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42555 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42555 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42555 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Keywords| |rel_25_11_candidate --- Comment #6 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Can we please have this backported to 25.11? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42555 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Version(s)|26.11.00,26.05.01 |26.11.00,26.05.01,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42555 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00,26.05.01,25.11.05 |26.11.00,26.05.01 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42555 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comment #7 is|1 |0 private| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42555 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Laura Escamilla from comment #6)
Can we please have this backported to 25.11?
(In reply to Baptiste Wojtkowski (bwoj) from comment #7)
Pushed into 25.11.x for 25.11.05 nice work everyone
Looking forward to this. It's quite an annoying bug... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org