[Bug 6919] New: Implementing XSLTResultsDisplay
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Bug #: 6919 Summary: Implementing XSLTResultsDisplay Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: alex.arnaud@biblibre.com QAContact: koha-bugs@lists.koha-community.org -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 --- Comment #1 from Alex Arnaud <alex.arnaud@biblibre.com> 2011-09-26 14:42:28 UTC --- Created attachment 5590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5590 Proposed patch This patch implements intranet XSLTResultsDisplay. I've added very very small xslt stylesheets for MARC21 and UNIMARC. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|oleonard@myacpl.org |alex.arnaud@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-09-26 16:35:57 UTC --- Created attachment 5592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5592 Screenshot after applying patch This isn't working for me. I see no title information in my results display. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Failed QA --- Comment #3 from Nicole C. Engard <nengard@gmail.com> 2011-09-26 17:52:17 UTC --- After applying this patch all the title information disappears from the search results. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-09-26 17:52:49 UTC --- Created attachment 5595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5595 no titles after patch this is marc21 if that matters. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 --- Comment #5 from Nicole C. Engard <nengard@gmail.com> 2011-09-26 17:53:06 UTC --- Created attachment 5596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5596 before patch titles show -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2011-09-26 17:53:37 UTC --- oops, i said the same thing owen did :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5590|0 |1 is obsolete| | --- Comment #7 from Alex Arnaud <alex.arnaud@biblibre.com> 2011-09-27 08:29:11 UTC --- Created attachment 5602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5602 Replacement patch Indeed, MARC21 xslt was wrong. Now it should be ok. This patch aims to implement intranet XSLTResultsDisplay not to improve shipping xslt stylesheets. So, they are very light. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Patch Status|Needs Signoff |Failed QA --- Comment #8 from Liz Rea <wizzyrea@gmail.com> 2011-09-27 14:56:28 UTC --- Still no titles? http://screencast.com/t/kAuKVMLD (MARC21) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5602|0 |1 is obsolete| | --- Comment #9 from Alex Arnaud <alex.arnaud@biblibre.com> 2011-09-27 15:53:26 UTC --- Created attachment 5607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5607 Replacement patch i'm tired ... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #10 from Nicole C. Engard <nengard@gmail.com> 2011-09-27 20:54:36 UTC --- Sorry, still not titles -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 --- Comment #11 from Liz Rea <wizzyrea@gmail.com> 2011-09-27 21:34:34 UTC --- Interesting, there were titles when I tested this earlier. But I still don't think I can pass it - it would be extremely confusing for libraries who have the intranetxsltresults pref - they would be expecting an *improvement* in the display, and as it was when I tested it, it was title only and none of the other things librarians would be expecting. This is a great patch to build off of, so I'm grateful to Alex for submitting it, but it will have to be built up before it can be included, imo. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> 2011-09-28 11:29:36 UTC --- Liz & Nicole : the UNIMARC version is better. If you want a great MARC21 version, please give Alex the MARC21 fields to display. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 --- Comment #13 from Liz Rea <wizzyrea@gmail.com> 2011-09-28 19:51:41 UTC --- I might suggest you split this into marc21 and unimarc patches, so that unimarc, if it passes a unimarc user's tests, can be passed on it's own. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 --- Comment #14 from Alex Arnaud <alex.arnaud@biblibre.com> 2011-10-07 15:03:22 UTC --- Created attachment 5774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5774 bug 6919 - implements XSLTResultsDisplay and adding both unimarc and marc21 xslt -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5607|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 --- Comment #15 from Alex Arnaud <alex.arnaud@biblibre.com> 2011-10-07 15:07:36 UTC --- Just sent a new patch. It's the same than last one but there's more things in the MARC21 xslt (It comes from opac). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> 2011-10-07 15:20:56 UTC --- It works well for Unimarc. Signed off. Waiting for someone to test Marc21 xslt. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5592|0 |1 is obsolete| | Attachment #5595|0 |1 is obsolete| | Attachment #5596|0 |1 is obsolete| | --- Comment #17 from Owen Leonard <oleonard@myacpl.org> 2011-10-19 13:41:18 UTC --- Created attachment 5983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5983 Screenshot showing duplicate availability information This is much improved, but I don't think we're there yet. There are a couple of things missing: - linking the author name to an author search - publication information, "Washington, D.C. : Smithsonian Folkways, 1990" - physical description: "1 sound disc (32:15 min.) : ; 4 3/4 in." The other issue I see is that the availability information is now duplicated: It's shown once in the XSL output and again in the Location table column. It could be that people who enable the XSL view would like to have availability show only in the XSL and we could get rid of the Location column. If so I think we probably need to make the status information more verbose as it is in the Location column. The other option of course is to remove the availability information from the XSL output and keep the Location column. This would probably be a good topic to bring up on the Koha list. Whether this means this patch can't be approved I don't know. Since it's controlled by a system preference it's not going to hurt anyone to have the option (especially if the UNIMARC version is better). But I hate to offer people a new feature which isn't more polished. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |Rel_3_8 --- Comment #18 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-24 11:38:11 UTC --- Updating Version : This ENH will be for Koha 3.8 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Rel_3_8 |master --- Comment #19 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-25 15:05:45 UTC --- Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #20 from Owen Leonard <oleonard@myacpl.org> 2011-12-08 14:09:34 UTC --- *** Bug 4813 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Doug Dearden <dearden@sarsf.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dearden@sarsf.org --- Comment #21 from Doug Dearden <dearden@sarsf.org> 2011-12-08 21:10:54 UTC --- On this line: + <xsl:variable name="Show856uAsImage" select="marc:sysprefs/marc:syspref[@name='OPACDisplay856uAsImage']"/> OPACDisplay856uAsImage should be changed to Display856uAsImage so it picks up the correct system preference from the Staff Client area instead of the OPAC area. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Failed QA --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-21 20:58:11 UTC --- comments 17 and 21 note some problems with the patch. I am changing to failed qa. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P1 - high Status|Failed QA |Needs Signoff Blocks| |4032 Severity|enhancement |major --- Comment #23 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-03 15:25:19 UTC --- Reviving this bug: * it's not an Enhancement, it's a bugfix = the syspref exist and does nothing at the moment ! * The proposed MARC21 XSLT is derived from the OPAC one. If there is something wrong, please, propose a follow-up. If there is something missing I think that's for another bug entry. Because atm, activating the syspref results in nothing, so the most important is to have the syspref work ! switching back to needs signoff Also note that Stéphane submit an enhancement to let libraries define the XSLT url, switching the 4 sysprefs from yes/no to full URL, see bug 4032 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 --- Comment #24 from stephane.delaune@biblibre.com 2012-02-03 16:08:41 UTC --- Created attachment 7453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7453 proposed patch if 4032 is apply after 6919 proposed patch if 4032 is apply after 6919 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 stephane.delaune@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaune@biblibre.c | |om --- Comment #25 from stephane.delaune@biblibre.com 2012-02-03 16:14:04 UTC --- If the 4032 is apply after this, you'll need to apply the "proposed patch if 4032 is apply after 6919 " to make compatibility between them -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5774|0 |1 is obsolete| | --- Comment #26 from Owen Leonard <oleonard@myacpl.org> 2012-02-08 16:29:27 UTC --- Created attachment 7507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7507 [SIGNED-OFF] bug 6919 - implements XSLTResultsDisplay and adding both unimarc and marc21 xslt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 --- Comment #27 from Owen Leonard <oleonard@myacpl.org> 2012-02-08 16:31:43 UTC --- Created attachment 7508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7508 [PATCH] Bug 6919 - Follow-up - Implementing XSLTResultsDisplay - Adding search result numbering to match non-XSLT results display. - Copying author handling (with link to author search) from OPAC detail XSL. - Copying physical description output from OPAC detail XSL. - Copying ISBN output from OPAC detail XSL. - Removing availability output (which had been copied from the OPAC) because it is redundant in the staff client. - Removing duplicate inclusion of JS highlight plugin on results page. - Updating highlight JS to make it compatible with XSLT results. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Marijana <mglavica@ffzg.hr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mglavica@ffzg.hr -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7507|0 |1 is obsolete| | --- Comment #28 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-09 20:40:09 UTC --- Created attachment 7542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7542 bug 6919 - implements XSLTResultsDisplay and adding both unimarc and marc21 xslt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7508|0 |1 is obsolete| | --- Comment #29 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-09 20:41:16 UTC --- Created attachment 7543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7543 Bug 6919 - Follow-up - Implementing XSLTResultsDisplay - Adding search result numbering to match non-XSLT results display. - Copying author handling (with link to author search) from OPAC detail XSL. - Copying physical description output from OPAC detail XSL. - Copying ISBN output from OPAC detail XSL. - Removing availability output (which had been copied from the OPAC) because it is redundant in the staff client. - Removing duplicate inclusion of JS highlight plugin on results page. - Updating highlight JS to make it compatible with XSLT results. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jcamins@cpbibliography.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QAContact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | --- Comment #30 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-14 21:48:57 UTC --- QA comment: * The patch from Stephane should not be applied, obsoleting it. The 4032 should be applicable only * translatable-template.t OK * valid-templates.t OK * works as expected in Unimarc with Owen follow-up I propose passed QA status. It's a BibLibre patch, and a quite large one, so won't mark passed QA, but ask Marcel. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7453|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #31 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-20 13:11:19 UTC --- Code looks good in general. One point that blocks this patch: The call to XSLTParse4Display is now made twice in Search.pm. (Line 1785 and line 1852) For the staff client case the function is called once due to the context check around the second call. For opac the function is called both times. Could you make an adjustment that combines both calls in one section of this script? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 --- Comment #32 from Alex Arnaud <alex.arnaud@biblibre.com> 2012-02-27 10:51:18 UTC --- Created attachment 7898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7898 Follow up patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 --- Comment #33 from Alex Arnaud <alex.arnaud@biblibre.com> 2012-02-27 10:52:43 UTC --- To test, apply: bug 6919 - implements XSLTResultsDisplay and adding both unimarc and marc21 xslt Bug 6919 - Follow-up - Implementing XSLTResultsDisplay Follow up patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #34 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-27 12:52:17 UTC --- small follow-up for QA acceptance, I think it can be switched to "signed-off" directly -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 --- Comment #35 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-29 14:42:34 UTC --- When I apply 7542, 7543 and then the followup 7898, the last one fails. Please check.. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 --- Comment #36 from Owen Leonard <oleonard@myacpl.org> 2012-02-29 15:07:47 UTC --- Using "git bz apply" I have no problems applying all three patches. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 --- Comment #37 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-29 15:41:29 UTC --- Forget my comment: vim problems.. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 --- Comment #38 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-03-01 09:27:41 UTC --- Created attachment 7958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7958 Picture of staff results Follows.. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7898|0 |1 is obsolete| | --- Comment #39 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-03-01 09:37:49 UTC --- Created attachment 7959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7959 [SIGNED_OFF] Follow up patch Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signing off on this one with the following note: You have moved the call to XSLTParse4Display from around line 1775 to around 1842, as compared to the situation before the three 6919 patches. I probably would have left it at its original location, but while examining the code between these two spots, I do not see any real problems with this move. Tested it, works okay. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #40 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-03-01 09:41:51 UTC --- Additional QA comments: 1) These patches are a welcome contribution! Resolving the missing XSLT display in staff for quite some time. 2) Please note my comment on the signoff of the last followup. (Thx for making the change BTW) 3) See my picture. Look at the first result. If there is no author, the first line is very close under the title. This is just a very minor design issue. But if you could send another followup making it look better, you are welcome. Marking these three patches now as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7959|0 |1 is patch| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_6 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7696 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org