[Bug 7526] New: longoverdue.pl leaves items marked as lost as still checked out to patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7526 Bug #: 7526 Summary: longoverdue.pl leaves items marked as lost as still checked out to patron Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation AssignedTo: kyle.m.hall@gmail.com ReportedBy: kyle.m.hall@gmail.com QAContact: koha.sekjal@gmail.com CC: gmcharlt@gmail.com When the longoverdu.pl script is run, and it marks an item as lost ( using LostItem() ), if fails to remove the item from the borrower record. So, the item is marked as lost, but is also still listed as checked out to the borrower. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7526 --- Comment #1 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-10 15:16:24 UTC --- Created attachment 7565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7565 Bug 7526 - longoverdue.pl leaves items marked as lost as still checked out to patron When the longoverdu.pl script is run, and it marks an item as lost ( using LostItem() ), if fails to remove the item from the borrower record. So, the item is marked as lost, but is also still listed as checked out to the borrower. This commit enables the mark_returned flag for the LostItem function as it is called from longoverdue.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7526 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7526 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2012-02-10 15:49:06 UTC --- The current functionality is the way we've always expected it to work! Maybe longoverdue.pl needs an option added to it in order to trigger the the process you want? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7526 --- Comment #3 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-10 17:13:07 UTC --- (In reply to comment #2) Agreed, if this was expected functionality, I will modify my patch and make it a system preference defaulting to the original functionality. Any suggestions for a preference name? RemoveLostItemsFromPatronAccount?
The current functionality is the way we've always expected it to work! Maybe longoverdue.pl needs an option added to it in order to trigger the the process you want?
-- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7526 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2012-02-10 17:22:37 UTC --- longoverdue.pl is always called from the command line isn't it? So wouldn't a command line parameter be sufficient? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7526 --- Comment #5 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-10 17:35:09 UTC --- (In reply to comment #4) Good point, I'll make it a command line switch instead.
longoverdue.pl is always called from the command line isn't it? So wouldn't a command line parameter be sufficient?
-- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7526 --- Comment #6 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-10 17:44:47 UTC --- Created attachment 7569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7569 Bug 7526 - longoverdue.pl leaves items marked as lost as still checked out to patron When the longoverdu.pl script is run, and it marks an item as lost ( using LostItem() ), if fails to remove the item from the borrower record. So, the item is marked as lost, but is also still listed as checked out to the borrower. This commit adds the command line parameter --mark-returned. If used, longoverdue.pl will remove lost items from the borrowers record. Functionality will remain the same if it is not used. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7526 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7565|0 |1 is obsolete| | Attachment #7569|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-10 17:48:31 UTC --- Created attachment 7570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7570 Bug 7526 - longoverdue.pl leaves items marked as lost as still checked out to patron Added command line switch so original functionality is maintained. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7526 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7526 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7570|0 |1 is obsolete| | --- Comment #8 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 8244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8244&action=edit [SIGNED-OFF] Bug 7526 - longoverdue.pl leaves items marked as lost as still checked out to patron When the longoverdu.pl script is run, and it marks an item as lost ( using LostItem() ), if fails to remove the item from the borrower record. So, the item is marked as lost, but is also still listed as checked out to the borrower. This commit adds the command line parameter --mark-returned. If used, longoverdue.pl will remove lost items from the borrowers record. Functionality will remain the same if it is not used. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> http://bugs.koha-community.org/show_bug.cgi?id=7426 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7526 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7526 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Ian Walls <koha.sekjal@gmail.com> --- Cleanly adds new commandline param to longoverdue.pl to make use of the new functionality. Won't regress any behaviour for libraries who are used to the current way of things. Cleans up some spacing in the GetOpt area. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7526 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|unspecified |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org