[Bug 21891] New: Remove non-XSLT detail view in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891 Bug ID: 21891 Summary: Remove non-XSLT detail view in the staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 12561 There are no bugs blocking the removal of the non-XSLT detail view in the staff client, so let's do it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 [Bug 12561] Omnibus: Deprecate non-XSLT detail and result views -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 87664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87664&action=edit Bug 21891: Remove non-XSLT detail view in the staff client This patch removes the non-XSLT markup from the bibliographic detail page in the staff client. The XSLTDetailsDisplay preference has been altered to accommodate this change. A blank value in XSLTDetailsDisplay will now be equivalent to "default." To test, apply the patch and set the value of XSLTDetailsDisplay to either blank or "default." View the detail page for a bibliographic record in the staff client. The XSLT view should be shown. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87664|0 |1 is obsolete| | --- Comment #2 from Michal Denar <black23@gmail.com> --- Created attachment 87677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87677&action=edit Bug 21891: Remove non-XSLT detail view in the staff client This patch removes the non-XSLT markup from the bibliographic detail page in the staff client. The XSLTDetailsDisplay preference has been altered to accommodate this change. A blank value in XSLTDetailsDisplay will now be equivalent to "default." To test, apply the patch and set the value of XSLTDetailsDisplay to either blank or "default." View the detail page for a bibliographic record in the staff client. The XSLT view should be shown. Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Works really well, only one request: Let's set the XSLTDetailsDisplay to default for those that have it empty now. It will advertise the change in the database update then too. Could we also remove staff results non-XSLT? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 87757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87757&action=edit Bug 21891: (follow-up) Update database to set blank values to "default" This patch adds a database update which will update any blank values of the XSLTDetailsDisplay system preference to "default." Although a blank value will still result in the default XSLT view, it's more consistent with the other XSLT preferences to use "default." To test, apply the patch and set the XSLTDetailsDisplay to a blank value. Run the database update. The value of the XSLTDetailsDisplay system preference should now be "default." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87757|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87758&action=edit Bug 21891: (follow-up) Update database to set blank values to "default" This patch adds a database update which will update any blank values of the XSLTDetailsDisplay system preference to "default." Although a blank value will still result in the default XSLT view, it's more consistent with the other XSLT preferences to use "default." To test, apply the patch and set the XSLTDetailsDisplay to a blank value. Run the database update. The value of the XSLTDetailsDisplay system preference should now be "default." Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Version(s)| |19.05.00 released in| | Resolution|--- |FIXED --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Marking as an enhancement as it's a cleanup piece which 'might' surprise users of the stable branch. Will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24059 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 [Bug 24059] Remove unused Greybox assets from detail.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org