[Bug 24008] New: No warning is produced when trying to delete a patron with credit (patron is not deleted)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Bug ID: 24008 Summary: No warning is produced when trying to delete a patron with credit (patron is not deleted) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: fridolin.somers@biblibre.com, gmcharlt@gmail.com, jonathan.druart@bugs.koha-community.org, katrin.fischer@bsz-bw.de, kyle.m.hall@gmail.com, martin.renvoize@ptfs-europe.com, testopia@bugs.koha-community.org, theod@lib.auth.gr, tomascohen@gmail.com, victor.grousset@biblibre.com Depends on: 23822 +++ This bug was initially created as a clone of Bug #23822 +++ When one tries to delete a patron that has a credit in his account, no warning is produced. The deletion is not performed (which is the proper behavior), however one would expect to see a warning similar to the one that is produced when the patron has an unpaid fine, a checked out item, a hold, etc. The following screencast was performed in ByWaters' sandboxes running 19.05 and shows the issue: https://screencast-o-matic.com/watch/cq6D6vu4YJ Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 [Bug 23822] No warning is produced when trying to delete a patron with credit (patron is not deleted) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|No warning is produced when |Attempting to delete a |trying to delete a patron |patron with outstanding |with credit (patron is not |credits should warn and |deleted) |block the deletion. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we should think if this should block or only warn - holds warn, fines block currently. I could see a credit warning, but not blocking. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Attempting to delete a |Attempting to delete a |patron with outstanding |patron with outstanding |credits should warn and |credits should warn and |block the deletion. |block the deletion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95924&action=edit Bug 24008: Display a warning message when deleting a patron with outstanding credits So far nothing is displayed if a librarian removes patron with outstanding credits. Note that outstanding debits blocks the deletion. Test plan: - Create a patron with outstanding credit - Create a patron with outstanding debits - Delete the 2 patrons => With credit - You get a warning but do not block the deletion => With debits - You get a warning message that blocks the deletion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Functionally this works well, but I wonder if we could improve the text a bit: Patron has 1 hold(s). Deleting patron cancels all their holds. Are you sure you want to delete the patron Nicole Schneider? This cannot be undone. Patron has a -9.00 credit. So now we have one warning on top (holds) an done below. I think that's not ideal for usability. It would be nicer to display them all together, maybe as a list? Also, should we remove the minus? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96142&action=edit Bug 24008: Display warnings in a list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #3)
Functionally this works well, but I wonder if we could improve the text a bit:
Patron has 1 hold(s). Deleting patron cancels all their holds.
Are you sure you want to delete the patron Nicole Schneider? This cannot be undone. Patron has a -9.00 credit.
So now we have one warning on top (holds) an done below. I think that's not ideal for usability. It would be nicer to display them all together, maybe as a list?
Done.
Also, should we remove the minus?
Maybe, no idea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think it's clearer as a positive amount personally.. it's a 'credit' so it's already identified as such in the sentence rather than needing to state the sign. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96604&action=edit Bug 24008: Remove minus sign when displaying credit value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Note sure it is expected, but if you have a credit of 5 and a debit of 5, the patron deletion is blocked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #8)
Note sure it is expected, but if you have a credit of 5 and a debit of 5, the patron deletion is blocked.
It is expected. Unless AccountAutoReconcile is set or reconcile_balance.pl run, this situations can happen. And credits need to be applied manually. So technically, there's credit on their account. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95924|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97400&action=edit Bug 24008: Display a warning message when deleting a patron with outstanding credits So far nothing is displayed if a librarian removes patron with outstanding credits. Note that outstanding debits blocks the deletion. Test plan: - Create a patron with outstanding credit - Create a patron with outstanding debits - Delete the 2 patrons => With credit - You get a warning but do not block the deletion => With debits - You get a warning message that blocks the deletion Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96142|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97401&action=edit Bug 24008: Display warnings in a list Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96604|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97402&action=edit Bug 24008: Remove minus sign when displaying credit value Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works well, signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97400|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97603&action=edit Bug 24008: Display a warning message when deleting a patron with outstanding credits So far nothing is displayed if a librarian removes patron with outstanding credits. Note that outstanding debits blocks the deletion. Test plan: - Create a patron with outstanding credit - Create a patron with outstanding debits - Delete the 2 patrons => With credit - You get a warning but do not block the deletion => With debits - You get a warning message that blocks the deletion Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97401|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97604&action=edit Bug 24008: Display warnings in a list Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97402|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97605&action=edit Bug 24008: Remove minus sign when displaying credit value Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I feel styling could be a little improved for the message in general, but that's outside of scope here. Works well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_target |Manual, | |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |joy@bywatersolutions.com Resolution|--- |FIXED --- Comment #19 from Joy Nelson <joy@bywatersolutions.com> --- Enhancement not backported to 19.11.x branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Attempting to delete a |Attempting to delete a |patron with outstanding |patron with outstanding |credits should warn and |credits should warn, but |block the deletion |not block the deletion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Attempting to delete a |Attempting to delete a |patron with outstanding |patron with outstanding |credits should warn, but |credits will warn, but not |not block the deletion |block the deletion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org