[Bug 33171] New: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Bug ID: 33171 Summary: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Some libraries would like to use the following item fields with the MarcItemFieldsToOrder system preference: * coded_location_qualifier * barcode * enumchron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33170 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33170 [Bug 33170] Refactor MarcItemFieldsToOrder code to make adding more field simpler -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 147964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147964&action=edit Bug 33171: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147964|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 147966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147966&action=edit Bug 33171: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder Some libraries would like to use the following item fields with the MarcItemFieldsToOrder system preference: * coded_location_qualifier * barcode * enumchron Test Plan: 1) Set up MarcItemFieldsToOrder, verify it is functioning 2) Test coded_location_qualifier, barcode, and enumchron 3) Note the fields are imported and set for the items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org --- Comment #3 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Don't forget to add these fields to the list of supported values in the syspref description, please. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Tested this on a sandbox with the following in MarcItemFieldsToOrder: itype: 975$y coded_location_qualifier: 975$a barcode: 975$b enumchrom: 975$c My staged record contained: 975 _y CF _a coded location _b barcode _c enumchron On addorderiso2709.pl, when creating an order from my MARC record, the itype and coded location qualifier and correctly populated, but the barcode and enumchron are not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30529 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147966|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153294&action=edit Bug 33171: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder Some libraries would like to use the following item fields with the MarcItemFieldsToOrder system preference: * coded_location_qualifier * barcode * enumchron Test Plan: 1) Set up MarcItemFieldsToOrder, verify it is functioning 2) Test coded_location_qualifier, barcode, and enumchron 3) Note the fields are imported and set for the items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Fixed! (In reply to Andrew Fuerste-Henry from comment #4)
Tested this on a sandbox with the following in MarcItemFieldsToOrder: itype: 975$y coded_location_qualifier: 975$a barcode: 975$b enumchrom: 975$c
^ I don't know if this was wrong in your syspref, but enumchron is spelled wrong here. I caught that during testing 😁 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Bug 33171 depends on bug 33170, which changed state. Bug 33170 Summary: Refactor MarcItemFieldsToOrder code to make adding more fields simpler https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33170 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 159331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159331&action=edit Marc file with mappings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153294|0 |1 is obsolete| | --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 159332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159332&action=edit Bug 33171: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder Some libraries would like to use the following item fields with the MarcItemFieldsToOrder system preference: * coded_location_qualifier * barcode * enumchron Test Plan: 1) Set up MarcItemFieldsToOrder, verify it is functioning 2) Test coded_location_qualifier, barcode, and enumchron 3) Note the fields are imported and set for the items Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 159333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159333&action=edit Bug 33171: Fix missing price when mapped from MarcItemFieldsToOrder This patch fixes an issue where the price is not passed to the UI when read from MarcItemFieldsToOrder. Test plan: 1) In Administration, copy and paste the following into MarcItemFieldsToOrder: quantity: 975$q budget_code: 975$h price: 975$p itype: 975$y coded_location_qualifier: 975$a barcode: 975$b enumchron: 975$c 2) Save 3) Navigate to Acquisitions and find a basket 4) Click Add to basket and select From a new file 5) Choose the file attached to this bug 6) Upload file and click Stage for import 7) Click Add staged files to basket once the job is finished 8) Check the box next to the record 9) The price should show 10.00 under Item record 1 10) coded location qualifier, barcode, enumchron should also have values as per the other commit on this bug 11) Save and import, the basket should not have a value of 0 as the price has been read correctly 12) Check the database, the newest item should have values for price, coded_location_qualifier, barcode and enumchron Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159332|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159429&action=edit Bug 33171: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder Some libraries would like to use the following item fields with the MarcItemFieldsToOrder system preference: * coded_location_qualifier * barcode * enumchron Test Plan: 1) Set up MarcItemFieldsToOrder, verify it is functioning 2) Test coded_location_qualifier, barcode, and enumchron 3) Note the fields are imported and set for the items Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159333|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159430&action=edit Bug 33171: Fix missing price when mapped from MarcItemFieldsToOrder This patch fixes an issue where the price is not passed to the UI when read from MarcItemFieldsToOrder. Test plan: 1) In Administration, copy and paste the following into MarcItemFieldsToOrder: quantity: 975$q budget_code: 975$h price: 975$p itype: 975$y coded_location_qualifier: 975$a barcode: 975$b enumchron: 975$c 2) Save 3) Navigate to Acquisitions and find a basket 4) Click Add to basket and select From a new file 5) Choose the file attached to this bug 6) Upload file and click Stage for import 7) Click Add staged files to basket once the job is finished 8) Check the box next to the record 9) The price should show 10.00 under Item record 1 10) coded location qualifier, barcode, enumchron should also have values as per the other commit on this bug 11) Save and import, the basket should not have a value of 0 as the price has been read correctly 12) Check the database, the newest item should have values for price, coded_location_qualifier, barcode and enumchron Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All working as desired, QA scripts happy and no regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35026 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 [Bug 35026] Refactor addorderiso2709.pl to use object methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159429|0 |1 is obsolete| | Attachment #159430|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 160458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160458&action=edit Bug 33171: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder Some libraries would like to use the following item fields with the MarcItemFieldsToOrder system preference: * coded_location_qualifier * barcode * enumchron Test Plan: 1) Set up MarcItemFieldsToOrder, verify it is functioning 2) Test coded_location_qualifier, barcode, and enumchron 3) Note the fields are imported and set for the items Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 160459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160459&action=edit Bug 33171: Fix missing price when mapped from MarcItemFieldsToOrder This patch fixes an issue where the price is not passed to the UI when read from MarcItemFieldsToOrder. Test plan: 1) In Administration, copy and paste the following into MarcItemFieldsToOrder: quantity: 975$q budget_code: 975$h price: 975$p itype: 975$y coded_location_qualifier: 975$a barcode: 975$b enumchron: 975$c 2) Save 3) Navigate to Acquisitions and find a basket 4) Click Add to basket and select From a new file 5) Choose the file attached to this bug 6) Upload file and click Stage for import 7) Click Add staged files to basket once the job is finished 8) Check the box next to the record 9) The price should show 10.00 under Item record 1 10) coded location qualifier, barcode, enumchron should also have values as per the other commit on this bug 11) Save and import, the basket should not have a value of 0 as the price has been read correctly 12) Check the database, the newest item should have values for price, coded_location_qualifier, barcode and enumchron Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 24334 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Needs documenting --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement allows the release notes| |use of | |`coded_location_qualifier`, | |`barcode` and `enumchron` | |fields in the | |`MarcItemFieldsToOrder` | |preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/885 CC| |caroline.cyr-la-rose@inlibr | |o.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37316 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37316 [Bug 37316] Cannot add items to basket via file if barcodes not supplied -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37551 [Bug 37551] MarcFieldsToOrder price is overriding MarcItemFieldsToOrderPrice -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org