[Bug 34668] New: Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Bug ID: 34668 Summary: Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: shi-yao.wang@inLibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Add a modal popup when checking out items of a patron that has waiting holds available with a syspref to enable or disable the feature. Would make it more obvious than the simple display of "Holds waiting here" comment on top right of the checkout page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |shi-yao.wang@inLibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
confirm hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #1 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 155044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155044&action=edit Bug 34668: Add popup warn librarians of waiting holds when checking out When there are holds waiting for patrons, sometimes the librarian misses the "Holds waiting here" display. This patch adds a modal popup warning when checking out an item for a patron with waiting holds. Test plan: 1) find a user (user1) 2) find a biblio (biblio1) 3) add a hold for biblio1 to user1 (search biblio1 > Holds > find user1 > Place hold) 4) checkout biblio1 to another user if not already checked out and checkin through circulation page (not through the user page) 5) there should be a "Holds waiting here (1)" section added on user1 page 6) checkout any items that isn't the one on hold for user1 -> notice it just checks out as normal 7) apply patch and update database 8) go to administration > system preferences > switch "WaitingNotifyAtCheckout" to "Notify" 9) refresh page and redo step 6 -> notice there is now a modal to warn the librarian of a waiting hold click Ok to proceed with the checkout, click outside the modal to not do anything -- You are receiving this mail because: You are watching all bug changes.
confirm hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155044|0 |1 is obsolete| | --- Comment #2 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 155045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155045&action=edit Bug 34668: Add popup warn librarians of waiting holds when checking out When there are holds waiting for patrons, sometimes the librarian misses the "Holds waiting here" display. This patch adds a modal popup warning when checking out an item for a patron with waiting holds. Test plan: 1) find a user (user1) 2) find a biblio (biblio1) 3) add a hold for biblio1 to user1 (search biblio1 > Holds > find user1 > Place hold) 4) checkout biblio1 to another user if not already checked out and checkin through circulation page (not through the user page) 5) there should be a "Holds waiting here (1)" section added on user1 page 6) checkout any items that isn't the one on hold for user1 -> notice it just checks out as normal 7) apply patch and update database 8) go to administration > system preferences > switch "WaitingNotifyAtCheckout" to "Notify" 9) refresh page and redo step 6 -> notice there is now a modal to warn the librarian of a waiting hold click Ok to proceed with the checkout, click outside the modal to not do anything 10) additionnally, the popup shouldn't appear if we checkout any of user1's waiting hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- This is really interesting, and seems to work well. I wonder if we should include an option to check a box in the modal that says "Don't warn me again" which would suppress the warning for the current session? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #4 from Blou <philippe.blouin@inlibro.com> --- I think what would happen is that the clerks would hit it automatically (and blindly) after a while, especially those that were targeted by this library request. Considering each popup would be for a different user, with different books listed, this is always new information. Turning it off seems counterintuitive, in my personnal opinion. Humans, humans... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- I think is going to be useful and it seems to work well. Can you check these QA errors: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt FAIL filters missing_filter at line 967 ( waiting_holds_barcodes.push("[% b %]");) WARN circ/circulation.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 240, now: 244) For the perltidy warn maybe this is helpful: https://wiki.koha-community.org/wiki/Perltidy -- You are receiving this mail because: You are watching all bug changes.
confirm hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155045|0 |1 is obsolete| | --- Comment #6 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 155143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155143&action=edit Bug 34668: Add popup warn librarians of waiting holds when checking out When there are holds waiting for patrons, sometimes the librarian misses the "Holds waiting here" display. This patch adds a modal popup warning when checking out an item for a patron with waiting holds. Test plan: 1) find a user (user1) 2) find a biblio (biblio1) 3) add a hold for biblio1 to user1 (search biblio1 > Holds > find user1 > Place hold) 4) checkout biblio1 to another user if not already checked out and checkin through circulation page (not through the user page) 5) there should be a "Holds waiting here (1)" section added on user1 page 6) checkout any items that isn't the one on hold for user1 -> notice it just checks out as normal 7) apply patch and update database 8) go to administration > system preferences > switch "WaitingNotifyAtCheckout" to "Notify" 9) refresh page and redo step 6 -> notice there is now a modal to warn the librarian of a waiting hold click Ok to proceed with the checkout, click outside the modal to not do anything 10) additionnally, the popup shouldn't appear if we checkout any of user1's waiting hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- QA errors should be fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
confirm hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155143|0 |1 is obsolete| | --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 155188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155188&action=edit Bug 34668: Add popup warn librarians of waiting holds when checking out When there are holds waiting for patrons, sometimes the librarian misses the "Holds waiting here" display. This patch adds a modal popup warning when checking out an item for a patron with waiting holds. Test plan: 1) find a user (user1) 2) find a biblio (biblio1) 3) add a hold for biblio1 to user1 (search biblio1 > Holds > find user1 > Place hold) 4) checkout biblio1 to another user if not already checked out and checkin through circulation page (not through the user page) 5) there should be a "Holds waiting here (1)" section added on user1 page 6) checkout any items that isn't the one on hold for user1 -> notice it just checks out as normal 7) apply patch and update database 8) go to administration > system preferences > switch "WaitingNotifyAtCheckout" to "Notify" 9) refresh page and redo step 6 -> notice there is now a modal to warn the librarian of a waiting hold click Ok to proceed with the checkout, click outside the modal to not do anything 10) additionnally, the popup shouldn't appear if we checkout any of user1's waiting hold Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Rather than unbinding/rebinding events, could we have an action bound to submit on the form, and then display the modal or not as needed? That would be more in line with current code I believe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #10 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- (In reply to Nick Clemens from comment #9)
Rather than unbinding/rebinding events, could we have an action bound to submit on the form, and then display the modal or not as needed? That would be more in line with current code I believe
$('#circ-warnwaitingholds-modal .btn-primary').on('click',function() { $('#mainform').submit(); });
This is the action bound to (confirm) submit the usual checkout form from the modal. The modal display logic depends on what is written in the barcode input, it needs to display the modal if the barcode about to be checked out is not among waiting holds, else it will submit the form as usual. I currently do not see how this can be done without binding/unbinding events of the "Check out" button depending on the barcode input. Can I get more details on how to do what you suggest? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Shi Yao Wang from comment #10)
(In reply to Nick Clemens from comment #9) I currently do not see how this can be done without binding/unbinding events of the "Check out" button depending on the barcode input. Can I get more details on how to do what you suggest?
Something like this: $("#mainform").on('submit', function(){ if( $("#checkout_confirmed").length > 0 ){ return true; } if ( waiting_holds_barcodes.includes($('#barcode').val().trim()) ) { return true; } else { $('#circ-warnwaitingholds-modal').modal(); return false; } }); $("#circ-warnwaitingholds-modal").on('hidden.bs.modal',function(){ $("#mainform").append('<input type="hidden" id="checkout_confirmed" value=1>').submit(); }); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #12 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 156992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156992&action=edit Bug 34668: remove binding/unbinding event for one submit event -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Mia Kujala <mia.kujala@xamk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mia.kujala@xamk.fi --- Comment #13 from Mia Kujala <mia.kujala@xamk.fi> --- I tried to signoff: Popup is showing but clicking Ok doesn't proceed the checkout, only popup disappears. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156992|0 |1 is obsolete| | --- Comment #14 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 157243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157243&action=edit Bug 34668: remove binding/unbinding event for one submit event -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #15 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- (In reply to Mia Kujala from comment #13)
I tried to signoff: Popup is showing but clicking Ok doesn't proceed the checkout, only popup disappears.
Thank you for testing. It was indeed not proceeding with the checkout. It should be fixed now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #16 from Mia Kujala <mia.kujala@xamk.fi> --- Tested again. Now the popup is not showing but it proceed the checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #17 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- (In reply to Mia Kujala from comment #16)
Tested again. Now the popup is not showing but it proceed the checkout
The popup shows up on my end... is the syspref active? Also, the popup won't show if checking out an item waiting on hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157243|0 |1 is obsolete| | --- Comment #18 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 157312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157312&action=edit Bug 34668: remove binding/unbinding event for one submit event step 9) of previous patch is a bit different now, if we click outside of the modal it will proceed with the checkout instead of not doing anything -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #19 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- No new code changes, just changed the commit message. -- You are receiving this mail because: You are watching all bug changes.
confirm hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155188|0 |1 is obsolete| | --- Comment #20 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 157315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157315&action=edit Bug 34668: Add popup warn librarians of waiting holds when checking out When there are holds waiting for patrons, sometimes the librarian misses the "Holds waiting here" display. This patch adds a modal popup warning when checking out an item for a patron with waiting holds. Test plan: 1) find a user (user1) 2) find a biblio (biblio1) 3) add a hold for biblio1 to user1 (search biblio1 > Holds > find user1 > Place hold) 4) checkout biblio1 to another user if not already checked out and checkin through circulation page (not through the user page) 5) there should be a "Holds waiting here (1)" section added on user1 page 6) checkout any items that isn't the one on hold for user1 -> notice it just checks out as normal 7) apply patch and update database 8) go to administration > system preferences > switch "WaitingNotifyAtCheckout" to "Notify" 9) refresh page and redo step 6 -> notice there is now a modal to warn the librarian of a waiting hold click Ok to proceed with the checkout, click outside the modal to not do anything 10) additionnally, the popup shouldn't appear if we checkout any of user1's waiting hold Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Mia Kujala <mia.kujala@xamk.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157312|0 |1 is obsolete| | --- Comment #21 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 157316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157316&action=edit Bug 34668: remove binding/unbinding event for one submit event Signed-off-by: Mia Kujala <mia.kujala@xamk.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Mia Kujala <mia.kujala@xamk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #22 from Mia Kujala <mia.kujala@xamk.fi> --- Works as designed and described in the test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com --- Comment #23 from Kelly McElligott <kelly@bywatersolutions.com> --- My sandbox is not sending the sign off through- but I have tested and it works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Comment on attachment 157315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157315 Bug 34668: Add popup warn librarians of waiting holds when checking out Review of attachment 157315: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=34668&attachment=157315) ----------------------------------------------------------------- ::: circ/circulation.pl @@ +552,5 @@
+ #Check for waiting holds + my $waiting_holds = $patron->holds->search( { found => 'W', branchcode => $branch } ); + my @waiting_holds_barcodes = (); + while ( my $hold = $waiting_holds->next ) { + push( @waiting_holds_barcodes, $hold->item->barcode );
There is no need to make a list of the barcodes, just pass the entire waiting_holds rs to the template and let it loop over them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #25 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 158359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158359&action=edit Bug 34668: pass whole waiting_holds rs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
confirm hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157315|0 |1 is obsolete| | --- Comment #26 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 158528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158528&action=edit Bug 34668: Add popup warn librarians of waiting holds when checking out When there are holds waiting for patrons, sometimes the librarian misses the "Holds waiting here" display. This patch adds a modal popup warning when checking out an item for a patron with waiting holds. Test plan: 1) find a user (user1) 2) find a biblio (biblio1) 3) add a hold for biblio1 to user1 (search biblio1 > Holds > find user1 > Place hold) 4) checkout biblio1 to another user if not already checked out and checkin through circulation page (not through the user page) 5) there should be a "Holds waiting here (1)" section added on user1 page 6) checkout any items that isn't the one on hold for user1 -> notice it just checks out as normal 7) apply patch and update database 8) go to administration > system preferences > switch "WaitingNotifyAtCheckout" to "Notify" 9) refresh page and redo step 6 -> notice there is now a modal to warn the librarian of a waiting hold click Ok to proceed with the checkout, click outside the modal to not do anything 10) additionnally, the popup shouldn't appear if we checkout any of user1's waiting hold Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Mia Kujala <mia.kujala@xamk.fi> Signed-off-by: Kelly <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157316|0 |1 is obsolete| | --- Comment #27 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 158529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158529&action=edit Bug 34668: remove binding/unbinding event for one submit event Signed-off-by: Mia Kujala <mia.kujala@xamk.fi> Signed-off-by: Kelly <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158359|0 |1 is obsolete| | --- Comment #28 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 158530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158530&action=edit Bug 34668: pass whole waiting_holds rs Signed-off-by: Kelly <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #29 from Lucas Gass <lucas@bywatersolutions.com> --- Working as described. QA script is mostly happy, 1 issue with file permissions that I am fixing in a follow-up. The rest of the code looks good. DBUpdate looks good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
confirm hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158528|0 |1 is obsolete| | --- Comment #30 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 160673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160673&action=edit Bug 34668: Add popup warn librarians of waiting holds when checking out When there are holds waiting for patrons, sometimes the librarian misses the "Holds waiting here" display. This patch adds a modal popup warning when checking out an item for a patron with waiting holds. Test plan: 1) find a user (user1) 2) find a biblio (biblio1) 3) add a hold for biblio1 to user1 (search biblio1 > Holds > find user1 > Place hold) 4) checkout biblio1 to another user if not already checked out and checkin through circulation page (not through the user page) 5) there should be a "Holds waiting here (1)" section added on user1 page 6) checkout any items that isn't the one on hold for user1 -> notice it just checks out as normal 7) apply patch and update database 8) go to administration > system preferences > switch "WaitingNotifyAtCheckout" to "Notify" 9) refresh page and redo step 6 -> notice there is now a modal to warn the librarian of a waiting hold click Ok to proceed with the checkout, click outside the modal to not do anything 10) additionnally, the popup shouldn't appear if we checkout any of user1's waiting hold Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Mia Kujala <mia.kujala@xamk.fi> Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158529|0 |1 is obsolete| | --- Comment #31 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 160674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160674&action=edit Bug 34668: remove binding/unbinding event for one submit event Signed-off-by: Mia Kujala <mia.kujala@xamk.fi> Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158530|0 |1 is obsolete| | --- Comment #32 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 160675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160675&action=edit Bug 34668: pass whole waiting_holds rs Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #33 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 160676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160676&action=edit Bug 34668: (QA follow-up) Change file permission Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add syspref to popup warn |Notify staff with a pop-up |librarians of waiting holds |about waiting holds for a |for the patrons whose items |patron when checking out |they are checking out | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed Status|Pushed to master |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #35 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/866 Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED Keywords|release-notes-needed | Resolution|--- |FIXED Text to go in the| |This enhancement adds a new release notes| |system preference, | |WaitingNotifyAtCheckout, | |that generates a pop-up in | |the circulation module | |alerting staff that the | |patron they are checking | |out items to also has holds | |waiting for them. --- Comment #36 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I feel like this could get very annoying if the pop-up appears after each scan...? If I check out 5 items to a single patron, the pop-up appears 5 times and I have to click 'OK' after every checkout. I guess it would force me to go get the fbook and check it out to get the pop-up out of my face, but it would definitely get on my nerves. For now, I'll add a note in the manual to warn about this behaviour. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Saija Pyhtilä <saija.pyhtila@metropolia.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- CC| |saija.pyhtila@metropolia.fi --- Comment #37 from Saija Pyhtilä <saija.pyhtila@metropolia.fi> --- Tested this test plan: If there is item1 waiting for user A and other available item2 connected to same biblio is going to be checked out by user B, also user B gets this pop-up "this patron has waiting holds" even if the user B doesn't have any items to be picked up. So this setting is maybe not functioning as it should: so all users get the notification when checking out same book title (different items) until user A picks up and check outs the hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37199 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37199 [Bug 37199] Incorrect "waiting holds" notification for staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |slavashishkin@gmail.com --- Comment #38 from Slava Shishkin <slavashishkin@gmail.com> --- A new ticket and a fix for it Bug 37199 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37199, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37055 Resolution|--- |FIXED CC| |david@davidnind.com Status|REOPENED |RESOLVED --- Comment #39 from David Nind <david@davidnind.com> --- (In reply to Saija Pyhtilä from comment #37)
Tested this test plan: If there is item1 waiting for user A and other available item2 connected to same biblio is going to be checked out by user B, also user B gets this pop-up "this patron has waiting holds" even if the user B doesn't have any items to be picked up.
So this setting is maybe not functioning as it should: so all users get the notification when checking out same book title (different items) until user A picks up and check outs the hold.
(In reply to Slava Shishkin from comment #38)
A new ticket and a fix for it Bug 37199
Thanks for reporting issues with this bug, and a link to the bug. Normally, if a bug is pushed to main and there are follow-up issues, we open another bug and link to it - instead of reopening the existing bug. A fix for this issue is in bug 37055, which is signed off and is waiting for quality assurance. Thanks again! David Nind -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Koha collecto <koha@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@collecto.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37055 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37055 [Bug 37055] WaitingNotifyAtCheckout should only trigger on patrons with waiting holds -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org