https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42141 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |bibliothek@th-wildau.de |ity.org | Patch complexity|--- |Small patch Status|NEW |Needs Signoff --- Comment #2 from Jan Kissig <bibliothek@th-wildau.de> --- Bug 42141: Fix Save and show/list/edit button on Vue SIP2 config This patch fixes the behavior of the Save (Save and list, Save and continue editing, Save and show) button which is controlled via useBaseResource.navigationOnFormSave on Accounts, Institutions and System preference overrides in Administration -> Self-service circulation (SIP2) To test: a) go to Administration -> Self-service circulation (SIP2) b) create one of the given resources (institution, account, system preference override) and fill out mandatory fields c) click either Save or Save and continue editing or Save and show d) check that you always end up on the list. e) apply patch and run 'yarn js:build' , reload your browser f) repeat b) and c) g) check that the desired view is now shown - show the edited/created resource - list all created resources - continue editing the resource -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42141 --- Comment #3 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 195696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195696&action=edit Bug 42141: Fix Save and show/list/edit button on Vue SIP2 config This patch fixes the behavior of the Save (Save and list, Save and continue editing, Save and show) button which is controlled via useBaseResource.navigationOnFormSave on Accounts, Institutions and System preference overrides in Administration -> Self-service circulation (SIP2) To test: a) go to Administration -> Self-service circulation (SIP2) b) create one of the given resources (institution, account, system preference override) and fill out mandatory fields c) click either Save or Save and continue editing or Save and show d) check that you always end up on the list. e) apply patch and run 'yarn js:build' , reload your browser f) repeat b) and c) g) check that the desired view is now shown - show the edited/created resource - list all created resources - continue editing the resource -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42141 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42141 --- Comment #6 from David Nind <david@davidnind.com> --- (In reply to Jan Kissig from comment #5)

With the patch: 1. Institutions: - default is Save (which will go to the list) - 'Save and continue' and 'Save and show' should work now as described

"Save": returns to the list "Save and continue editing": stays on the form and lets you continue editing "Save and show": shows the institution details (with Edit and Delete menu options) (note: "Save and show" not used before the patch, and not used in the ERM module)

2- Account: - default Save (which will go to show the resource) - the other options 'Save and continue editing' and 'save and return to list' should work as described now.

"Save": shows the account details (with Edit and Delete menu options) (note: works differently from Institutions, which returns to the table) "Save and continue editing": stays on the form and lets you continue editing "Save and return to list": saves any changes and returns to the list

3. System pref override: - default is Save (which will open the list) - the other options 'Save and continue' and 'Save and show' should work as describes.

"Save": returns to the list "Save and continue editing": stays on the form and lets you continue editing "Save and show": shows the system preference override details (with Edit and Delete menu options) (note: "Save and show" not used before the patch, and not used in the ERM module) Thanks Jan! On retesting, have shown results above (applied patch, yarn build, restart_all, fresh browser). Maybe there was something wrong with my setup (I shut down KTD, updated everything, restarted KTD, and repeated everything). I don't think this bug should introduce "inconsistencies" for SIP, when compared to the ERM module: - Save: For ERM, saves and shows details vs SIP where there are two different behavours (stays on the page, and doesn't return to the list x 1 occurrence, vs 2 occurrences where they return to the list) - Save and show: not used by the ERM mdoule, this is the "Save" behavour (also not used before this patch is applied) For most of the ERM module (excluding eUsage forms): - Save: saves and shows details (stays on the page, and doesn't return to the list) - Save and continue editing: stays on the form and lets you continue editing - Save and return to list: saves any changes and returns to the list Because of the inconsistencies, I left as Failed QA. Hope this makes sense (have been looking at this for too long!). David -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42141 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 [Bug 37893] Migrate some SIP configuration into the staff interface -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42141 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Jan Kissig <bibliothek@th-wildau.de> ---

... I don't think this bug should introduce "inconsistencies" for SIP, when compared to the ERM module: - Save: For ERM, saves and shows details vs SIP where there are two different behavours (stays on the page, and doesn't return to the list x 1 occurrence, vs 2 occurrences where they return to the list) - Save and show: not used by the ERM mdoule, this is the "Save" behavour (also not used before this patch is applied)

For most of the ERM module (excluding eUsage forms): - Save: saves and shows details (stays on the page, and doesn't return to the list) - Save and continue editing: stays on the form and lets you continue editing - Save and return to list: saves any changes and returns to the list

Because of the inconsistencies, I left as Failed QA.

Hope this makes sense (have been looking at this for too long!).

David

Hi David, I can understand the little confusion with the action behind the 'Save' button as it could mean either 'Save and show', 'Save and continue editing' or 'Save an show list' but is always labeled 'Save', though the alternative save buttons behind the drop down have their actions clearly labeled. As for the different behaviors introduced in this patch: With bug 40191 a new property (navigationOnFormSave) gives the developer exactly this option to control which action should be taken on the default 'Save' click. There is also some info in the coding guidelines now: https://wiki.koha-community.org/wiki/Coding_Guidelines#JS18:_Vue_resource_de... As in sip2 the configurations for 'Institutions' and 'Syspref overrides' are not so complicated (having only a few options to be set) I choose to return to the list on after saving. But for the 'Accounts', with its many options to be set, I thought it would be nice to see what I just entered after save. As this patch fixes the functionality behind the button I would remove the FQA and set it SO. The default action behind that 'Save' button can be changed on a different bug -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42141 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195696|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42141 --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> ---

From a functional standpoint this is PQA to me.

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42141 --- Comment #10 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.