[Bug 42666] New: Next button in Item types and Patron categories does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 Bug ID: 42666 Summary: Next button in Item types and Patron categories does not work Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: chris.mathevet@inLibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The "Next" button in "Patron categories" and "Item types" in the Administration panel does not work. In addition, it shows "Showing 1 to 010 of 11 entries" instead of "Showing 1 to 10 of 11 entries" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 Chris Mathevet <chris.mathevet@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |chris.mathevet@inLibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 Chris Mathevet <chris.mathevet@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris.mathevet@inLibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 --- Comment #1 from Chris Mathevet <chris.mathevet@inLibro.com> --- Created attachment 199480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199480&action=edit Bug 42666: Parse kohaTable pageLength setting to int Test plan : 01 - Go to Administration > Item types 02 - You need to have more than 10 item types, add some if needed 03 - Observe "Showing 1 to 010 of XX" on top of the table 04 - Click on "next" button at the bottom of the table 05 - Nothing happens 06 - Go to Administration > Patron categories 07 - You need to have more than 20 patron categories, add some if needed 08 - Observe "Showing 1 to 020 of XX" on top of the table 09 - Click on "next" button at the bottom of the table 10 - Nothing happens 11 - Apply patch 12 - Repeat 1-4 and 6-9, observe that the leading 0 is gone, and that the "next" button works -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 Chris Mathevet <chris.mathevet@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 Chris Mathevet <chris.mathevet@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- In Firefox the JS error is: Uncaught TypeError: can't access property "nTr", p is undefined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |anneli.osterman@koha-suomi. | |fi --- Comment #3 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I tested this problem in a sandbox and could not replicate the problem with the Patron categories page (numbers were correct and the Next button worked). But it did appear in Item types page. I applied the patch but it did not fix the '1 to 010 of x entries' or the Next button in Item types page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Did you track down what caused this regression? It works on 25.11.00 so I guess it's coming from bug 40816. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 199515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199515&action=edit Bug 42666: Add a Cypress test Patch from commit 8defb6c -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- I don't think the second part is necessary + if(isNaN(settings["pageLength"])){ + settings["pageLength"] = dataTablesDefaults.pageLength; + } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Anneli Österman from comment #3)
I tested this problem in a sandbox and could not replicate the problem with the Patron categories page (numbers were correct and the Next button worked). But it did appear in Item types page.
I applied the patch but it did not fix the '1 to 010 of x entries' or the Next button in Item types page.
I did see the problem on the item type page, but then now I do no longer see it. It's not clear to me what's causing the problem... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 --- Comment #8 from Chris Mathevet <chris.mathevet@inLibro.com> --- (In reply to Jonathan Druart from comment #4)
Did you track down what caused this regression?
It works on 25.11.00 so I guess it's coming from bug 40816.
I was able to reproduce this bug on 25.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 --- Comment #9 from Chris Mathevet <chris.mathevet@inLibro.com> --- (In reply to Jonathan Druart from comment #7)
(In reply to Anneli Österman from comment #3)
I tested this problem in a sandbox and could not replicate the problem with the Patron categories page (numbers were correct and the Next button worked). But it did appear in Item types page.
I applied the patch but it did not fix the '1 to 010 of x entries' or the Next button in Item types page.
I did see the problem on the item type page, but then now I do no longer see it. It's not clear to me what's causing the problem...
For some reason, pageLength is sometimes returned as a string. The "end" table variable is calculated by adding the start index (here 0) and pageLength (here "10"). As a result, "010" is assigned to the end variable instead of 10. This causes the message to display as "Showing 1 to 010..." and also affects page navigation. I also forgot to mention in the test plan that you should clear your browser's local storage, since it stores some information such as the table length. I will update it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 Chris Mathevet <chris.mathevet@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 Chris Mathevet <chris.mathevet@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199480|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 --- Comment #10 from Chris Mathevet <chris.mathevet@inLibro.com> --- Created attachment 199516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199516&action=edit Bug 42666: Parse kohaTable pageLength setting to int Test plan : 01 - Clear your browser's local storage 02 - Go to Administration > Item types 03- You need to have more than 10 item types, add some if needed 04 - Observe "Showing 1 to 010 of XX" on top of the table 05 - Click on "next" button at the bottom of the table 06 - Nothing happens 07 - Go to Administration > Patron categories 08 - You need to have more than 20 patron categories, add some if needed 09 - Observe "Showing 1 to 020 of XX" on top of the table 10 - Click on "next" button at the bottom of the table 11 - Nothing happens 12 - Apply patch 13 - Clear your browser's local storage 14 - Repeat 2-5 and 7-10, observe that the leading 0 is gone, and that the "next" button works -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #11 from David Nind <david@davidnind.com> --- I'm seeing inconsistent behavour with my testing (using both Chromium and Firefox browsers) BEFORE applying the patch, that doesn't match with the test plan: 1. Start with a fresh browser (cached/history/etc all cleared). 2. Item types: add extra item types, next button doesn't work (as per the test plan) 3. Patron categories: add extra patron categories ==> next button works 4. Now not showing 1 to 010 of X entries (or 020) for both patron categories and item types. 5. Clear browser caches. 6. Pagination continues to works as expected! (That is, next works, no 010 or 020.) So I can't reliably replicate the problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199515|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 199524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199524&action=edit Bug 42666: Add a Cypress test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 199525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199525&action=edit Bug 42666: OPAC counterpart Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- To recreate the problem you need to flush_memcached first, then reload plack. Finally you can go to admin/itemtypes.pl and see the "010" and the broken "next" link. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199516|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199524|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199525|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 199529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199529&action=edit Bug 42666: Parse kohaTable pageLength setting to int Test plan : 01 - Clear your browser's local storage 02 - Go to Administration > Item types 03- You need to have more than 10 item types, add some if needed 04 - Observe "Showing 1 to 010 of XX" on top of the table 05 - Click on "next" button at the bottom of the table 06 - Nothing happens 07 - Go to Administration > Patron categories 08 - You need to have more than 20 patron categories, add some if needed 09 - Observe "Showing 1 to 020 of XX" on top of the table 10 - Click on "next" button at the bottom of the table 11 - Nothing happens 12 - Apply patch 13 - Clear your browser's local storage 14 - Repeat 2-5 and 7-10, observe that the leading 0 is gone, and that the "next" button works Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 199530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199530&action=edit Bug 42666: Add a Cypress test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 199531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199531&action=edit Bug 42666: OPAC counterpart Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199529|0 |1 is obsolete| | Attachment #199530|0 |1 is obsolete| | Attachment #199531|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200733&action=edit Bug 42666: Parse kohaTable pageLength setting to int Test plan : 01 - Clear your browser's local storage 02 - Go to Administration > Item types 03- You need to have more than 10 item types, add some if needed 04 - Observe "Showing 1 to 010 of XX" on top of the table 05 - Click on "next" button at the bottom of the table 06 - Nothing happens 07 - Go to Administration > Patron categories 08 - You need to have more than 20 patron categories, add some if needed 09 - Observe "Showing 1 to 020 of XX" on top of the table 10 - Click on "next" button at the bottom of the table 11 - Nothing happens 12 - Apply patch 13 - Clear your browser's local storage 14 - Repeat 2-5 and 7-10, observe that the leading 0 is gone, and that the "next" button works Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200734&action=edit Bug 42666: Add a Cypress test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200735&action=edit Bug 42666: OPAC counterpart Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 --- Comment #21 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 --- Comment #22 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Created attachment 200907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200907&action=edit Bug 42666: (RM follow-up): Tidy datatables.js prove xt/js_tidy.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 --- Comment #23 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Pedro Amorim (ammopt) from comment #22)
Created attachment 200907 [details] [review] Bug 42666: (RM follow-up): Tidy datatables.js
prove xt/js_tidy.t
Oops, sorry! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42666 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Version(s)|26.11.00,26.05.02 |26.11.00,26.05.02,25.11.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #25 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 25.11.x for 25.11.08 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org