[Bug 9046] New: Items are not exported with the tools/export.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Priority: P5 - low Change sponsored?: --- Bug ID: 9046 Assignee: gmcharlt@gmail.com Summary: Items are not exported with the tools/export.pl Severity: major Classification: Unclassified OS: All Reporter: jonathan.druart@biblibre.com Hardware: All Status: NEW Version: 3.10 Component: Tools Product: Koha Bug 7986 introduced an issues. Items are not exported at least when you use the script tools/export.pl from a command line and you want to export biblios with items. This patch could have a higher severity level (blocker). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13366&action=edit Bug 9046: FIX wrong test on an arrayref instead of an array EmbedItemsInMarcBiblio does not embed items when the itemnumbers param is given. That breaks the export tools (used from commandline). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13366|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 13369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13369&action=edit Bug 9046: FIX wrong test on an arrayref instead of an array EmbedItemsInMarcBiblio does not embed items when the itemnumbers param is given. That breaks the export tools (used from commandline). Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13389&action=edit Bug 9046: Followup FIX perl v.10 raises an error if itemnumbers if undefined If the itemnumbers parameter is undef, perl raises an error : "Can't use an undefined value as an ARRAY reference" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13389|0 |1 is obsolete| | --- Comment #4 from Mason James <mtj@kohaaloha.com> --- Created attachment 13413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13413&action=edit Bug 9046: Followup FIX perl v.10 raises an error if itemnumbers if undefined If the itemnumbers parameter is undef, perl raises an error : "Can't use an undefined value as an ARRAY reference" Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- I increase the severity of this patch. Without this patch, the export tools (via ui) does not work too (items are not added to the export file). To test : tools/export.pl and export with and without the items. In the current master, you will get the same file (without items). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * 2 lines patch, fixing a bug * nothing changed in string passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 21378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21378&action=edit [3.8.x] FIX wrong test on an arrayref instead of an array Backport of patch 1 to 3.8.18, which should apply nicely to 3.8.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 21379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21379&action=edit [3.8.x] Followup FIX perl v.10 raises an error if itemnumbers if undefined Backport of patch 2 to 3.8.18, which should apply nicely to 3.8.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |mtompset@hotmail.com Version|3.10 |3.8 Resolution|FIXED |--- --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- This is already resolved in 3.10.x and higher, but the 3.8.x patches are back ports in need of testing, QA'ing, and getting in 3.8.x. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Just apply the 3.8.x patches to 3.8.x for testing. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com, | |chrish@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #14 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13369|0 |1 is obsolete| | Attachment #21378|0 |1 is obsolete| | --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 21568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21568&action=edit Bug 9046: FIX wrong test on an arrayref instead of an array EmbedItemsInMarcBiblio does not embed items when the itemnumbers param is given. That breaks the export tools (used from commandline). Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13413|0 |1 is obsolete| | Attachment #21379|0 |1 is obsolete| | --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 21569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21569&action=edit Bug 9046: Followup FIX perl v.10 raises an error if itemnumbers if undefined If the itemnumbers parameter is undef, perl raises an error : "Can't use an undefined value as an ARRAY reference" Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> --- Signed off the 3.8.x patches, probably can skip QA as they have been in master for a while, but up to the RMaint -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #18 from Paul Poulain <paul.poulain@biblibre.com> --- passing QA, I agree with chris last comment: the current patch is for 3.8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- ping Kyle, it seems the next action if for you :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 3.8.x! Will be in v3.08.24 Kyle -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable CC| |gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org