[Bug 8769] New: Allow SIP2 return backdating
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Priority: P5 - low Change sponsored?: --- Bug ID: 8769 CC: colin.campbell@ptfs-europe.com Assignee: koha-bugs@lists.koha-community.org Summary: Allow SIP2 return backdating Severity: enhancement Classification: Unclassified OS: All Reporter: kyle@bywatersolutions.com Hardware: All Status: NEW Version: master Component: SIP2 Product: Koha Currently Koha's SIP server ignores the return date part of an 09 ( aka CHECKIN ) message. Koha should backdate a return, and remove fine accordingly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12193&action=edit Bug 8769 - WIP - Allow SIP2 return backdating -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12193|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12811&action=edit Bug 8769 - Allow SIP2 return backdating Patch based on code by Scott Kushner <skushner@mplmain.mtpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12811|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12812&action=edit Bug 8769 - Allow SIP2 return backdating Patch based on code by Scott Kushner <skushner@mplmain.mtpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12812|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12813&action=edit Bug 8769 - Allow SIP2 return backdating -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- It works. Could you edit C4::Circulation::AddReturn POD to document the new return_date parameter? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12813|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15248&action=edit Bug 8769 - Allow SIP2 return backdating -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15248|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19999&action=edit Bug 8769 - Allow SIP2 return backdating Currently Koha's SIP server ignores the return date part of an 09 ( aka CHECKIN ) message. Koha should backdate a return, and remove fines accordingly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19999|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20000&action=edit Bug 8769 - Allow SIP2 return backdating Currently Koha's SIP server ignores the return date part of an 09 ( aka CHECKIN ) message. Koha should backdate a return, and remove fines accordingly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10694 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10694 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #9 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20000|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 21942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21942&action=edit Bug 8769 - Allow SIP2 return backdating Currently Koha's SIP server ignores the return date part of an 09 ( aka CHECKIN ) message. Koha should backdate a return, and remove fines accordingly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2013-09-29 00:00:00 |2013-10-30 last check this| | --- Comment #11 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21942|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23698&action=edit Bug 8769 - Allow SIP2 return backdating Currently Koha's SIP server ignores the return date part of an 09 ( aka CHECKIN ) message. Koha should backdate a return, and remove fines accordingly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10694 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Petter Goksøyr Åsen <boutrosboutrosboutros@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |boutrosboutrosboutros@gmail | |.com --- Comment #13 from Petter Goksøyr Åsen <boutrosboutrosboutros@gmail.com> --- I'd like to test this, can you rebase? Thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |dpavlin@rot13.org --- Comment #14 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Applying: Bug 8769 - Allow SIP2 return backdating fatal: sha1 information is lacking or useless (C4/Circulation.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 8769 - Allow SIP2 return backdating -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23698|0 |1 is obsolete| | --- Comment #15 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 26753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26753&action=edit Bug 8769 - Allow SIP2 return backdating Currently Koha's SIP server ignores the return date part of an 09 ( aka CHECKIN ) message. Koha should backdate a return, and remove fines accordingly. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Works as notified, second date field in SIP checkin (return date) is used as return date. Return shows up in history with correct date. Comments: - patron is fined if return date is before issue date, but that is largely irrelevant anyway. - dependent bug 10694 is marked as Failed QA but seems to have passed? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off CC| |benjamin.rokseth@kul.oslo.k | |ommune.no -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 --- Comment #16 from Colin Campbell <colin.campbell@ptfs-europe.com> --- A minor issue with the patch as stands. It shouldnt unnecessarily import Koha::DateUtils into ILS/Transaction/CheckIn.pm. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27465&action=edit Bug 8769 [QA Followup] - Remove unnecessary module import -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26753|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 27466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27466&action=edit [PASSED QA] Bug 8769 - Allow SIP2 return backdating Currently Koha's SIP server ignores the return date part of an 09 ( aka CHECKIN ) message. Koha should backdate a return, and remove fines accordingly. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Works as notified, second date field in SIP checkin (return date) is used as return date. Return shows up in history with correct date. Comments: - patron is fined if return date is before issue date, but that is largely irrelevant anyway. - dependent bug 10694 is marked as Failed QA but seems to have passed? Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27465|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 27467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27467&action=edit [PASSED QA] Bug 8769 - (QA Followup) Remove unnecessary module import Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This patch is good now, happy to pass qa. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 --- Comment #21 from Galen Charlton <gmcharlt@gmail.com> --- Comment on attachment 27466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27466 [PASSED QA] Bug 8769 - Allow SIP2 return backdating Review of attachment 27466: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8769&attachment=27466) ----------------------------------------------------------------- ::: C4/Circulation.pm @@ +1780,4 @@
}
# case of a return of document (deal with issues and holdingbranch) + my $today = dt_from_string( $return_date, 'iso' );
This makes me nervous. Besides the comments that Colin made about this change in bug 10694, a variable named $today that doesn't necessarily contain today's date is ... confusing. Also, it is not clear to be why this would be part of the SIP2 change. Can you explain the purpose of this line? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27944&action=edit Bug 8769 - (QA Followup) Rename $today to $return_date_dt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27944|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27945&action=edit Bug 8769 - (QA Followup) Rename $today to $return_date_dt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27945|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27946&action=edit Bug 8769 - (QA Followup) Undo change to value of $today -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Galen Charlton from comment #21)
Comment on attachment 27466 [details] [review] [PASSED QA] Bug 8769 - Allow SIP2 return backdating
Review of attachment 27466 [details] [review]: -----------------------------------------------------------------
::: C4/Circulation.pm @@ +1780,4 @@
}
# case of a return of document (deal with issues and holdingbranch) + my $today = dt_from_string( $return_date, 'iso' );
This makes me nervous. Besides the comments that Colin made about this change in bug 10694, a variable named $today that doesn't necessarily contain today's date is ... confusing. Also, it is not clear to be why this would be part of the SIP2 change.
Can you explain the purpose of this line?
After some examination, I have concluded that this change serves no useful purpose and only causes code obfuscation. I have attached a followup to revert that line of code. I believe the change is vestigial from a time before this feature was dependent on bug 10694. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #26 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org