[Bug 3730] New: Wrong ISO 639-2 Language Code for Portuguese in database
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3730 Summary: Wrong ISO 639-2 Language Code for Portuguese in database Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: critical Priority: P5 Component: Database AssignedTo: gmcharlt@gmail.com ReportedBy: ricmarques@spamcop.net Estimated Hours: 0.0 Change sponsored?: --- For 3.0.x head of the Git branch, the ISO 639-2 Language Code for Portuguese in Koha database is wrong. Specifically, in the table "language_rfc4646_to_iso639", when the field "rfc4646_subtag" has the value "pt", the field "iso639_2_code" should have the value of "por" and NOT the current one of "pol" ("pol" refers to "Polish" as correctly also appears for the code "pl", in the row above the "pt" one). In my test setups, this showed some serious sequences for people that choose the Portuguese language in the Web Installer, namely: - very weird look of Staff client with missing Header and Footer, that renders the Staff client unusable - Portuguese translation apparently not getting updated for the OPAC (for people that do an Upgrade from a previous version) I prepared a patch to correct this for the 3.0.x branch (I have tested it locally and it seems to be working fine). I do NOT have a database set for the Master branch, so I probably won't be able to test a patch for that branch. So, it would be nice if someone could write a similar patch for the master branch (or else, ask me to submit it even untested and then test it, before committing it to koha.org git master branch) REFERENCE: ISO 639-2 Language Code List(Library of Congress) http://www.loc.gov/standards/iso639-2/php/code_list.php -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3730 Ricardo Dias Marques <ricmarques@spamcop.net> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|gmcharlt@gmail.com |ricmarques@spamcop.net -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3730 --- Comment #1 from Ricardo Dias Marques <ricmarques@spamcop.net> 2009-10-23 20:27:57 --- Created an attachment (id=1230) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1230) Fixes the "iso639_2_code" value in "language_rfc4646_to_iso639" for Portuguese Patch sent through git send-email The patch updates the "subtag_registry.sql" files, "kohaversion.pl" and "updatedatabase.pl". The fix, as described, was to replace, in the table "language_rfc4646_to_iso639", the "iso639_2_code" for Portuguese. The correct value of "iso639_2_code", for the "rfc4646_subtag" value of "pt", is "por" and NOT "pol" as it appeared ("pol" refers to Polish, that has the "rfc4646_subtag" value of "pl"). -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3730 Ricardo Dias Marques <ricmarques@spamcop.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3730 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2009-11-15 07:58:04 --- Created an attachment (id=1244) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1244) Fix for Bug 3730 - Wrong ISO 639-2 Language Code for Portuguese in database Fix for: Bug 3730 - Wrong ISO 639-2 Language Code for Portuguese in database http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3730 For 3.0.x head of the Git branch, the ISO 639-2 Language Code for Portuguese in Koha database is wrong. Specifically, in the table "language_rfc4646_to_iso639", when the field "rfc4646_subtag" has the value "pt", the field "iso639_2_code" should have the value of "por" and NOT the current one of "pol" ("pol" refers to "Polish" as correctly also appears for the code "pl", in the row above the "pt" one). In my test setups, this showed some serious sequences for people that choose the Portuguese language in the Web Installer, namely: - very weird look of Staff client with missing Header and Footer, that renders the Staff client unusable - Portuguese translation apparently not getting updated for the OPAC (for people that do an Upgrade from a previous version) This patch is for the 3.0.x branch (I tested it with that branch). For the master branch, I don't have a database setup to create and test a similar patch but Chris Cormack nicely volunteered to do that. Thanks Chris! -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3730 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com Status|NEW |ASSIGNED --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> 2010-02-10 17:05:42 --- Fix now in HEAD as DBrev 3.01.00.117. Please test and close. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3730 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> 2010-04-30 12:27:52 --- Closing; patched in master and 3.0.x; no response from bug submitter; assumed fixed; feel free to reopen if not. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠kohaorg.ec2.liblime.com