[Bug 37732] New: dialog message not styled on admin/cities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37732 Bug ID: 37732 Summary: dialog message not styled on admin/cities Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 35402 https://snipboard.io/gTOlck.jpg Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37732 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Same on admin/categories with "Patron category updated successfully." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37732 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- All of these pages send the dialog class from the script instead of setting it in the template, so each one needs to be adapted to send the classes for Bootstrap 5. acqui/basket.pl acqui/vendor_issues.pl admin/authorised_values.pl admin/authtypes.pl admin/biblio_framework.pl admin/branches.pl admin/categories.pl admin/cities.pl admin/credit_types.pl admin/currency.pl admin/debit_types.pl admin/desks.pl admin/identity_providers.pl admin/ill_batch_statuses.pl admin/itemtypes.pl admin/restrictions.pl admin/searchengine/elasticsearch/mappings.pl admin/smtp_servers.pl circ/pendingreserves.pl opac/opac-shelves.pl svc/letters/preview tools/additional-contents.pl tools/csv-profiles.pl tools/export.pl tools/quotes.pl virtualshelves/shelves.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37732 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|dialog message not styled |Update templates to use |on admin/cities |Bootstrap styles when alert | |class comes from the perl | |script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37732 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37732 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170913&action=edit Bug 37732: Update templates to use Bootstrap styles when alert class comes from the perl script Many pages can have alerts that get their style from a variable passed by the script, e.g.: push @messages, { type => 'message', code => 'success_on_update' }; Rather than change these to match Bootstrap 5 styles, I propose we add a copy of the existing Bootstrap style using the existing vocabulary: message -> info alert -> warning error -> danger To test, apply the patch and rebuild CSS for the staff interface and OPAC: (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - Clear your browser cache if necessary. - Navigate to pages which have been updated by this patch. Many pages will implement this kind of alert after saving an edit, especially administration pages, e.g. Administration -> Libraries -> Edit library -> Save. - You can test the various alert classes by adding this HTML to IntranetMainUserBlock and OpacMainUserBlock and viewing the staff interface and OPAC main pages.: <div class="alert alert-danger">A standard Bootstrap danger alert with <a href="#" class="alert-link">an example link</a>.</div> <div class="alert alert-warning">A standard Bootstrap warning alert with <a href="#" class="alert-link">an example link</a>.</div> <div class="alert alert-info">A standard Bootstrap info alert with <a href="#" class="alert-link">an example link</a>.</div> <div class="alert alert-error">A Koha error alert with <a href="#" class="alert-link">an example link</a>.</div> <div class="alert alert-alert">A Koha alert alert with <a href="#" class="alert-link">an example link</a>.</div> <div class="alert alert-message">A Koha info alert with <a href="#" class="alert-link">an example link</a>.</div> Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37732 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170913|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170968&action=edit Bug 37732: Update templates to use Bootstrap styles when alert class comes from the perl script Many pages can have alerts that get their style from a variable passed by the script, e.g.: push @messages, { type => 'message', code => 'success_on_update' }; Rather than change these to match Bootstrap 5 styles, I propose we add a copy of the existing Bootstrap style using the existing vocabulary: message -> info alert -> warning error -> danger To test, apply the patch and rebuild CSS for the staff interface and OPAC: (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - Clear your browser cache if necessary. - Navigate to pages which have been updated by this patch. Many pages will implement this kind of alert after saving an edit, especially administration pages, e.g. Administration -> Libraries -> Edit library -> Save. - You can test the various alert classes by adding this HTML to IntranetMainUserBlock and OpacMainUserBlock and viewing the staff interface and OPAC main pages.: <div class="alert alert-danger">A standard Bootstrap danger alert with <a href="#" class="alert-link">an example link</a>.</div> <div class="alert alert-warning">A standard Bootstrap warning alert with <a href="#" class="alert-link">an example link</a>.</div> <div class="alert alert-info">A standard Bootstrap info alert with <a href="#" class="alert-link">an example link</a>.</div> <div class="alert alert-error">A Koha error alert with <a href="#" class="alert-link">an example link</a>.</div> <div class="alert alert-alert">A Koha alert alert with <a href="#" class="alert-link">an example link</a>.</div> <div class="alert alert-message">A Koha info alert with <a href="#" class="alert-link">an example link</a>.</div> Sponsored-by: Athens County Public Libraries Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37732 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170969&action=edit Bug 37732: Fix administration_tasks.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37732 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170970&action=edit Bug 37732: Fix 'Invalid PIN code' styling for 2FA Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37732 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- I think those ones are candidate for a fix here: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt:[% IF ( book_reserved ) %]<div class="dialogalert"><strong>Cannot delete</strong>: item has a waiting hold.</div>[% END %] koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt: <div id="receipt_sent_dialog" class="dialog warning"> koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt: <div class="dialog [% message.type | html %]"> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt: <div class="dialog [% message.type | html %]"> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recall.tt: <div class="dialog"> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt: <div class="dialog dialog-success"> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37732 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170978&action=edit Bug 37732: (follow-up) Fix some missed instances This patch fixes a few templates which I had missed, including some which simply had the wrong classes (instead of getting the wrong class from the perl script). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37732 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37732 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170978|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170982&action=edit Bug 37732: (follow-up) Fix some missed instances This patch fixes a few templates which I had missed, including some which simply had the wrong classes (instead of getting the wrong class from the perl script). Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37732 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37732 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37732 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37732 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37732 Bug 37732 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org