[Bug 39914] New: Can't use dataTable's export function on lateorders.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 Bug ID: 39914 Summary: Can't use dataTable's export function on lateorders.tt Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Have some orders that are late. 2. Go to the late orders page ( http://localhost:8081/cgi-bin/koha/acqui/lateorders.pl ) 3. Try to use the export function, nothing happens. Looks to be because the table footer is not correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 182505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182505&action=edit Bug 39914: Correct the footer colspan -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182505|0 |1 is obsolete| | --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 182542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182542&action=edit Bug 39914: Correct the footer colspan To test: 1. Have some orders that are late. 2. Go to the late orders page ( http://localhost:8081/cgi-bin/koha/acqui/lateorders.pl ) 3. Try to use the export function, nothing happens. 4. APPLY PATCH 5. Try steps 1 and 3 again, this time the export function should work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182542|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 182543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182543&action=edit Bug 39914: Correct the footer colspan To test: 1. Have some orders that are late. 2. Go to the late orders page ( http://localhost:8081/cgi-bin/koha/acqui/lateorders.pl ) 3. Try to use the export function, nothing happens. 4. APPLY PATCH 5. Try steps 1 and 3 again, this time the export function should work. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182543|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 182550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182550&action=edit Bug 39914: Correct the footer colspan To test: 1. Have some orders that are late. 2. Go to the late orders page ( http://localhost:8081/cgi-bin/koha/acqui/lateorders.pl ) 3. Try to use the export function, nothing happens. 4. APPLY PATCH 5. Try steps 1 and 3 again, this time the export function should work. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the export release notes| |option for the | |acquisition's late orders | |table (Acquisitions > Late | |orders). Export now works | |as expected - previously, a | |progress spinner was shown | |and the table data was not | |exported. --- Comment #5 from David Nind <david@davidnind.com> --- Added my sign-off so that Owen's can be counted as QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Assignee|lucas@bywatersolutions.com |emily.lamancusa@montgomeryc | |ountymd.gov CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #6 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 182551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182551&action=edit Screenshot - Lateorders table footer row incorrect offset This isn't quite working correctly for me - the total columns are offset one space to the right (see attached screenshot). The total quantity is aligned with the Total Cost column, and the total cost is pushed over to the Basket column. After some experimentation with showing and hiding different columns on main, the table footer is always the correct size if the ISBN column is hidden, and is always 1 column too small if the ISBN column is showing. Not sure if this is because there's an issue with the ISBN column specifically, or if it's just because the ISBN is the last column, and all we need to do is increase the colspan on the last (blank) footer cell instead of the first footer cell. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|emily.lamancusa@montgomeryc |lucas@bywatersolutions.com |ountymd.gov | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182550|0 |1 is obsolete| | --- Comment #7 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 182553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182553&action=edit Bug 39914: Correct the footer colspan To test: 1. Have some orders that are late. 2. Go to the late orders page ( http://localhost:8081/cgi-bin/koha/acqui/lateorders.pl ) 3. Try to use the export function, nothing happens. 4. APPLY PATCH 5. Try steps 1 and 3 again, this time the export function should work. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 --- Comment #8 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 182554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182554&action=edit Bug 39914: (QA follow-up) Correct the footer colspan on the correct column Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #9 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Never mind...the answer to my question was a lot more easily googleable than I thought :D Making the adjustment and setting to PQA. Thanks everyone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can't use dataTable's |Can't use table export |export function on |function on late orders |lateorders.tt | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Emily Lamancusa (emlam) from comment #9)
Never mind...the answer to my question was a lot more easily googleable than I thought :D Making the adjustment and setting to PQA.
Thanks everyone!
Thanks Emily! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 antonio.colio@educampus.ie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |antonio.colio@educampus.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 --- Comment #12 from antonio.colio@educampus.ie --- Will this fix be backported to 24.11? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|25.05.00 |25.05.00,24.11.09 released in| | --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #14 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39914 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #15 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org