[Bug 39354] New: Remove unintended Bootstrap 5 change to scroll-behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39354 Bug ID: 39354 Summary: Remove unintended Bootstrap 5 change to scroll-behavior Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 35402 Bootstrap 5 introduced a change to the global CSS property "scroll-behavior." This adds a "smooth scrolling" behavior to in-page links, e.g. Administration -> System preferences -> Circulation -> Patron restrictions (from the sidebar menu). This is a fairly "opinionated" change on Bootstrap's part and since it wasn't an intentional change I think we should switch it back. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39354 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39354 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39354 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179383&action=edit Bug 39354: Remove unintended Bootstrap 5 change to scroll-behavior This patch updates the "variables" SCSS file in the OPAC and staff interface in order to disable the "smooth scroll" behavior introduced in Bootstrap 5. This was an unexpected and unintentional change. The patch also corrects another unexpected side-effect of the BS5 upgrade: A change to the "cursor" property of elements with a ".placeholder" class. This class is used by the multiple-select jQuery plugin found in some system preference controls. To test, apply the patch and rebuild the staff and OPAC CSS. - Clear your browser cache if necessary. - In the staff interface, go to Administration -> System preferences -> Circulation, and click "Patron restrictions" in the left-hand sidebar. The page should jump immediately to that section without any scrolling effect. - Go to the "Article requests" section of that page. Hover your cursor over a dropdown which doesn't have any option selected. Your cursor should not change to a "waiting" cursor. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39354 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39354 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39354 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39354 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179383|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 179415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179415&action=edit Bug 39354: Remove unintended Bootstrap 5 change to scroll-behavior This patch updates the "variables" SCSS file in the OPAC and staff interface in order to disable the "smooth scroll" behavior introduced in Bootstrap 5. This was an unexpected and unintentional change. The patch also corrects another unexpected side-effect of the BS5 upgrade: A change to the "cursor" property of elements with a ".placeholder" class. This class is used by the multiple-select jQuery plugin found in some system preference controls. To test, apply the patch and rebuild the staff and OPAC CSS. - Clear your browser cache if necessary. - In the staff interface, go to Administration -> System preferences -> Circulation, and click "Patron restrictions" in the left-hand sidebar. The page should jump immediately to that section without any scrolling effect. - Go to the "Article requests" section of that page. Hover your cursor over a dropdown which doesn't have any option selected. Your cursor should not change to a "waiting" cursor. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39354 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes two unexpected release notes| |and unintentional Bootstrap | |5 changes: | | | |- It updates | |the "smooth scroll" | |behavior introduced in | |Bootstrap 5 for in-page | |links. Example: when | |clicking on a section link | |for a system | |administration, the page | |should jump immediately to | |that section instead of | |scrolling. | | | |- It updates | |some multiple-select | |dropdown lists used by some | |system preference controls, | |where a default option is | |not selected. When you | |hovered over the dropdown | |list, the cursor changed to | |a "waiting" cursor | |(rotating circle), this | |behavour is now removed. | |Example: the | |ArticleRequestsMandatoryFie | |lds system preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39354 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39354 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39354 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179415|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179421&action=edit Bug 39354: Remove unintended Bootstrap 5 change to scroll-behavior This patch updates the "variables" SCSS file in the OPAC and staff interface in order to disable the "smooth scroll" behavior introduced in Bootstrap 5. This was an unexpected and unintentional change. The patch also corrects another unexpected side-effect of the BS5 upgrade: A change to the "cursor" property of elements with a ".placeholder" class. This class is used by the multiple-select jQuery plugin found in some system preference controls. To test, apply the patch and rebuild the staff and OPAC CSS. - Clear your browser cache if necessary. - In the staff interface, go to Administration -> System preferences -> Circulation, and click "Patron restrictions" in the left-hand sidebar. The page should jump immediately to that section without any scrolling effect. - Go to the "Article requests" section of that page. Hover your cursor over a dropdown which doesn't have any option selected. Your cursor should not change to a "waiting" cursor. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39354 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Better but it still looks like the select2 are disabled IMO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39354 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39354 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179447&action=edit Bug 39354: (follow-up) Override additional BS5 CSS for multiple-select -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39354 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39354 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39354 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39354 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.10 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39354 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #8 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39354 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #9 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org