[Bug 20312] New: Add a link towards the last consulted patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Bug ID: 20312 Summary: Add a link towards the last consulted patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: new feature Priority: P5 - low Component: Patrons Assignee: maksim.sen@inlibro.com Reporter: maksim.sen@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com, maksim.sen@inlibro.com, philippe.blouin@inlibro.com This new feature will add a link (on the top-left of the site) to the last patron consulted in the staff site. The feature currently uses cookies to save this information. When a staff site user accesses a patron record, the ID, name and card number of the patron will be saved in the cookie. (I'll add a patch and a test plan shortly) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Maksim Sen <maksim.sen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 --- Comment #1 from Maksim Sen <maksim.sen@inlibro.com> --- Created attachment 72294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72294&action=edit Bug 20312 - Add a link to last consulted patron TEST PLAN 1 - apply patch 2 - Go to a patron record 3 - Go to a different module 4 - Click on "Last patron" (top-left) 5 - It should go the last patron record you consulted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Axelle <axelle.clarisse@univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72294|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 72638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72638&action=edit Bug 20312 - Add a link to last consulted patron TEST PLAN 1 - apply patch 2 - Go to a patron record 3 - Go to a different module 4 - Click on "Last patron" (top-left) 5 - It should go the last patron record you consulted Signed-off-by: Axelle <axelle.clarisse@univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Maksim, the patch contains a po file that should not be there, can you please fix? I am also having doubts on the the placmeent of the link. This is not a link to a module, so I tihnk placing it in the top navigation is not a good spot. Asking Owen for additional feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Niamh <niamh.walker-headon@it-tallaght.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon@it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75672&action=edit Screenshot of interface idea Something like this might work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 --- Comment #6 from Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> --- Created attachment 77272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77272&action=edit Bug 20312: Add a link to last consulted patron This is an update to Maksim's patch. The link "Last patron" is now on the top-right corner of the screen and has the same style as attachment 75672. Moreover, the "X" button is added to remove the link if clicked on. To test: 1- Apply the patch 2- Go to a patron details' page 3- Verify that the link "Last patron" appears on the top-right corner of the screen 4- Go to another page 5- The link should still be here 6- Click on the link 7- Verify that you are at the patron's checkout page 8- Click on the "X" button next to the "Last patron" link 9- The link should be gone 10- Go to another page 11- The link shouldn't appear (until the next patron detail's page) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-luc.lapointe@inLibro | |.com Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 --- Comment #7 from Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> --- Hi Owen, Katrin, I created the file last-borrower.inc that contains the main code for the feature. It has a <style> tag for the link to appear like in attachment 75672. I would like to know if this tag is in the right place of it should be in another file. Also, is the link's position appropriate? Thank you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72638|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Pierre-Luc, taking a quick look. The QA script notes some issues: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/last-borrower.inc FAIL forbidden patterns forbidden pattern: tab char (line 44) forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 3) forbidden pattern: tab char (line 41) forbidden pattern: tab char (line 48) forbidden pattern: tab char (line 38) forbidden pattern: tab char (line 40) forbidden pattern: tab char (line 37) Please note, that once this is pushed, the new cookie should be documented here: https://wiki.koha-community.org/wiki/Use_of_Cookies I will leave the question of where the Javascript should go to Owen, but feel like it might be better in a separate .js file. I wonder if libraries would like to have this optional for privacy reasons. It might be safer to add a pref. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Some suggestions: - Use <i class="fa fa-remove"></i> instead of an image for X. - Put the CSS in staff-global.scss - Put the JavaScript in staff-global.js - Add the JS to the existing $(document).ready() so you don't need 'addEventListener('DOMContentLoaded')'; - Be consistent about whether you use single or double quotes (In reply to Katrin Fischer from comment #8)
I wonder if libraries would like to have this optional for privacy reasons. It might be safer to add a pref.
A lot of this already rests in the hands of the librarian and their browser. If I have my browser configured to restore my last session, my back button will take me back to the last patron without a handy link. The way this patch does it, the cookie should disappear when the browser is closed. I would think that is adequate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77272|0 |1 is obsolete| | --- Comment #10 from Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> --- Created attachment 77769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77769&action=edit Bug 20312: Add a link to last consulted patron This new feature adds a link to the last patron consulted in the staff site. It uses cookies to save this information. When a staff site user accesses a patron record, the ID, name and card number of the patron will be saved in the cookie. To test: 1- Apply the patch 2- Go to a patron details' page 3- Verify that the link "Last patron" appears on the top-right corner of the screen 4- Go to another page 5- The link should still be here 6- Click on the link 7- Verify that you are at the patron's checkout page 8- Click on the "X" button next to the "Last patron" link 9- The link should be gone 10- Go to another page 11- The link shouldn't appear (until the next patron detail's page) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77796&action=edit Bug 20312: (follow-up) Minor CSS corrections This patch makes a couple of minor CSS corrections to match linter style and to correctly color the "X" link. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- I noticed a problem when testing this today: The first time the "last patron" link appears, it doesn't contain any parameters (i.e. /cgi-bin/koha/circ/circulation.pl instead of /cgi-bin/koha/circ/circulation.pl?borrowernumber=XXX). It's only after I open a second patron record that the "last patron" link takes me to a valid patron record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77769|0 |1 is obsolete| | Attachment #77796|0 |1 is obsolete| | --- Comment #13 from Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> --- Created attachment 77835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77835&action=edit Bug 20312: Add a link to last consulted patron This new feature adds a link to the last patron consulted in the staff site. It uses cookies to save this information. When a staff site user accesses a patron record, the ID, name and card number of the patron will be saved in the cookie. To test: 1- Apply the patch 2- Go to a patron details' page 3- Verify that the link "Last patron" appears on the top-right corner of the screen 4- Go to another page 5- The link should still be here 6- Click on the link 7- Verify that you are at the patron's checkout page 8- Click on the "X" button next to the "Last patron" link 9- The link should be gone 10- Go to another page 11- The link shouldn't appear (until the next patron detail's page) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- This seems to be working well now. The only thing which seems unexpected to me was that the "Last patron" link changed immediately upon opening a new checkout screen. - Check out to Patron A - "Last patron" = Patron A. - Check out to Patron B - "Last patron" = Patron B. ...Isn't the "last patron" technically Patron A? I think it's only when switching between patrons at checkout when this is potentially confusing. I'm not sure if that justifies failing this. I'm going to defer to QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77835|0 |1 is obsolete| | --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77977&action=edit Bug 20312: Add a link to last consulted patron This new feature adds a link to the last patron consulted in the staff site. It uses cookies to save this information. When a staff site user accesses a patron record, the ID, name and card number of the patron will be saved in the cookie. To test: 1- Apply the patch 2- Go to a patron details' page 3- Verify that the link "Last patron" appears on the top-right corner of the screen 4- Go to another page 5- The link should still be here 6- Click on the link 7- Verify that you are at the patron's checkout page 8- Click on the "X" button next to the "Last patron" link 9- The link should be gone 10- Go to another page 11- The link shouldn't appear (until the next patron detail's page) Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77977|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77979&action=edit Bug 20312: Add a link to last consulted patron This new feature adds a link to the last patron consulted in the staff site. It uses cookies to save this information. When a staff site user accesses a patron record, the ID, name and card number of the patron will be saved in the cookie. To test: 1- Apply the patch 2- Go to a patron details' page 3- Verify that the link "Last patron" appears on the top-right corner of the screen 4- Go to another page 5- The link should still be here 6- Click on the link 7- Verify that you are at the patron's checkout page 8- Click on the "X" button next to the "Last patron" link 9- The link should be gone 10- Go to another page 11- The link shouldn't appear (until the next patron detail's page) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice little feature addition here.. code looks reasonable and the feature works as expected for me.. I can't find any regressions and the qa scripts all pass. Passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Minor note.. https://wiki.koha-community.org/wiki/Use_of_Cookies will need updating to reflect the additional cookie data added here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi, Now it looks like that: https://snag.gy/6vbjNS.jpg (a bit different that what is on the attached screenshot) I am sorry to tell that, but I do not like it. I will list some things that are wrong and enhancement suggestions: * #lastborrower-window ("window"?) is shown by default, then hidden when the page is loaded, it should be the reverse. * A general pref should control it, you click 'x' then it displays again. It can be frustrating (yes it could be hidden with js, but here I think we need a pref (or better would have been a config at per user, but out of the scope). * If you are on patron A detail view, you see the "last patron" that link to ... patron A. It is useless in that case. Either it points to the last patron, or is not displayed. * I think it would have been more useless with the last X (5?) instead of the last one (not required) You can wait for other QAers opinions before implementing these changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #19)
* I think it would have been more useless with the last X (5?) instead of the last one (not required)
Ofc this was ^useless^useful^ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Further comment.. it would be good to set the 'last patron' upon navigating away from a patron interaction rather than to it if that's possible.. else 'last patron' and 'current patron' end up matching immediately so if you want to return to the last patron you're stuck again at starting from scratch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- https://snag.gy/3QlVb7.jpg is where I now see the ui action.. I'm sure it was showing right aligned inside the breadcrumb bar when I first looked.. maybe a fluke -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77979|0 |1 is obsolete| | --- Comment #23 from Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> --- Created attachment 78002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78002&action=edit Bug 20312: Add a link to last consulted patron This new feature adds a link to the last patron consulted in the staff site. It uses cookies to save this information. When a staff site user accesses a patron record, the ID, name and card number of the patron will be saved in the cookie. To test: 1- Apply the patch 2- Go to a patron details' page 4- Go to another page 4- Verify that the link "Last patron" appears on the top-right corner of the screen 5- Click on the link 6- Verify that you are at the patron's checkout page 7- Click on the "X" button next to the "Last patron" link 8- The link should be gone 9- Go to another page 10- The link shouldn't appear (until the next patron detail's page) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78002|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 78005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78005&action=edit Bug 20312: Add a link to last consulted patron This new feature adds a link to the last patron consulted in the staff site. It uses cookies to save this information. When a staff site user accesses a patron record, the ID, name and card number of the patron will be saved in the cookie. To test: 1- Apply the patch 2- Go to a patron details' page 4- Go to another page 4- Verify that the link "Last patron" appears on the top-right corner of the screen 5- Click on the link 6- Verify that you are at the patron's checkout page 7- Click on the "X" button next to the "Last patron" link 8- The link should be gone 9- Go to another page 10- The link shouldn't appear (until the next patron detail's page) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Second times a charm. Thankyou for making the requested changes, this looks very good to me now. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21244 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21244 [Bug 21244] Make the display of the 'Last patron' button system preference driven. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21245 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21245 [Bug 21245] Move 'Last patron' button inside of the 'breadcrumb' bar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21246 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21246 [Bug 21246] Extend the 'Last patron' navigation feature to 'Last X patrons' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Failed QA --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #19)
* A general pref should control it, you click 'x' then it displays again. It can be frustrating (yes it could be hidden with js, but here I think we need a pref
I agree with Jonathan here, I asked around at Kohacon, many libraries would like this feature, but a few had concerns about privacy/security and would like to have the option to disable. Can you please add a syspref to disable the feature? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78005|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81726&action=edit Bug 20312: Add a link to last consulted patron This new feature adds a link to the last patron consulted in the staff site. It uses cookies to save this information. When a staff site user accesses a patron record, the ID, name and card number of the patron will be saved in the cookie. To test: 1- Apply the patch 2- Go to a patron details' page 4- Go to another page 4- Verify that the link "Last patron" appears on the top-right corner of the screen 5- Click on the link 6- Verify that you are at the patron's checkout page 7- Click on the "X" button next to the "Last patron" link 8- The link should be gone 9- Go to another page 10- The link shouldn't appear (until the next patron detail's page) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81727&action=edit Bug 20312: (QA follow-up) Make display syspref driven Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Quick rescue job done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 21244 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81727|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81728&action=edit Bug 20312: (QA follow-up) Make display syspref driven Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Just reverse my last patch so the feature default to 'off' for now.. I want to get the refinements in before it's widely used ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #33 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |A first pass at adding a release notes| |handy feature to allow | |quickly navigating back to | |the last searched user in | |the staff client. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24549 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 [Bug 24549] Cookies for last patron link are always set - even if showLastPatron is turned off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org