https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Pierre-Luc, taking a quick look. The QA script notes some issues: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/last-borrower.inc FAIL forbidden patterns forbidden pattern: tab char (line 44) forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 3) forbidden pattern: tab char (line 41) forbidden pattern: tab char (line 48) forbidden pattern: tab char (line 38) forbidden pattern: tab char (line 40) forbidden pattern: tab char (line 37) Please note, that once this is pushed, the new cookie should be documented here: https://wiki.koha-community.org/wiki/Use_of_Cookies I will leave the question of where the Javascript should go to Owen, but feel like it might be better in a separate .js file. I wonder if libraries would like to have this optional for privacy reasons. It might be safer to add a pref. -- You are receiving this mail because: You are watching all bug changes.