[Bug 38872] New: Only first 'a' node tested for wrong filters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 Bug ID: 38872 Summary: Only first 'a' node tested for wrong filters Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 21576 If several 'a' elements are on the same line, only the first one will be tested for wrong filters. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21576 [Bug 21576] Add a developer script to automatically fix missing filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176443&action=edit Bug 38872: Add a test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176444&action=edit Bug 38872: Parse all 'a' element, not only the first one Test plan: Apply the "Add test" commit % prove t/template_filters.t => Fail Apply this patch % prove t/template_filters.t => Success % prove xt/find-missing-filters.t => Fail Apply the last patch "Fix occurrences" % prove xt/find-missing-filters.t => Success -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176445&action=edit Bug 38872: Fix the missing occurrences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176443|0 |1 is obsolete| | Attachment #176444|0 |1 is obsolete| | Attachment #176445|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 176446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176446&action=edit Bug 38872: Add a test Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 176447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176447&action=edit Bug 38872: Parse all 'a' element, not only the first one Test plan: Apply the "Add test" commit % prove t/template_filters.t => Fail Apply this patch % prove t/template_filters.t => Success % prove xt/find-missing-filters.t => Fail Apply the last patch "Fix occurrences" % prove xt/find-missing-filters.t => Success Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 176448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176448&action=edit Bug 38872: Fix the missing occurrences Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176446|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 176472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176472&action=edit Bug 38872: Add a test Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176447|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 176473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176473&action=edit Bug 38872: Parse all 'a' element, not only the first one Test plan: Apply the "Add test" commit % prove t/template_filters.t => Fail Apply this patch % prove t/template_filters.t => Success % prove xt/find-missing-filters.t => Fail Apply the last patch "Fix occurrences" % prove xt/find-missing-filters.t => Success Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176448|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 176474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176474&action=edit Bug 38872: Fix the missing occurrences Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #10 from David Nind <david@davidnind.com> --- Added my sign off, in case Owen's can count as QA. Results of running the QA script: qa testing 3 commit(s) (applied to 3fc855f '68 Bug 38856: Typo: EmailAddressForPa') Processing files before patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 165. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 165. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 260. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 165. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 165. |========================>| 6 / 6 (100.00%) Processing files after patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 165. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 165. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 260. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 165. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 165. |========================>| 6 / 6 (100.00%) OK koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/curbside_pickups.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/process_koc.tt OK t/lib/QA/TemplateFilters.pm WARN t/template_filters.t WARN tidiness The file is less tidy than before (bad/messy lines before: 17, now: 19) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176472|0 |1 is obsolete| | --- Comment #11 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 176778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176778&action=edit Bug 38872: Add a test Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176473|0 |1 is obsolete| | --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 176779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176779&action=edit Bug 38872: Parse all 'a' element, not only the first one Test plan: Apply the "Add test" commit % prove t/template_filters.t => Fail Apply this patch % prove t/template_filters.t => Success % prove xt/find-missing-filters.t => Fail Apply the last patch "Fix occurrences" % prove xt/find-missing-filters.t => Success Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176474|0 |1 is obsolete| | --- Comment #13 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 176780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176780&action=edit Bug 38872: Fix the missing occurrences Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |matt.blenkinsop@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 --- Comment #15 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- I bet this is needed for 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #17 from Jesse Maseto <jesse@bywatersolutions.com> --- Merge conflicts with 24.05.x. Please resolve these if needed in 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #18 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38872 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #19 from David Nind <david@davidnind.com> --- Architecture change/bug fix, no changes required to the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org