[Bug 38072] New: Regression with modalPrint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Bug ID: 38072 Summary: Regression with modalPrint Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com We have a few instanced of modalPrint in Koha and they appear to have all ceased to function. returns (bundle modal) and cash registers (cashup summary) are both affected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172360&action=edit Bug 38072: Fix regression in modal_printer This patch updates the JS for the modal printer to make it more reliable. I found that in recent versions of chrome the print dialog failed to open and instead you were just faced with a flash of white before the new tab autoclosed and no print takes place. Test plan 1) Enable cash registers and point of sale preferences 2) Add a debit type and mark it as 'Can be sold' 3) Add a cash register 4) Use 'Point of sale' to sell one of the above item for cash against the register you just created. 5) Navigate to the register and 'cashup' 6) Click the 'summary' link to display a modal 7) User the 'Print' option in the modal and confirm you face a print dialog and can print -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 [Bug 33260] Show message queue on staff interface and make notices printable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cj.lynce@westlakelibrary.or | |g --- Comment #2 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Prior to applying the patch (on main), when clicking "Print" on the modal, a new tab is opened with the print data, along with the print dialog. Successfully printing or cancelling closes the print data tab, and returns you to the screen with modal. (Tested on Chrome, Edge, Firefox, and Brave) After applying the patch, when click "Print" on the modal, a new tab is opened with the print data and print dialog (similar to before) but successfully printing, or cancelling, DOES NOT close the new tab in Chrome, Edge, or Brave (Chromium based.) It DOES close the new tab on Firefox. Is this intended? (Firefox v 131.0; Chrome 129.0.6668.90; Edge 129.0.2792.65; Brave 1.70.123 based on Chromium 129.0.6668.89) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- That's interesting.. for me prior to the patch chrome would flash open the tab and immediately close it without triggering the print dialogue. After the patch the correct behaviour I'm seeing is exactly what you're seeing prior to the patch. i.e. opens tab, opens print dialog, on close or print closes tab. I'm on Chrome 129.0.6668.89 (Official Build) (64-bit) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to CJ Lynce from comment #2)
Prior to applying the patch (on main), when clicking "Print" on the modal, a new tab is opened with the print data, along with the print dialog. Successfully printing or cancelling closes the print data tab, and returns you to the screen with modal. (Tested on Chrome, Edge, Firefox, and Brave)
After applying the patch, when click "Print" on the modal, a new tab is opened with the print data and print dialog (similar to before) but successfully printing, or cancelling, DOES NOT close the new tab in Chrome, Edge, or Brave (Chromium based.) It DOES close the new tab on Firefox.
Is this intended?
(Firefox v 131.0; Chrome 129.0.6668.90; Edge 129.0.2792.65; Brave 1.70.123 based on Chromium 129.0.6668.89)
With the patch applied I experience the same thing as CJ when using Chrome ( Version 129.0.6668.58 (Official Build) (64-bit) ) In Firefox it is working as intended. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> ---
With the patch applied I experience the same thing as CJ when using Chrome ( Version 129.0.6668.58 (Official Build) (64-bit) )
In Firefox it is working as intended.
Sorry, not enough morning coffee. I had this backwards: -Works in Chrome ( Version 129.0.6668.58 (Official Build) (64-bit) ) -Does not close the tab in Firefox ( 131.0 (64-bit) ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 172483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172483&action=edit Bug 38072: [alternate] Fix regression in modal print Test plan 1) Enable cash registers and point of sale preferences 2) Add a debit type and mark it as 'Can be sold' 3) Add a cash register 4) Use 'Point of sale' to sell one of the above item for cash against the register you just created. 5) Navigate to the register and 'cashup' 6) Click the 'summary' link to display a modal 7) User the 'Print' option in the modal and confirm you face a print dialog and can print -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- CJ, can you test with my alternate patch instead? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 --- Comment #8 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Lucas, everything works as expected with your alternate patch, in all browsers (print dialog appears, temp tab closes when finished). FYI- I could only apply your alt patch on top of Martin's, not on stock main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- I can't reproduce the issue on Chromium 129.0.6668.70 :( Regardless of having my adblocker enabled or not. The print tab as expected is closed when printing or canceling the browser print menu. (Same in Firefox) Anyway, we could move on with CJ's testing. But:
I could only apply your alt patch on top of Martin's, not on stock main.
Indeed, the alternate patch diff shows that it's one top of the changes of the 1st patch. Is the alternate patch a follow-up to complete the 1st one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Victor Grousset/tuxayo from comment #9)
I can't reproduce the issue on Chromium 129.0.6668.70 :( Regardless of having my adblocker enabled or not. The print tab as expected is closed when printing or canceling the browser print menu. (Same in Firefox)
Anyway, we could move on with CJ's testing.
But:
I could only apply your alt patch on top of Martin's, not on stock main.
Indeed, the alternate patch diff shows that it's one top of the changes of the 1st patch.
Is the alternate patch a follow-up to complete the 1st one?
Yes, you'll need to apply both. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
I can't reproduce the issue on Chromium 129.0.6668.70 :( [...] The print tab as expected is closed when printing or canceling the browser print menu. (Same in Firefox)
At least I see no change in behavior with the patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #12 from David Nind <david@davidnind.com> --- I can't replicate the issue - everything works the same for me both before and after the patches. Tested on Ubuntu 22.04 - Firefox (Normal 131.0, Developer Edition 132.0b4), Chromium (129.0.6668.89), and Google Chrome (129.0.6668.89). Testing notes: 1. Enable the cash registers and point of sale system preferences: - EnablePointOfSale: Enable - UseCashRegisters: Use 2. Add a debit type and mark it as 'Can be sold' (Administration > Accounting > Debit types> New debit type). 3. Add a cash register (Administration > Accounting > Cash registers > New cash register). 4. Use the point of sale module to sell one of the items created for cash against the register you just created (Point of sale > click 'Add' for the item you created > Collect payment > enter an amount for 'Amount tendered'). 5. Navigate to the register and 'cashup' (Point of sale > cash management > Cash summary for Centerville > Record cashup action, then 'Confirm'). 6. Click the 'summary' link to display a modal (in the 'Last cashup' column for the cash register). 7. For the Koha cashup summary dialog box, click 'Print'. A standard device/system print dialog box should appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172360|0 |1 is obsolete| | --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 172508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172508&action=edit Bug 38072: Fix regression in modal_printer This patch updates the JS for the modal printer to make it more reliable. I found that in recent versions of chrome the print dialog failed to open and instead you were just faced with a flash of white before the new tab autoclosed and no print takes place. Test plan 1) Enable cash registers and point of sale preferences 2) Add a debit type and mark it as 'Can be sold' 3) Add a cash register 4) Use 'Point of sale' to sell one of the above item for cash against the register you just created. 5) Navigate to the register and 'cashup' 6) Click the 'summary' link to display a modal 7) Use the 'Print' option in the modal and confirm you face a print dialog and can print 8) The print tab should be closed and you should be back to Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 172509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172509&action=edit Bug 38072: Ensure the printing tab closes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172483|0 |1 is obsolete| | --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Comment on attachment 172483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172483 Bug 38072: [alternate] Fix regression in modal print I tried to clarify the role of the 2nd patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- And I realized even CJ their testing didn't got the main issue of this ticket. Any more details Martin of how you get the print dialog to fail? That's now 4 people who didn't got the completely broken print dialog with the current test plan. There must be something else needed to throw things off ^^" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- I have no idea how to replicate it.. for me it happens consistently with and without any extensions installed. It's odd.. browser hell.. I just assumed it was happening for anyone else using the same Chrome version, but that doesn't even appear to be the case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- If you know about someone else having the issue and not having it anymore when the patch is there, then we can go with that. (testing on a sandbox with and without the patch) Since it seems safe to say the patch doesn't introduce a regression, we could do that for these hard to reproduce issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33260 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 [Bug 33260] Show message queue on staff interface and make notices printable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
If you know about someone else having the issue and not having it anymore when the patch is there, then we can go with that.
So needing one report of having seen the fix work. Whether locally or in production without knowing what are the exact conditions there that we are missing here to reproduce. At least being certain that the fix can fix :) An alternative is to treat this as a refactor and go with it now. And cross fingers that it will fix it for people having the bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize@ptfs-europe |koha-bugs@lists.koha-commun |.com |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- This is pretty annoying.. it still happens for me consistently in Chrome (Now 142.0.7444.134) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- This is a timing-dependent race condition that manifests based on: - Chrome version (I'm on 142 now) - Print dialog type (Chrome preview vs system dialog) - OS print subsystem timing - Machine speed The original code is objectively flawed - it calls win.close() immediately after win.print() without waiting. Even if it works for some, it's racing with the browser's async print dialog and will fail under certain conditions. Request for testers: Please try on Chrome 140+ with different print settings, or deliberately slow down your system to expose the race." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #22 from David Nind <david@davidnind.com> --- I've still had difficulty replicating the issue, but was going to sign off anyway if things still continued to work as expected. However, the patch no longer applies 8-(... git bz apply 38072 Bug 38072 - Regression with modalPrint 172508 - Bug 38072: Fix regression in modal_printer 172509 - Bug 38072: Ensure the printing tab closes Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 38072: Fix regression in modal_printer Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/js/modal_printer.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/modal_printer.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/modal_printer.js error: Failed to merge in the changes. Patch failed at 0001 Bug 38072: Fix regression in modal_printer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172508|0 |1 is obsolete| | Attachment #172509|0 |1 is obsolete| | --- Comment #23 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 189970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189970&action=edit Bug 38072: Fix regression in modal_printer This patch updates the JS for the modal printer to make it more reliable. I found that in recent versions of chrome the print dialog failed to open and instead you were just faced with a flash of white before the new tab autoclosed and no print takes place. Test plan 1) Enable cash registers and point of sale preferences 2) Add a debit type and mark it as 'Can be sold' 3) Add a cash register 4) Use 'Point of sale' to sell one of the above item for cash against the register you just created. 5) Navigate to the register and 'cashup' 6) Click the 'summary' link to display a modal 7) Use the 'Print' option in the modal and confirm you face a print dialog and can print 8) The print tab should be closed and you should be back to Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 --- Comment #24 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 189971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189971&action=edit Bug 38072: Ensure the printing tab closes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #25 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- easy whitespace conflicts - rebased so it can be tested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189970|0 |1 is obsolete| | --- Comment #26 from David Nind <david@davidnind.com> --- Created attachment 189979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189979&action=edit Bug 38072: Fix regression in modal_printer This patch updates the JS for the modal printer to make it more reliable. I found that in recent versions of chrome the print dialog failed to open and instead you were just faced with a flash of white before the new tab autoclosed and no print takes place. Test plan 1) Enable cash registers and point of sale preferences 2) Add a debit type and mark it as 'Can be sold' 3) Add a cash register 4) Use 'Point of sale' to sell one of the above item for cash against the register you just created. 5) Navigate to the register and 'cashup' 6) Click the 'summary' link to display a modal 7) Use the 'Print' option in the modal and confirm you face a print dialog and can print 8) The print tab should be closed and you should be back to Koha Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189971|0 |1 is obsolete| | --- Comment #27 from David Nind <david@davidnind.com> --- Created attachment 189980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189980&action=edit Bug 38072: Ensure the printing tab closes Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes a regression release notes| |when printing dialogue | |boxes in certain | |Chromium-based browsers, | |for example, when printing | |the cashup summary for the | |point of sale system. | |Sometimes the print dialog | |failed to open, and instead | |you were faced with a flash | |of white before the new tab | |automatically closed and | |didn't print. --- Comment #28 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. As noted in comment #22, I couldn't replicate the issue (using Chromium 142.0.7444.59 or Google Chrome 142.0.7444.175 on Ubuntu 22.04). 2. Things work as expected after the patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189979|0 |1 is obsolete| | Attachment #189980|0 |1 is obsolete| | --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 190008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190008&action=edit Bug 38072: Fix regression in modal_printer This patch updates the JS for the modal printer to make it more reliable. I found that in recent versions of chrome the print dialog failed to open and instead you were just faced with a flash of white before the new tab autoclosed and no print takes place. Test plan 1) Enable cash registers and point of sale preferences 2) Add a debit type and mark it as 'Can be sold' 3) Add a cash register 4) Use 'Point of sale' to sell one of the above item for cash against the register you just created. 5) Navigate to the register and 'cashup' 6) Click the 'summary' link to display a modal 7) Use the 'Print' option in the modal and confirm you face a print dialog and can print 8) The print tab should be closed and you should be back to Koha Signed-off-by: David Nind <david@davidnind.com> Bug 38072: Ensure the printing tab closes Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Squashed and tidied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 --- Comment #30 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 --- Comment #31 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00,25.05.06 |25.11.00,25.05.06,24.11.11 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #32 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #33 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #34 from David Nind <david@davidnind.com> --- Bug fix, no changes required to the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org