[Bug 21552] New: RoutingListNote should use raw filter and display HTML unescaped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 Bug ID: 21552 Summary: RoutingListNote should use raw filter and display HTML unescaped Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com The routing list note as visible on the routing list preview is supposed to work like other HTML notes and display rendered unescaped HTML. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80437&action=edit Bug 21552: Use raw filter for displaying RoutingListNote The RoutingListNote system preference works like other prefs allowing you to insert your own content on the routling list template using HTML. The default text even uses HTML, so it looks broken without this patch. To test: - Add a subscription - Add a new routing list to it - Add some patrons to it - Save - preview routing list - Verify that the note shows and is formatted correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-marc.thibault@inlibr | |o.com --- Comment #2 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- I put some custom html in the RoutingListNote preference and looked at the preview. It does not seem there is a problem in the first place as there are no html nodes in the preview I opened by clicking "Save and preview routing slip". Am I missing a step? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Pierre-Marc, on master it shows for me: To change this note edit <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=RoutingListNote#jumped">RoutingListNote</a> system preference. So the HTML shows unrendered. Can you check if you have the patch applied already and what you put into the preference? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 --- Comment #4 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Hi Katrin, I can confirm that the patch has not been applied. In the reference, I decided to insert the message you see on master : To change this note edit <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=RoutingListNote#jumped">RoutingListNote</a> system preference. and what I see is : To change this note edit RoutingListNote system preference. I don't know why, but I don't have a problem on my side. Do you know why the current code is not working correctly? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have no idea as it really should not work as there is a html filter on the element in master. :( Are you on recent master? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 --- Comment #6 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Sorry Katrin, I took the wrong tab to do my tests. I shall corrige this immediately and sign off this ASAP I confirm the validity of your patch. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80437|0 |1 is obsolete| | --- Comment #7 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 80564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80564&action=edit Bug 21552: Use raw filter for displaying RoutingListNote The RoutingListNote system preference works like other prefs allowing you to insert your own content on the routling list template using HTML. The default text even uses HTML, so it looks broken without this patch. To test: - Add a subscription - Add a new routing list to it - Add some patrons to it - Save - preview routing list - Verify that the note shows and is formatted correctly. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 --- Comment #8 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Hopefully this makes up my mistake. The problem was here and the patch fixes it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx! you had me a little worried there :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80564|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 80645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80645&action=edit Bug 21552: Use raw filter for displaying RoutingListNote The RoutingListNote system preference works like other prefs allowing you to insert your own content on the routling list template using HTML. The default text even uses HTML, so it looks broken without this patch. To test: - Add a subscription - Add a new routing list to it - Add some patrons to it - Save - preview routing list - Verify that the note shows and is formatted correctly. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- This is not needed for 17.11.x because generalroutingnote is not html filtered. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org