[Bug 21583] New: Novelist Select staff client not working in staff client - ns2init.js not loading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21583 Bug ID: 21583 Summary: Novelist Select staff client not working in staff client - ns2init.js not loading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21583 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21583 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 80668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80668&action=edit Bug 21583: Don't use Asset.js for external script files To test: 1 - Enable Novelist in staff client: NovelistSelectStaffEnabled: Add NovelistSelectStaffProfile: anything NovelistSelectPassword: anything ( these don't need to be valid, just not blank ) 2 - Pull up a record detail page in staff client 3 - View page source - search for ns2init.js 4 - You won't find it 5 - Apply patch 6 - Reload details 7 - Search page source for ns2init.js 8 - It loaded! Huzzah! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21583 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21583 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80668|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 80681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80681&action=edit Bug 21583: Don't use Asset.js for external script files To test: 1 - Enable Novelist in staff client: NovelistSelectStaffEnabled: Add NovelistSelectStaffProfile: anything NovelistSelectPassword: anything ( these don't need to be valid, just not blank ) 2 - Pull up a record detail page in staff client 3 - View page source - search for ns2init.js 4 - You won't find it 5 - Apply patch 6 - Reload details 7 - Search page source for ns2init.js 8 - It loaded! Huzzah! Signed-off-by: George Williams <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21583 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org Status|Needs Signoff |Signed Off --- Comment #3 from George Williams (NEKLS) <george@nekls.org> --- Tested on ByWater sandbox. Works as advertised. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21583 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21583 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80681|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 80684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80684&action=edit Bug 21583: Don't use Asset.js for external script files To test: 1 - Enable Novelist in staff client: NovelistSelectStaffEnabled: Add NovelistSelectStaffProfile: anything NovelistSelectPassword: anything ( these don't need to be valid, just not blank ) 2 - Pull up a record detail page in staff client 3 - View page source - search for ns2init.js 4 - You won't find it 5 - Apply patch 6 - Reload details 7 - Search page source for ns2init.js 8 - It loaded! Huzzah! Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21583 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20538 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538 [Bug 20538] Remove the need of writing [% KOHA_VERSION %] everywhere -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21583 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21583 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21583 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 21583 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21583 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org