[Bug 20329] New: Text input fields are wider than the fieldset class they are inside of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Bug ID: 20329 Summary: Text input fields are wider than the fieldset class they are inside of Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: alexbuckley@catalyst.net.nz Reporter: alexbuckley@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The input text fields in the following pages of the Koha staff client are wider than the fieldset class elements they are contained within: acqui/invoices.tt members/member.tt circ/overdue.tt acqui/parcel.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 72394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72394&action=edit Bug 20329 - Shortened the width of text input fields This makes the text input fields fit tidily within the border of the fieldset class elements they are within. Test plan: 1. Go to the acqui/invoices.pl, members/members-home.pl, circ/overdue.pl, acqui/parcel.pl and notice that the text input fields on the fieldset element on the left hand side of the screen for filtering search results are too wide and go over the border of the fieldset element 2. Apply patch 3. Refresh the aforementioned pages and notice the text inputs have a shortened width and now fit within the fielset class element Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72394|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 72395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72395&action=edit Bug 20329 - Shortened the width of text input fields This makes the text input fields fit tidily within the border of the fieldset class elements they are within. Test plan: 1. Go to the acqui/invoices.pl, members/members-home.pl, circ/overdue.pl, acqui/parcel.pl and notice that the text input fields on the fieldset element on the left hand side of the screen for filtering search results are too wide and go over the border of the fieldset element 2. Apply patch 3. Refresh the aforementioned pages and notice the text inputs have a shortened width and now fit within the fielset class element Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust@univ-lyo | |n2.fr --- Comment #3 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- I could not see any difference after applying the patch and I am not sure to understand very well the goal of this patch (because of my english level?). Any picture appreciated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- (In reply to jmbroust from comment #3)
I could not see any difference after applying the patch and I am not sure to understand very well the goal of this patch (because of my english level?). Any picture appreciated.
What is also not mentioned is restart_all on a kohadevbox. Caching is such a pain. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72395|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73299&action=edit Bug 20329 - Shortened the width of text input fields This makes the text input fields fit tidily within the border of the fieldset class elements they are within. Test plan: 1. Go to the acqui/invoices.pl, members/members-home.pl, circ/overdue.pl, acqui/parcel.pl and notice that the text input fields on the fieldset element on the left hand side of the screen for filtering search results are too wide and go over the border of the fieldset element 2. Apply patch 3. Refresh the aforementioned pages and notice the text inputs have a shortened width and now fit within the fielset class element Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73467&action=edit k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Mark, your sign-off line is missing. I've added it in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73467|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73299|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73468&action=edit Bug 20329: Shorten the width of text input fields This makes the text input fields fit tidily within the border of the fieldset class elements they are within. Test plan: 1. Go to the acqui/invoices.pl, members/members-home.pl, circ/overdue.pl, acqui/parcel.pl and notice that the text input fields on the fieldset element on the left hand side of the screen for filtering search results are too wide and go over the border of the fieldset element 2. Apply patch 3. Refresh the aforementioned pages and notice the text inputs have a shortened width and now fit within the fielset class element Sponsored-By: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19474 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Will need a follow-pu, if pushed after bug 19474. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA Keywords| |rel_18_05_candidate --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It is not a good idea to specify a size in px, you should use a relative lenght instead. We already have div.yui-b fieldset.brief select { width: 12em; } 12em sounds like a good value here. Maybe the following addition would be enough: div.yui-b fieldset.brief input { width: 12em; } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 74842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74842&action=edit Bug 20329: Text input fields are wider than the fieldset class they are inside of This alternate patch defines a width of 100% for text inputs and selects inside sidebar fieldsets. The scope of this style is limited to the sidebar by unsetting the width for fieldsets within "#yui-main," the main body of the page. This patch also removes inline styles from two templates which are now unnecessary. To test, apply the patch and clear your cache if necessary. View various pages which have a sidebar search form: acqui/invoices.pl, members/members-home.pl, circ/overdue.pl, acqui/parcel.pl. Confirm that form fields in the sidebar look correct. Confirm that other forms styled with the "brief" class aren't unintentionally affected by this patch. For example: circ/request-article.pl, members/member-password.pl, reports/reports-home.pl, reserve/request.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74842|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74845&action=edit Bug 20329: Text input fields are wider than the fieldset class they are inside of This alternate patch defines a width of 100% for text inputs and selects inside sidebar fieldsets. The scope of this style is limited to the sidebar by unsetting the width for fieldsets within "#yui-main," the main body of the page. This patch also removes inline styles from two templates which are now unnecessary. To test, apply the patch and clear your cache if necessary. View various pages which have a sidebar search form: acqui/invoices.pl, members/members-home.pl, circ/overdue.pl, acqui/parcel.pl. Confirm that form fields in the sidebar look correct. Confirm that other forms styled with the "brief" class aren't unintentionally affected by this patch. For example: circ/request-article.pl, members/member-password.pl, reports/reports-home.pl, reserve/request.pl Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73468|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74901&action=edit Bug 20329: Shorten the width of text input fields This makes the text input fields fit tidily within the border of the fieldset class elements they are within. Test plan: 1. Go to the acqui/invoices.pl, members/members-home.pl, circ/overdue.pl, acqui/parcel.pl and notice that the text input fields on the fieldset element on the left hand side of the screen for filtering search results are too wide and go over the border of the fieldset element 2. Apply patch 3. Refresh the aforementioned pages and notice the text inputs have a shortened width and now fit within the fielset class element Sponsored-By: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74845|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74902&action=edit Bug 20329: Text input fields are wider than the fieldset class they are inside of This alternate patch defines a width of 100% for text inputs and selects inside sidebar fieldsets. The scope of this style is limited to the sidebar by unsetting the width for fieldsets within "#yui-main," the main body of the page. This patch also removes inline styles from two templates which are now unnecessary. To test, apply the patch and clear your cache if necessary. View various pages which have a sidebar search form: acqui/invoices.pl, members/members-home.pl, circ/overdue.pl, acqui/parcel.pl. Confirm that form fields in the sidebar look correct. Confirm that other forms styled with the "brief" class aren't unintentionally affected by this patch. For example: circ/request-article.pl, members/member-password.pl, reports/reports-home.pl, reserve/request.pl Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20668 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20668 [Bug 20668] Update two-column templates with Bootstrap grid: Acquisitions part 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org